mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Jesse Hathaway <jesse@mbuki-mvuki.org>
To: Rich Felker <dalias@libc.org>
Cc: musl@lists.openwall.com
Subject: Re: [musl] Re: Pending patches for MT-fork stuff
Date: Wed, 30 Sep 2020 09:46:12 -0500	[thread overview]
Message-ID: <CANSNSoV2y91EJ8Ucks3dX_ZYMuBH-A07z6i4wixrNgU7nCy1kg@mail.gmail.com> (raw)
In-Reply-To: <20200930001001.GI17637@brightrain.aerifal.cx>

On Tue, Sep 29, 2020 at 7:10 PM Rich Felker <dalias@libc.org> wrote:
> Here is the offending code:
>
> https://github.com/golang/go/blob/a413908dd064de6e3ea5b8d95d707a532bd3f4c8/src/runtime/signal_unix.go#L866
>
> It should be calling sigfillset() (from libc) to get the starting
> sigset_t rather than using its own all-one-bits initializer.
>
> There may be other places in the runtime where the same error is made.
> It looks like blockableSig (line 1132) is intended to do something
> here, but has hard-coded (somewhere else) glibc knowledge rather than
> probing via (libc's) sigaddset whether the signal number is valid.
> This might be a preferred point to fix it at.

Thanks Rich for diving in and investigating the problem on the Go runtime
side. I am happy to open a bug report on the Go side, but I have a couple
of questions. Would you instead prefer to open the report, since you have
a much deeper understanding of the problem and what changes need to
be made than I? However, if you would rather I create the report, are you
okay with me quoting your analysis? Thanks, Jesse

  reply	other threads:[~2020-09-30 14:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-29 18:04 Jesse Hathaway
2020-09-29 18:36 ` Rich Felker
2020-09-29 18:51   ` Jesse Hathaway
2020-09-29 20:34     ` Rich Felker
2020-09-30  0:10       ` Rich Felker
2020-09-30 14:46         ` Jesse Hathaway [this message]
2020-09-30 15:55           ` Rich Felker
2021-03-03 14:40             ` Jesse Hathaway
2021-03-03 14:43               ` Rich Felker
2021-03-03 20:14                 ` Jesse Hathaway
  -- strict thread matches above, loose matches on Subject: below --
2020-09-29 17:19 Jesse Hathaway

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANSNSoV2y91EJ8Ucks3dX_ZYMuBH-A07z6i4wixrNgU7nCy1kg@mail.gmail.com \
    --to=jesse@mbuki-mvuki.org \
    --cc=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).