From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13799 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Nick Bray Newsgroups: gmane.linux.lib.musl.general Subject: [PATCH] eliminate strict parentheses warnings for byteswaps Date: Thu, 14 Feb 2019 16:24:03 -0800 Message-ID: Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000073a3740581e3cbc8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="111380"; mail-complaints-to="usenet@blaine.gmane.org" To: musl@lists.openwall.com Original-X-From: musl-return-13815-gllmg-musl=m.gmane.org@lists.openwall.com Fri Feb 15 01:24:30 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1guRIr-000Ssn-MA for gllmg-musl@m.gmane.org; Fri, 15 Feb 2019 01:24:29 +0100 Original-Received: (qmail 30098 invoked by uid 550); 15 Feb 2019 00:24:27 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 30060 invoked from network); 15 Feb 2019 00:24:26 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=h1OeW09oF+LdG2DyN/inhxERxQNLR2RyZvv17ETaW60=; b=eID0GrT7gyEQ98a4bNc4oQGgdZ2qgIKhGrRnJuLsKGuCdjwMMH6b78dU1mWUOF3mlL e5MkvyCc1VOIeM/6M9LARLCec2iqn77ukkYK9sIUv2ykxsQNbcBJCj3sMOY8enka/Ybn zS+mR25O2QpNxaPlVtRtIz1v/kyBXIHXVfIeU2oCehYtbC//QDQXXYnqAdfBG9kXGAS0 mtJb1I9qIysJC6ZRsNtOrUUXznmBvJuXRBS7YCXT26YY5YoM0xsYwFWikBUQ2X2Cat9+ vveJVbawrYcUBhfYAVmFXPCQwNMadGTEK2DyjJiQV887vEL6FqzPq5tNNk3iUYxgTKdu B4Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=h1OeW09oF+LdG2DyN/inhxERxQNLR2RyZvv17ETaW60=; b=E0CrvDIbKkUeOJUy4Uiu/wFqZ87loXvtcpMpEW//6RpK/YaBifpaApiJ2e9LfFEqHv 83CmJLXc2QdZklWVRfe93DUuK8DzVyxiYR2Zh2gI5W8tRkVFzXNZ28zcneII0Zhqwudl /dzpP71J+LZlRKNM/D9Bhb9Ph4P2tkSvnjp1S8YOABUeonbUW7mksIQN5s2tYd//qa7C thaGN8skZ8E27zDqrImNtuTB01E9K2RLHBonuEwpXSUPXkvtJYhW5tQzmoARGcx7pVDW aQXjk8v5EyAt/Nx+c49OPmh278xQJ18x5/2ikrap9soApmCYW6/SfwbGU9bzrhLB5gns cNsg== X-Gm-Message-State: AHQUAuaFo66JM48YpTr0NQxNE1/0uv0zAiRS72WlNjR2gmjHVbKADnjY /ZmkndpFahUyg1ggihY7Z43t+xtFqwSR10fnRT40BTvbems= X-Google-Smtp-Source: AHgI3Ibf01OSxTaNCwtZOXKr5g0ZYcorFCH7CyvSg+s0aAwYLtRp/wn5gNiTx8llbITWmOm/n0niYhAYjSPgPXmK/OA= X-Received: by 2002:a02:45db:: with SMTP id o88mr82530jad.32.1550190254429; Thu, 14 Feb 2019 16:24:14 -0800 (PST) Xref: news.gmane.org gmane.linux.lib.musl.general:13799 Archived-At: --00000000000073a3740581e3cbc8 Content-Type: text/plain; charset="UTF-8" Patch is attached. The change was motivated by including Musl's headers from a project with -Werror -Wall enabled. I believe Fucshia ran into this, too. I couldn't think of a good regression test, in part because warnings are somewhat compiler specific. One possible approach would be to enable -Werror -Wall in the main build, but that runs into issues of which compilers are supported and what the core developers prefer. Another approach would be to only lint the header files - generate a dummy .c file that includes all the header files and compile it with -Werror. This is complicated by the "redirection" header files that warn you should use the canonical version. Which header files should be checked? So for the moment I punted on regression testing. I mention this line of thinking in case anyone has some perspective. --00000000000073a3740581e3cbc8 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-eliminate-strict-parentheses-warnings-for-byteswaps.patch" Content-Disposition: attachment; filename="0001-eliminate-strict-parentheses-warnings-for-byteswaps.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_js5axf9b0 RnJvbSAzNDdmZGVjY2Y5MjY4Y2VmYTQwYjgzODk3OTBlNDY1YTNlMmU2NTg3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNrIEJyYXkgPG5jYnJheUBnb29nbGUuY29tPgpEYXRlOiBU aHUsIDE3IEphbiAyMDE5IDE1OjUzOjQ2IC0wODAwClN1YmplY3Q6IFtQQVRDSF0gZWxpbWluYXRl IHN0cmljdCBwYXJlbnRoZXNlcyB3YXJuaW5ncyBmb3IgYnl0ZXN3YXBzCgphZGRpbmcgdGhlc2Ug cGFyZW50aGVzZXMgZWxpbWluYXRlcyBhIHdhcm5pbmcgZnJvbSAtV3BhcmVudGhlc2VzLCBidXQK ZG9lcyBub3QgY2hhbmdlIHRoZSBzZW1hbnRpY3Mgb2YgdGhlIGNvZGUuCi0tLQogaW5jbHVkZS9i eXRlc3dhcC5oIHwgNCArKy0tCiBpbmNsdWRlL2VuZGlhbi5oICAgfCA0ICsrLS0KIDIgZmlsZXMg Y2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2lu Y2x1ZGUvYnl0ZXN3YXAuaCBiL2luY2x1ZGUvYnl0ZXN3YXAuaAppbmRleCAwMGI5ZGYzYy4uOTI4 YmUyYjMgMTAwNjQ0Ci0tLSBhL2luY2x1ZGUvYnl0ZXN3YXAuaAorKysgYi9pbmNsdWRlL2J5dGVz d2FwLmgKQEAgLTExLDEyICsxMSwxMiBAQCBzdGF0aWMgX19pbmxpbmUgdWludDE2X3QgX19ic3dh cF8xNih1aW50MTZfdCBfX3gpCiAKIHN0YXRpYyBfX2lubGluZSB1aW50MzJfdCBfX2Jzd2FwXzMy KHVpbnQzMl90IF9feCkKIHsKLQlyZXR1cm4gX194Pj4yNCB8IF9feD4+OCYweGZmMDAgfCBfX3g8 PDgmMHhmZjAwMDAgfCBfX3g8PDI0OworCXJldHVybiBfX3g+PjI0IHwgKF9feD4+OCYweGZmMDAp IHwgKF9feDw8OCYweGZmMDAwMCkgfCBfX3g8PDI0OwogfQogCiBzdGF0aWMgX19pbmxpbmUgdWlu dDY0X3QgX19ic3dhcF82NCh1aW50NjRfdCBfX3gpCiB7Ci0JcmV0dXJuIF9fYnN3YXBfMzIoX194 KSswVUxMPDwzMiB8IF9fYnN3YXBfMzIoX194Pj4zMik7CisJcmV0dXJuIChfX2Jzd2FwXzMyKF9f eCkrMFVMTCk8PDMyIHwgX19ic3dhcF8zMihfX3g+PjMyKTsKIH0KIAogI2RlZmluZSBic3dhcF8x Nih4KSBfX2Jzd2FwXzE2KHgpCmRpZmYgLS1naXQgYS9pbmNsdWRlL2VuZGlhbi5oIGIvaW5jbHVk ZS9lbmRpYW4uaAppbmRleCAxYmQ0NDQ1MS4uODhjMzM0N2IgMTAwNjQ0Ci0tLSBhL2luY2x1ZGUv ZW5kaWFuLmgKKysrIGIvaW5jbHVkZS9lbmRpYW4uaApAQCAtMjksMTIgKzI5LDEyIEBAIHN0YXRp YyBfX2lubGluZSB1aW50MTZfdCBfX2Jzd2FwMTYodWludDE2X3QgX194KQogCiBzdGF0aWMgX19p bmxpbmUgdWludDMyX3QgX19ic3dhcDMyKHVpbnQzMl90IF9feCkKIHsKLQlyZXR1cm4gX194Pj4y NCB8IF9feD4+OCYweGZmMDAgfCBfX3g8PDgmMHhmZjAwMDAgfCBfX3g8PDI0OworCXJldHVybiBf X3g+PjI0IHwgKF9feD4+OCYweGZmMDApIHwgKF9feDw8OCYweGZmMDAwMCkgfCBfX3g8PDI0Owog fQogCiBzdGF0aWMgX19pbmxpbmUgdWludDY0X3QgX19ic3dhcDY0KHVpbnQ2NF90IF9feCkKIHsK LQlyZXR1cm4gX19ic3dhcDMyKF9feCkrMFVMTDw8MzIgfCBfX2Jzd2FwMzIoX194Pj4zMik7CisJ cmV0dXJuIChfX2Jzd2FwMzIoX194KSswVUxMKTw8MzIgfCBfX2Jzd2FwMzIoX194Pj4zMik7CiB9 CiAKICNpZiBfX0JZVEVfT1JERVIgPT0gX19MSVRUTEVfRU5ESUFOCi0tIAoyLjIxLjAucmMwLjI1 OC5nODc4ZTJjZDMwZS1nb29nCgo= --00000000000073a3740581e3cbc8--