* [musl] A typo in Makefile?
@ 2024-08-10 2:05 Charlie Qiu
2024-08-10 3:06 ` Rich Felker
0 siblings, 1 reply; 2+ messages in thread
From: Charlie Qiu @ 2024-08-10 2:05 UTC (permalink / raw)
To: musl
[-- Attachment #1: Type: text/plain, Size: 424 bytes --]
Hi all,
I was reading the musl Makefile (latest commit dd1e63). Line 113 reads:
obj/crt/crt1.o obj/crt/scrt1.o obj/crt/rcrt1.o obj/ldso/dlstart.lo:
$(srcdir)/arch/$(ARCH)/crt_arch.h
Should the second file be Scrt1.o (capital S) rather than scrt1.o (small
s)? The capital version is used on line 117 below and all other places. The
small s seems to be introduced in commit 2f853d (support out-of-tree build).
Charlie Qiu
[-- Attachment #2: Type: text/html, Size: 1013 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [musl] A typo in Makefile?
2024-08-10 2:05 [musl] A typo in Makefile? Charlie Qiu
@ 2024-08-10 3:06 ` Rich Felker
0 siblings, 0 replies; 2+ messages in thread
From: Rich Felker @ 2024-08-10 3:06 UTC (permalink / raw)
To: Charlie Qiu; +Cc: musl
On Fri, Aug 09, 2024 at 10:05:13PM -0400, Charlie Qiu wrote:
> Hi all,
>
> I was reading the musl Makefile (latest commit dd1e63). Line 113 reads:
>
> obj/crt/crt1.o obj/crt/scrt1.o obj/crt/rcrt1.o obj/ldso/dlstart.lo:
> $(srcdir)/arch/$(ARCH)/crt_arch.h
>
> Should the second file be Scrt1.o (capital S) rather than scrt1.o (small
> s)? The capital version is used on line 117 below and all other places. The
> small s seems to be introduced in commit 2f853d (support out-of-tree build).
Thanks! Indeed this seems to be a mistake. I'll commit a fix.
Rich
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-10 3:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-10 2:05 [musl] A typo in Makefile? Charlie Qiu
2024-08-10 3:06 ` Rich Felker
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).