From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/747
Path: news.gmane.org!not-for-mail
From: Pascal Cuoq <pascal.cuoq@gmail.com>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: musl 0.8.9 released
Date: Sun, 22 Apr 2012 14:19:53 +0200
Message-ID: <CAOH62JhgiA4j3NdBJY+QBb8Db4CLuVOmOUh5Y=LHGXnbghUKoQ@mail.gmail.com>
References: <20120420020626.GC14673@brightrain.aerifal.cx>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-Trace: dough.gmane.org 1335097208 8698 80.91.229.3 (22 Apr 2012 12:20:08 GMT)
X-Complaints-To: usenet@dough.gmane.org
NNTP-Posting-Date: Sun, 22 Apr 2012 12:20:08 +0000 (UTC)
To: musl@lists.openwall.com
Original-X-From: musl-return-748-gllmg-musl=m.gmane.org@lists.openwall.com Sun Apr 22 14:20:07 2012
Return-path: <musl-return-748-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@plane.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by plane.gmane.org with smtp (Exim 4.69)
	(envelope-from <musl-return-748-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1SLvlv-0001UZ-B3
	for gllmg-musl@plane.gmane.org; Sun, 22 Apr 2012 14:20:07 +0200
Original-Received: (qmail 7565 invoked by uid 550); 22 Apr 2012 12:20:05 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
Original-Received: (qmail 7557 invoked from network); 22 Apr 2012 12:20:05 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        bh=w/GtPyvLO6mHNvfTnNfjSHq5S4x7fD1NtzenXXGA70w=;
        b=zitSPrgdItBGhttwfeksAuE71CHivCx3wkabJsX+iWr6qhM/Z3YwPbBwon21JuPdum
         7xrGjqirUfMTZNHvMRKtWYdXUiP4jUxheL3VUC/G7FTvjRHX2yQrxuXGB/iraNM7IPPn
         PIKhF3sn0jm3yCVmG+TRz1o7oZR0CX43JK0+TwTmIHbSr4uArhtpCS9QXwUVA0ulrFAV
         tT7hbQNUWMl9lE+2zDwbtQBYlXPWHlmXqQgNudOAT/5L49jmKOxDZspVyqiyqR1Lzgrw
         Maz+urRw1CbVs5eMNqJWVeN1EOF21C6HdAQw47qZ8vnc83fLqbgWyvJChCWj3LgkPqfd
         cyPg==
In-Reply-To: <20120420020626.GC14673@brightrain.aerifal.cx>
Xref: news.gmane.org gmane.linux.lib.musl.general:747
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/747>

On Fri, Apr 20, 2012 at 4:06 AM, Rich Felker <dalias@aerifal.cx> wrote:
> =A0 =A0Bug-fix release for a serious breakage in strtol and related
> =A0 =A0functions that made it into the previous release and prevents them
> =A0 =A0from handling numbers with initial spaces.

Sorry for arriving after the battle, and it is nowhere near as serious, but=
:

src/internal/floatscan.c, line 136:

	/* Align incomplete final B1B digit */
	if (k<KMAX && j) {

The condition k<KMAX always holds. The earlier for-loop can be exited
with at most k =3D=3D KMAX-2.
You probably meant:

   if (k < KMAX-2 && j).

If you took a bit of safety margin in your choice of KMAX limits, it
seems to me that it may never matter. But if this is the case, why
bother testing k at all?

Pascal