From: Pascal Cuoq <pascal.cuoq@gmail.com>
To: musl@lists.openwall.com
Subject: Re: float scanner status, upcoming release
Date: Tue, 10 Apr 2012 02:09:23 +0200 [thread overview]
Message-ID: <CAOH62JiTZkXrA71xjFGBp5ZweNg_y4c7wUjsfAufpKpgqnF7hQ@mail.gmail.com> (raw)
In-Reply-To: <20120409192149.GH8803@brightrain.aerifal.cx>
On Mon, Apr 9, 2012 at 9:21 PM, Rich Felker <dalias@aerifal.cx> wrote:
> And here's the current code (standalone test program) if anybody wants
> to play with it or point out how much single-letter variable names
> suck or whatnot.. :-)
Line 72:
x[k] = x[k]*10 + c-'0';
I don't understand why this read access to x[k] is initialized.
If I change the declaration of local array x[] as:
uint32_t x[KMAX] = { 1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1};
then:
$ ./a.out
1.123
...
y = 11.123
Initializing x[] with arbitrary values shouldn't change anything
if it was not used uninitialized, right?
Even if I am getting something wrong here, you can count on me
to test the heck out of your function. I initially subscribed to
the musl mailing because I had been looking for a function like
this (although I let the musl source code distract me then).
Pascal
next prev parent reply other threads:[~2012-04-10 0:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 19:17 Rich Felker
2012-04-09 19:21 ` Rich Felker
2012-04-10 0:09 ` Pascal Cuoq [this message]
2012-04-10 0:36 ` Rich Felker
2012-04-10 0:48 ` Rich Felker
2012-04-10 12:15 ` Szabolcs Nagy
2012-04-10 13:02 ` Rich Felker
2012-04-10 15:24 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOH62JiTZkXrA71xjFGBp5ZweNg_y4c7wUjsfAufpKpgqnF7hQ@mail.gmail.com \
--to=pascal.cuoq@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).