From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/697
Path: news.gmane.org!not-for-mail
From: Pascal Cuoq <pascal.cuoq@gmail.com>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: float scanner status, upcoming release
Date: Tue, 10 Apr 2012 02:09:23 +0200
Message-ID: <CAOH62JiTZkXrA71xjFGBp5ZweNg_y4c7wUjsfAufpKpgqnF7hQ@mail.gmail.com>
References: <20120409191712.GA5269@brightrain.aerifal.cx>
	<20120409192149.GH8803@brightrain.aerifal.cx>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
X-Trace: dough.gmane.org 1334016583 6711 80.91.229.3 (10 Apr 2012 00:09:43 GMT)
X-Complaints-To: usenet@dough.gmane.org
NNTP-Posting-Date: Tue, 10 Apr 2012 00:09:43 +0000 (UTC)
To: musl@lists.openwall.com
Original-X-From: musl-return-698-gllmg-musl=m.gmane.org@lists.openwall.com Tue Apr 10 02:09:42 2012
Return-path: <musl-return-698-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@plane.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by plane.gmane.org with smtp (Exim 4.69)
	(envelope-from <musl-return-698-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1SHOeO-00051f-7C
	for gllmg-musl@plane.gmane.org; Tue, 10 Apr 2012 02:09:36 +0200
Original-Received: (qmail 17735 invoked by uid 550); 10 Apr 2012 00:09:35 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
Original-Received: (qmail 17727 invoked from network); 10 Apr 2012 00:09:35 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        bh=QhGjipvG3hlr3xFmzWt02Cf2U42KsUQRa3ZcTpb9Xfk=;
        b=qvTeEFuYMb8Y/GnsMtUNupHp2zS8A51bizVLqEQD6clbWeQuNyb9NEMsmkAkPb3N1z
         EuqFZUt9/eltOJxbV8HoRIQuQuGgvHgEE4mto7FA4gqroaZoOfEGq2JOj/fd51ebFcut
         1rhCtkEaYggLDW/dNCn4O89n37Vp9wS1TcKYERyUI8+vqAAB3+SafFqRPZ04yOtDss7z
         VmdeksTdJiToxDyBCeAM74efIv5M9Yt9MkLTmFWM/IOkEGzHABCAoqFV5RfmzZhYK+X9
         dZjttLiQUSXNtk/7a96sW+MMNVm1mCd3Ll3xCqoghApsL6/SI3i9/LjQpTLkAaDjFcfM
         brJQ==
In-Reply-To: <20120409192149.GH8803@brightrain.aerifal.cx>
Xref: news.gmane.org gmane.linux.lib.musl.general:697
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/697>

On Mon, Apr 9, 2012 at 9:21 PM, Rich Felker <dalias@aerifal.cx> wrote:
> And here's the current code (standalone test program) if anybody wants
> to play with it or point out how much single-letter variable names
> suck or whatnot.. :-)

Line 72:

			x[k] = x[k]*10 + c-'0';

I don't understand why this read access to x[k] is initialized.
If I change the declaration of local array x[] as:

  uint32_t x[KMAX] = { 1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1};

then:

$ ./a.out
1.123
...
y = 11.123

Initializing x[] with arbitrary values shouldn't change anything
if it was not used uninitialized, right?

Even if I am getting something wrong here, you can count on me
to test the heck out of your function. I initially subscribed to
the musl mailing because I had been looking for a function like
this (although I let the musl source code distract me then).

Pascal