From: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
To: musl@lists.openwall.com
Subject: Re: Bug in gets function?
Date: Tue, 12 Feb 2019 14:55:19 +0000 [thread overview]
Message-ID: <CAOL8xrVgOyC=9SnOfgsfU6M2uHe491SdDZM+ePAxD_eeSVArbQ@mail.gmail.com> (raw)
In-Reply-To: <CAEfvv4+Jn8DMFrtQ9ow-smrXg3rjhz7X5vOaCrVzR4W1=bKcRA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2336 bytes --]
> Is gets(s) equivalent to scanf("%[^\n]%*1[\n]",s)?
I think it has at least one minor issue: it doesn't null-terminate the
buffer on empty input i.e., just a newline as input.
Regards,
Ponnuvel
On Tue, Feb 12, 2019 at 2:42 PM James Larrowe <larrowe.semaj11@gmail.com>
wrote:
> I could probably try patching it. That C99 specification seems descriptive
> enough.
>
> On Mon, Feb 11, 2019 at 10:51 PM Rich Felker <dalias@libc.org> wrote:
>
>> On Mon, Feb 11, 2019 at 10:48:38PM -0500, Rich Felker wrote:
>> > On Mon, Feb 11, 2019 at 06:55:24PM -0800, Keyhan Vakil wrote:
>> > > Hi. It seems that the gets function does not follow the C99 spec. In
>> > > particular, if the input contains a null byte in the middle of the
>> > > input, then the new-line character is not discarded.
>> > >
>> > > For reference, here's the relevant part in the C99 standard
>> > > (7.19.7.7):
>> > >
>> > > > The gets function reads characters from the input stream pointed to
>> > > > by stdin, into the array pointed to by s, until end-of-file is
>> > > > encountered or a new-line character is read. Any new-line character
>> > > > is discarded, and a null character is written immediately after the
>> > > > last character read into the array.
>> > >
>> > > Here is an example:
>> > >
>> > > #include <stdio.h>
>> > > char s[8];
>> > > int main() {
>> > > gets(s);
>> > > for (int i = 0; i < sizeof s; i++) {
>> > > printf("%02x ", s[i]);
>> > > }
>> > > printf("\n");
>> > > return 0;
>> > > }
>> > >
>> > > When compiled against gcc:
>> > >
>> > > $ echo -e 'A\x00B' | ./a.out
>> > > 41 00 42 00 00 00 00 00
>> > >
>> > > When compiled against musl:
>> > >
>> > > $ echo -e 'A\x00B' | ./a.out
>> > > 41 00 42 0a 00 00 00 00
>> > >
>> > > Note the terminating newline, which contradicts the spec.
>> >
>> > I think this bug report is correct; however the gets function is
>> > awful, removed in C11, and should never be used. :-)
>> >
>> > I will see what can be done to fix it though.
>>
>> Is gets(s) equivalent to scanf("%[^\n]%*1[\n]",s)? If so that would be
>> an appropriately hideous way to implement it that avoids the current
>> bug? :-)
>>
>> Rich
>>
>
--
Regards,
Ponnuvel P
[-- Attachment #2: Type: text/html, Size: 3488 bytes --]
next prev parent reply other threads:[~2019-02-12 14:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 2:55 Keyhan Vakil
2019-02-12 3:48 ` Rich Felker
2019-02-12 3:51 ` Rich Felker
2019-02-12 14:41 ` James Larrowe
2019-02-12 14:55 ` Ponnuvel Palaniyappan [this message]
2019-02-12 16:30 ` Rich Felker
2019-02-13 21:39 ` Alexey Izbyshev
2019-02-13 22:13 ` Rich Felker
2019-02-13 23:19 ` Alexey Izbyshev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOL8xrVgOyC=9SnOfgsfU6M2uHe491SdDZM+ePAxD_eeSVArbQ@mail.gmail.com' \
--to=pponnuvel@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).