mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Yu Kobayashi <yukoba@gmail.com>
To: musl@lists.openwall.com
Subject: Re: SUN_LEN
Date: Thu, 22 Aug 2013 02:58:28 +0900	[thread overview]
Message-ID: <CAOayUkaGT=GBc=5rFViBYLZuehVm-t3FYAR2EV-cojKrX3GtYg@mail.gmail.com> (raw)
In-Reply-To: <CAOayUkZ_oz_FxxSyVUT=mFzyZebQySirH5vwTC6EixbT_Ga9nA@mail.gmail.com>

>> Why is it a bad thing to include <string.h>?
>> Worry about cyclic dependency?
> Well it puts a lot more stuff into the namespace and has a much larger
> parsing cost

How about this.

#if defined(_BSD_SOURCE) || defined(_GNU_SOURCE)
#define SUN_LEN(s) __sun_len(s)
#endif

And add __sun_len.c like this.

#include <string.h>
#include <sys/un.h>

size_t __sun_len(struct sockaddr_un *s)
{
    return sizeof(sa_family_t) + strlen(s->sun_path);
}

I think this solve the problem.

--

Yu Kobayashi <yukoba@gmail.com>


  reply	other threads:[~2013-08-21 17:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21  9:57 SUN_LEN 小林悠
2013-08-21 12:03 ` SUN_LEN John Spencer
2013-08-21 12:23   ` SUN_LEN 小林悠
2013-08-21 12:38     ` SUN_LEN John Spencer
2013-08-21 13:27       ` SUN_LEN 小林悠
2013-08-21 14:45         ` SUN_LEN Szabolcs Nagy
2013-08-21 15:25           ` SUN_LEN 小林悠
2013-08-21 16:23           ` SUN_LEN Rich Felker
2013-08-21 16:34             ` SUN_LEN Szabolcs Nagy
2013-08-21 16:36               ` SUN_LEN Rich Felker
2013-08-21 16:42                 ` SUN_LEN Rich Felker
2013-08-21 17:00                   ` SUN_LEN Szabolcs Nagy
2013-08-21 17:11                     ` SUN_LEN Yu Kobayashi
2013-08-21 17:25                       ` SUN_LEN Rich Felker
2013-08-21 17:29                         ` SUN_LEN Yu Kobayashi
2013-08-21 17:58                           ` Yu Kobayashi [this message]
2013-08-21 18:07                             ` SUN_LEN Rich Felker
2013-08-21 17:32                       ` SUN_LEN Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOayUkaGT=GBc=5rFViBYLZuehVm-t3FYAR2EV-cojKrX3GtYg@mail.gmail.com' \
    --to=yukoba@gmail.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).