From: He X <xw897002528@gmail.com>
To: musl@lists.openwall.com
Subject: Re: a bug in bindtextdomain() and strip '.UTF-8'
Date: Sun, 29 Jan 2017 12:52:56 +0800 [thread overview]
Message-ID: <CAPG2z08Sd0F50iiQohqjYQfJMZkqhTFCkRT59R91TiVG0wNiNQ@mail.gmail.com> (raw)
In-Reply-To: <CAPG2z08mpVnx8nDc1703Ejhb0pwQqjG1SynHcafHO-NcqaKTrg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]
found two more bugs related to intl:
1. no memset after malloc, caused chromium crash:
http://www.openwall.com/lists/musl/2017/01/28/1
--- musl-1.1.16/src/locale/dcngettext.c 2017-01-29 04:42:49.002221317 +0000
+++ musl-1.1.16/src/locale/dcngettext.c 2017-01-29 04:42:49.002221317 +0000
@@ -180,6 +180,7 @@
__munmap((void *)map, map_size);
goto notrans;
}
+ memset(p, 0, sizeof *p + namelen + 1);
p->map = map;
p->map_size = map_size;
memcpy(p->name, name, namelen+1);
2. musl uses generic config of libstdc++, which blocked the support of
locale, patch is there:
https://github.com/xhebox/noname-linux/issues/2#issuecomment-275704150
2017-01-20 19:25 GMT+08:00 He X <xw897002528@gmail.com>:
> sorry for my poor english :D
>
> first, it's not p->domainname but q->domainname in dcngettext:77.
>
> second, any news about http://www.openwall.com/lists/musl/2016/05/11/81?
> strip '.UTF-8' is important, i think.
>
> irc log:
> 18:58 < xhe> @dalias: i must found a bug in bindtextdomain(), and also the
> improvement about stripping '.UTF-8' should be merged(my code sucks,
> that's for my tests), detailed: http://pastebin.com/3C2APqMH
>
[-- Attachment #2: Type: text/html, Size: 3170 bytes --]
next prev parent reply other threads:[~2017-01-29 4:52 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 11:25 He X
2017-01-29 4:52 ` He X [this message]
2017-01-29 13:39 ` Szabolcs Nagy
2017-01-29 14:07 ` Rich Felker
2017-01-29 14:48 ` He X
2017-01-29 15:55 ` Rich Felker
2017-01-29 16:14 ` He X
2017-01-29 16:33 ` Rich Felker
2017-02-08 10:13 ` He X
2017-02-08 14:31 ` Rich Felker
2017-02-09 9:49 ` He X
2017-02-11 2:36 ` Rich Felker
2017-02-11 6:00 ` He X
2017-02-11 23:59 ` Rich Felker
2017-02-12 2:34 ` Rich Felker
2017-02-12 6:56 ` He X
2017-02-12 7:11 ` He X
2017-02-13 17:08 ` Rich Felker
2017-02-13 8:01 ` He X
2017-02-13 13:28 ` Rich Felker
2017-02-13 14:06 ` He X
2017-02-13 17:12 ` Rich Felker
2017-03-04 8:02 ` He X
2017-03-17 19:27 ` Rich Felker
2017-03-17 19:37 ` Rich Felker
2017-03-18 7:34 ` He X
2017-03-18 12:28 ` Rich Felker
2017-03-18 13:50 ` He X
2017-02-13 14:12 ` He X
2017-02-13 17:13 ` Rich Felker
2017-01-29 16:37 ` Rich Felker
2017-01-30 0:37 ` He X
2017-01-30 14:17 ` He X
2017-01-29 16:40 ` Szabolcs Nagy
2017-01-29 16:49 ` Rich Felker
2017-01-30 12:36 ` He X
2017-01-30 13:05 ` Szabolcs Nagy
2017-01-30 1:32 ` He X
-- strict thread matches above, loose matches on Subject: below --
2017-01-20 11:11 He X
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPG2z08Sd0F50iiQohqjYQfJMZkqhTFCkRT59R91TiVG0wNiNQ@mail.gmail.com \
--to=xw897002528@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).