mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Gonzalo Alvarez <gonzaloab@gmail.com>
To: musl@lists.openwall.com
Subject: [musl] alltype header typo in reg and user
Date: Fri, 10 May 2024 20:27:34 -0700	[thread overview]
Message-ID: <CAPHVM6dPd0EaYV6RvTkWSW7OggHf=PajXC5w9oDiiUkq0wqd4g@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

First report here - forgive me if I'm missing something.

I'm using musl to build a cross toolchain for risc-v (specifically the
xuantie v0.7.1 vector c906v version). When using the headers to build the
packages in the buildroot, I hit an issue when including either sys/reg.h
or sys/user.h, since it looks like there was a recent change that added an
include there to bring 'alltypes.h' into those files, but the change is
missing the 's' at the end. The diff is more descriptive.

diff --git a/include/sys/reg.h b/include/sys/reg.h
index 4e6ce222..0272e137 100644
--- a/include/sys/reg.h
+++ b/include/sys/reg.h
@@ -4,7 +4,7 @@
 #include <limits.h>
 #include <unistd.h>

-#include <bits/alltype.h>
+#include <bits/alltypes.h>

 #undef __WORDSIZE
 #if __LONG_MAX == 0x7fffffffL
diff --git a/include/sys/user.h b/include/sys/user.h
index 78036da3..511caba3 100644
--- a/include/sys/user.h
+++ b/include/sys/user.h
@@ -8,7 +8,7 @@ extern "C" {
 #include <stdint.h>
 #include <unistd.h>

-#include <bits/alltype.h>
+#include <bits/alltypes.h>

 #undef __WORDSIZE
 #if __LONG_MAX == 0x7fffffffL


It seems like the issue was introduced here:

https://git.musl-libc.org/cgit/musl/commit/include/sys/reg.h?id=e709a6f07ade208ba513f9225222336f30c304b0

Thx!

[-- Attachment #2: Type: text/html, Size: 1706 bytes --]

             reply	other threads:[~2024-05-11  8:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-11  3:27 Gonzalo Alvarez [this message]
2024-05-11 21:55 ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPHVM6dPd0EaYV6RvTkWSW7OggHf=PajXC5w9oDiiUkq0wqd4g@mail.gmail.com' \
    --to=gonzaloab@gmail.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).