From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/3595
Path: news.gmane.org!not-for-mail
From: Andre Renaud <andre@bluewatersys.com>
Newsgroups: gmane.linux.lib.musl.general
Subject: endian.h warnings
Date: Wed, 10 Jul 2013 14:21:58 +1200
Message-ID: <CAPfzE3ZSbwgBi=YLaqJ0qvYYN8Hp9qFiQSx=QGA8MYZqJyYnQA@mail.gmail.com>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
X-Trace: ger.gmane.org 1373422930 31220 80.91.229.3 (10 Jul 2013 02:22:10 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Wed, 10 Jul 2013 02:22:10 +0000 (UTC)
To: musl@lists.openwall.com
Original-X-From: musl-return-3599-gllmg-musl=m.gmane.org@lists.openwall.com Wed Jul 10 04:22:12 2013
Return-path: <musl-return-3599-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@plane.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by plane.gmane.org with smtp (Exim 4.69)
	(envelope-from <musl-return-3599-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1Uwk2l-0001Dc-Pz
	for gllmg-musl@plane.gmane.org; Wed, 10 Jul 2013 04:22:11 +0200
Original-Received: (qmail 18366 invoked by uid 550); 10 Jul 2013 02:22:10 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
Original-Received: (qmail 18358 invoked from network); 10 Jul 2013 02:22:10 -0000
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20120113;
        h=mime-version:date:message-id:subject:from:to:content-type
         :x-gm-message-state;
        bh=qMZhnacSyUpQIpCfxbAFK4CwTkdVT1PiX1Gput8vCCw=;
        b=MKcbZmO9DtwsyXUIwltIaTKsx5+kUc6ophFDMUSwp3SCgjvYosjCmJtIQcbtYvCPy2
         xnP/lD3CRXb8tIOaJLA0c0if05DAYVH8eOKy7YfcdRGtsRrSQXEXTw90ExoJn2n20ocs
         d2l4VjzeS7KsgyUiq6yOFh0lU/K2CNown5UX0Qm4J01OOQDKC5Cg9g72rgUOqEwzUkOd
         JKq9alnbVLuUVQu5dNKNyUBOI51tAAPuAkszNUJ8VilXEk7t+DXIoqNx20+7dP760Qp1
         MRRY4kM0xpAST3lJA5fsbsn5R/Kp1B/KMP8maI4crTGlacOomI2xDIZdw9JY0TxLeCZW
         f0ww==
X-Received: by 10.60.138.137 with SMTP id qq9mr26287336oeb.8.1373422918733;
 Tue, 09 Jul 2013 19:21:58 -0700 (PDT)
X-Gm-Message-State: ALoCoQnGr7f3IqBwqNy8PeTjORBoMYmbSpeMGtwI5RCiF6NqzWBIs1MJW8DXAbLXTwnEmBt2IbUf
Xref: news.gmane.org gmane.linux.lib.musl.general:3595
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/3595>

Hi,
When using musl with -Wparentheses enabled, I get the following warnings:
../include/endian.h: In function '__bswap32':
../include/endian.h:32:2: warning: suggest parentheses around
arithmetic in operand of '|' [-Wparentheses]
../include/endian.h:32:2: warning: suggest parentheses around
arithmetic in operand of '|' [-Wparentheses]
../include/endian.h: In function '__bswap64':
../include/endian.h:37:2: warning: suggest parentheses around '+'
inside '<<' [-Wparentheses]

I appreciate that these aren't bugs, and are just gcc being over
enthusiastic in it's warnings (which I've asked it to be on the
command line), however would it be worth sticking some parentheses
into the code simply to avoid this kind of noise being visible for
users?

Regards,
Andre