From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/7353 Path: news.gmane.org!not-for-mail From: Eugene Yudin Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] MIPS big endian and *stat syscalls return value Date: Tue, 7 Apr 2015 21:18:33 +0300 Message-ID: References: <5523A299.5050209@ndmsystems.com> <20150407115821.GA31681@port70.net> <20150407143415.GI6817@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1147e85e44ef030513267183 X-Trace: ger.gmane.org 1428430734 17870 80.91.229.3 (7 Apr 2015 18:18:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 7 Apr 2015 18:18:54 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-7366-gllmg-musl=m.gmane.org@lists.openwall.com Tue Apr 07 20:18:53 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1YfY5H-0001gT-8x for gllmg-musl@m.gmane.org; Tue, 07 Apr 2015 20:18:47 +0200 Original-Received: (qmail 15559 invoked by uid 550); 7 Apr 2015 18:18:45 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 15541 invoked from network); 7 Apr 2015 18:18:45 -0000 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=3QG1ejQLOai9cYCptgWYtDPF5szqJzCdybp5t6DmSTI=; b=l2IsSjUOmwviwB6ixNhTwsBllDZc/yFEOGi8/6PE5jueAj/iy5brlNjDM7bIPe+Dmr tWuDUefwENMWCNekodvBAPBiD7Lf9GiXmx/3ICBfqhMEbdxqQsfRhKaPk7/HpM67S81m QyU/ZrzGeuYlbM/kk/Lg+2m73R0RqpppDtgn/dlenrof4UTt5eWLNsU25H2sJv47QOvM aFQ5vFCsWRM2d7mFFeH1G0qYzs20dhkPyQI/YNjdZ5nuHP5xcFoqEoj/5VL+P509m1dS 1q2XME8G+jzIGscrrtPe2ezDGNFZNtvN5MkrYTvWpSnJWJzZf+x2xsjw+M5C7z/WL73N oCcA== X-Gm-Message-State: ALoCoQkWpDQR5MYucqIZ4HpFqAlSmuHJmo2a0tgCigS+JPcwbXgpvKEygPCXAOF+ScD/j2TOcMii X-Received: by 10.55.31.218 with SMTP id n87mr39019826qkh.99.1428430713576; Tue, 07 Apr 2015 11:18:33 -0700 (PDT) In-Reply-To: <20150407143415.GI6817@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:7353 Archived-At: --001a1147e85e44ef030513267183 Content-Type: text/plain; charset=UTF-8 Thanks for a quick response! On Tue, Apr 7, 2015 at 5:34 PM, Rich Felker wrote: > I'm > guessing you need -O0 to trigger it, no? I'm experience problem with optimization for size (-Os). It's look like behaviour was changed in later GCC (at least from 4.8.3). I will test another optimization levels. > > i wonder if __stat_fix could be inlined in a way that the > > compiler knows it shouldnt clobber r2. > > In practice it always is, at least for me. But relying on that for > semantic purposes is not valid. > I read that in linux kernel are used attribute "always_inline" for critical parts. --001a1147e85e44ef030513267183 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Than= ks for a quick response!

On Tue, Ap= r 7, 2015 at 5:34 PM, Rich Felker <dalias@libc.org> wrote:
=
I'm
guessing you need -O0 to trigger it, no?
=C2=A0
= I'm experience problem with optimization for size (-Os).
= It's look like behaviour was changed in later GCC (at least from 4.8.3)= .
I will test another optimization levels.
=C2= =A0
> i wonder = if __stat_fix could be inlined in a way that the
> compiler knows it shouldnt clobber r2.

In practice it always is, at least for me. But relying on that for semantic purposes is not valid.

I read that in linux kernel are used attribute "always_inline"= for critical parts.

--001a1147e85e44ef030513267183--