From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 27358 invoked from network); 17 Dec 2021 08:04:45 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 17 Dec 2021 08:04:45 -0000 Received: (qmail 21894 invoked by uid 550); 17 Dec 2021 08:04:43 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 21862 invoked from network); 17 Dec 2021 08:04:42 -0000 X-Virus-Scanned: SPAM Filter at disroot.org Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1639728262; bh=jhE21UGMLpySRNOmZaCX4DlCNA/0ie7crIkDzAe54Kk=; h=Date:Cc:Subject:From:To:References:In-Reply-To; b=PKNUUhn9+patIxw3YlcOH/k0D4pz13C8/cG8A+Fj9YTcfxsafWemD6dzSU4R6k86Z CHhJcJtyvM//kgCbrmpQJo90gI5No0HwuOoSYjrz+O18EW45yc9zB0vbhBcq+BC9S3 NtDi8Mb/P74K8DoJ6M6bDlhvm45yTuBnAFfaLGnlEYuJAK9cklTTAkb2Y5ipftZWgW p15Z7r18QoAWRo1Fz7qnEF/B8wkT7KE7qZak1H9D0al8B5bN8WRYK/9+4qoFKXPIYH qJwDHPnEvrzqbmXRIehYFWLeIkV6agvRCADj3RCygv2RPHC7gbpWvcAUch59rUZjMr hPsGzEhpCXfCQ== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 17 Dec 2021 05:04:18 -0300 Message-Id: Cc: From: =?utf-8?q?=C3=89rico_Nogueira?= To: References: <20211217075943.2167-1-ericonr@disroot.org> In-Reply-To: <20211217075943.2167-1-ericonr@disroot.org> Subject: Re: [musl] [PATCH] add SEEK_DATA and SEEK_HOLE to On Fri Dec 17, 2021 at 4:59 AM -03, =C3=89rico Nogueira wrote: > these are linux specific constants. glibc exposes them behind > _GNU_SOURCE, but, since SEEK_* is reserved for the implementation, we > can simply define them. furthermore, since they can't be used with > fseek() and other functions that deal with FILE, we don't add them to > . Since we are now adding these flags to headers, it might make sense to revisit [1], which I came across while looking for patches related to SEEK_* constants. If all we need is to restrict acceptable whence values, I can try to make a patch. [1] https://inbox.vuxu.org/musl/20191024140649.GO16318@brightrain.aerifal.c= x/ > --- > include/unistd.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/unistd.h b/include/unistd.h > index ee2dbe8a..212263a7 100644 > --- a/include/unistd.h > +++ b/include/unistd.h > @@ -14,6 +14,8 @@ extern "C" { > #define SEEK_SET 0 > #define SEEK_CUR 1 > #define SEEK_END 2 > +#define SEEK_DATA 3 > +#define SEEK_HOLE 4 > =20 > #if __cplusplus >=3D 201103L > #define NULL nullptr > -- > 2.34.1