From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,
	RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 26758 invoked from network); 20 Feb 2022 03:55:10 -0000
Received: from mother.openwall.net (195.42.179.200)
  by inbox.vuxu.org with ESMTPUTF8; 20 Feb 2022 03:55:10 -0000
Received: (qmail 31905 invoked by uid 550); 20 Feb 2022 03:55:08 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Reply-To: musl@lists.openwall.com
Received: (qmail 31864 invoked from network); 20 Feb 2022 03:55:07 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:content-transfer-encoding:date:message-id:from:to:cc
         :subject:references:in-reply-to;
        bh=CXonHgLaudVsrN9NORBHcQFpVaqb1k1Fj7egETPVGmc=;
        b=i8ViKtob3o+ah0roXFsyDiFfxTHQWq+8Je/AZR3qEaSUj7t8QTOO0F5YNfQ3K/27oN
         5Owia7tlK4FG/Jc1kry01Ecp1VTWv+rIlynlvYbzCv4K3508xtXgGbMKUTv9TrVEYi3h
         XoOeQesKhGiic/3uWCIbKyKEMXmDI2Il4dEBDUUKcrwtJX+iv7beL8UIiMxqmgM1bHc0
         lrE9cHHtc0cKupJLR4mO19wFd6IulNgIkXp9wHOIp16VcmKoXIEO2jNzcjD9qmm2L8EL
         BvP+aMZa6Fo8yPHn5Qd/5HFlJWpqmvD2BjPDD/Ee5ks9U0JLRsk1gRpDKrBII5ZxbCoG
         Tvpw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:content-transfer-encoding:date
         :message-id:from:to:cc:subject:references:in-reply-to;
        bh=CXonHgLaudVsrN9NORBHcQFpVaqb1k1Fj7egETPVGmc=;
        b=w8EFf5vUq0FP+k8Y2bAwuT+qu286PC13zXx1AfFfJLqQSg8LAPV472t2y1En1dDi3H
         TVK4xG5wzCO/N0NzqsB2gKauQZ4YveOQOETSxjXry8s2TCCKGvHl/XKsqwlKGJRGtxp5
         hizjxwAr0xim3MxKIlpqlqcsXe672s58z1oETkKmClnQh2GB97bXmEaE8o6zXXlmA43D
         fOP00QNgKgccTFuwPJX7M17UuW7PqLez0wyRMax9APjypixazMpVYSkOqrF3Vz5CUort
         X7rY+wZ3DhGL9LrBAOUIdhDl9B98NOWCHfO4SZMKk4Vo/YxdDkVJnsz1ET2sQZPFTnYm
         C1Ow==
X-Gm-Message-State: AOAM530zK33dUclq/omm4Exziv7GEIHP7JEqGBDNig8Mw8TmOChk4Bxq
	rxtVYHBs7d1VTs0HmxPEqRI=
X-Google-Smtp-Source: ABdhPJxK3lk/vvjvyobtdqbxfKmYeUpHL8HqtcTCf530jgBAdKATWyvo+rza73X/5s+p4/6TyRti3g==
X-Received: by 2002:a17:90b:1d0e:b0:1b9:5a43:2277 with SMTP id on14-20020a17090b1d0e00b001b95a432277mr19647016pjb.52.1645329294914;
        Sat, 19 Feb 2022 19:54:54 -0800 (PST)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Sun, 20 Feb 2022 11:54:24 +0800
Message-Id: <CI0KJPL50I0K.1JNPAFAC4O20O@xps>
From: "xdavidwu" <xdavidwuph@gmail.com>
To: "Rich Felker" <dalias@libc.org>
Cc: <musl@lists.openwall.com>
References: <20220210030813.1943-1-xdavidwuph@gmail.com>
 <20220220005749.GW7074@brightrain.aerifal.cx>
In-Reply-To: <20220220005749.GW7074@brightrain.aerifal.cx>
Subject: Re: [musl] [PATCH v2] fgetws: fix checking for fgetwc errors

> As noted there (and also in Austin Group bug 1022, comment 4383), ISO
> C has been amended to require the error indicator to be set for the
> stream on encoding errors.
>
> This makes the stuff fgetws is doing to try to disambiguate the result
> of fgetwc obsolete. We no longer need to poke at errno, just check
> ferror. I think that means we can just revert
> a90d9da1d1b14d81c4f93e1a6d1a686c3312e4ba. Does that look right?
Yes, I think this is the best solution.=20