From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,
	T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 300 invoked from network); 15 Aug 2022 17:59:01 -0000
Received: from second.openwall.net (193.110.157.125)
  by inbox.vuxu.org with ESMTPUTF8; 15 Aug 2022 17:59:01 -0000
Received: (qmail 28261 invoked by uid 550); 15 Aug 2022 17:58:59 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Reply-To: musl@lists.openwall.com
Received: (qmail 28229 invoked from network); 15 Aug 2022 17:58:58 -0000
X-Virus-Scanned: SPAM Filter at disroot.org
Mime-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
	t=1660586326; bh=jCkmvJ2S/SdBeulLkKF27l7k25mKQZTFyz4B6h0p4mM=;
	h=Date:To:Cc:Subject:From:References:In-Reply-To;
	b=dpSG5N2LwKlAvREdzDWXQSesG3QjUgHqvd+ZdJgruGVfxxoM9cYj/K1QIEQ2NE379
	 gjZvPGRNF5b1aU5NWC2OPNg7UVrgfppNAHgvx57XF2rVoumXm5a7gMAJlL0GX1f2X5
	 GoeIY4XX7I6KTRJhpQPHH5EHBaKW2NAEWxT4nMZlOEgW/dDIlNLwkJ0aMPKXDEAwsk
	 NhfP7R7DIkOc/Iot3yVQ84BzMJFyt4wT1Xz/iJoot/AX2qzOzkboEa2QBME8deTPsh
	 TaVhcqORnx8I8Wx0pgSv9ZYvDeevIXSXXwDpj4jGWd+JXk04b+Mx4/9AyH3ZZpNlf4
	 +6TAZKp6+ZdVw==
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Mon, 15 Aug 2022 14:58:40 -0300
Message-Id: <CM6SQ03E3UYV.3U3YIO6BTUIKU@mussels>
To: "Rich Felker" <dalias@libc.org>
Cc: <musl@lists.openwall.com>
From: =?utf-8?q?=C3=89rico_Nogueira?= <ericonr@disroot.org>
References: <20220815175021.16659-1-ericonr@disroot.org>
 <20220815175425.GX7074@brightrain.aerifal.cx>
In-Reply-To: <20220815175425.GX7074@brightrain.aerifal.cx>
Subject: Re: [musl] [PATCH] remove extraneous syscall from fopen(3)

On Mon Aug 15, 2022 at 2:54 PM -03, Rich Felker wrote:
> On Mon, Aug 15, 2022 at 02:50:21PM -0300, =C3=89rico Nogueira wrote:
> > the __fdopen() call afterwards will set the close-on-exec flag with the
> > same syscall if "e" was specified in mode
> > ---
> >  src/stdio/fopen.c | 2 --
> >  1 file changed, 2 deletions(-)
> >=20
> > diff --git a/src/stdio/fopen.c b/src/stdio/fopen.c
> > index e1b91e12..22b72edf 100644
> > --- a/src/stdio/fopen.c
> > +++ b/src/stdio/fopen.c
> > @@ -20,8 +20,6 @@ FILE *fopen(const char *restrict filename, const char=
 *restrict mode)
> > =20
> >  	fd =3D sys_open(filename, flags, 0666);
> >  	if (fd < 0) return 0;
> > -	if (flags & O_CLOEXEC)
> > -		__syscall(SYS_fcntl, fd, F_SETFD, FD_CLOEXEC);
> > =20
> >  	f =3D __fdopen(fd, mode);
> >  	if (f) return f;
> > --=20
> > 2.37.2
>
> See commit 7765706c0584ed4a30e0b7a3ada742e490ef02b0

If the relevant part of that commit is that the flag is added
immediately after, would moving the SYS_fcntl call in __fdopen to the
top of the functon be acceptable?