From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13388 Path: news.gmane.org!.POSTED!not-for-mail From: John Starks Newsgroups: gmane.linux.lib.musl.general Subject: RE: Deadlock when calling fflush/fclose in multiple threads Date: Fri, 2 Nov 2018 15:37:18 +0000 Message-ID: References: <2018110213110009300613@kooiot.com> <20181102142915.GG5150@brightrain.aerifal.cx> <20181102153352.GH5150@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1541172932 21781 195.159.176.226 (2 Nov 2018 15:35:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 2 Nov 2018 15:35:32 +0000 (UTC) To: "musl@lists.openwall.com" Original-X-From: musl-return-13404-gllmg-musl=m.gmane.org@lists.openwall.com Fri Nov 02 16:35:28 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1gIbTr-0005YR-TZ for gllmg-musl@m.gmane.org; Fri, 02 Nov 2018 16:35:28 +0100 Original-Received: (qmail 18403 invoked by uid 550); 2 Nov 2018 15:37:36 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 18293 invoked from network); 2 Nov 2018 15:37:35 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GktwFjEKCCB10kepeQwACvTOfSveT/4ovi8j3+xLdBc=; b=TEfOPOmmQXz3Tdujx7kYPBWgSgWGQQXYfgCwG1ZttPXofo5+XNjJWDY4usbk2KX1uKy4nkHmR22NQtIdzbKeL369HaYSd/lYHppHpmr026eb/Gkq/XcjMqQS7qprueX0JGAMEmiAXOZ2Qol+Yf99SlN6bJDRrH9muPbVM8R1duk= Thread-Topic: [musl] Deadlock when calling fflush/fclose in multiple threads Thread-Index: AQHUcrh+4NUgCGe/j0Webh3Yvy6rsqU8l2TQgAAGFQCAAACDoA== In-Reply-To: <20181102153352.GH5150@brightrain.aerifal.cx> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=jostarks@ntdev.microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2018-11-02T15:37:16.7162913Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [2001:4898:80e8:7:61f9:3297:a984:1d33] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR21MB0792;6:OdWl3ub/it2dic8cRu4mI1O3/PoTHzp3+dnYIuRTjA81ScCc5l3VP+sAic4dMm79bep62YWM/j58Y7xXjbGULDZ4Cg3ipSP4FnO2AvVcv08GrNYYvWI2GlJaKSWgr4tjoLRrPhBcQVPBu00jo9JgWopCl3cbg0I/5eYcFi1QzKyZuKPPWFawWT+N9WaAGbaoawocZzuLgg8GxEWpzH6BXHPg14VyFaNR4aXmMfH71mKdYvNDYeNopm4FaNAMLV5xjpWw9XQRooklddI8EfN+kBTVsGi5koMOuYBw09pdZrsdzS+Q5HCZ7E37jAXBo6dv9XeTaD86g1Su79jqVjFOXPPmG/4/KPfzXXyEHAbImg11DBq3W06Ok8ggcQBFsnijyZHBSZXeCwo1IhKiRKFAYAyykkBJR7uq7LwEV8tB8S3cX46PS83zZCYqOkf1gQEAUobj2S8lEqOZgbR1/mSHnQ==;5:QkQPj59XLyfxS3/uCp7ocXZarHiXjRqvADFdgonOFG7aRWzwVfwF5z/Y03BY+2vKKX+nWJLZLkgrG8yru5LGo6zh2H0NJPGH31V8Sp0Fq1b4nihPeN/mJIEw4QM8c2e9AiFurRKyJY2Iq9VRbSw/njLpWpyOJcA/7qO4hNR+Wj0=;7:AJr9jzNLXt6rg/k1Y7w4aPs5KhA72MvB+vS0a9XzZSNI/P2PgQSBJJY7gFUG7vJo53NZiZW6nYxyIDXFHfijmG0+HsciQsATqG64zLoRjMiMmGcYp8DBCfQcHJRgQexdqh8 BwP97OeddmvetXLVfxg== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 1aed17cb-cd87-4374-d327-08d640d912a6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:CY4PR21MB0792; x-ms-traffictypediagnostic: CY4PR21MB0792: authentication-results: spf=none (sender IP is ) smtp.mailfrom=John.Starks@microsoft.com; x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(8220035)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231382)(944501410)(52105095)(2018427008)(3002001)(10201501046)(6055026)(148016)(149066)(150057)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201708071742011)(7699051)(76991095);SRVR:CY4PR21MB0792;BCL:0;PCL:0;RULEID:;SRVR:CY4PR21MB0792; x-forefront-prvs: 08444C7C87 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(136003)(396003)(366004)(346002)(39860400002)(376002)(189003)(199004)(97736004)(10290500003)(2906002)(8676002)(55016002)(72206003)(10090500001)(229853002)(508600001)(9686003)(6506007)(6436002)(5660300001)(81156014)(102836004)(71190400001)(71200400001)(81166006)(8936002)(14454004)(5640700003)(1730700003)(316002)(22452003)(93886005)(256004)(2501003)(476003)(25786009)(186003)(106356001)(99286004)(68736007)(486006)(86362001)(105586002)(6116002)(33656002)(86612001)(74316002)(76176011)(46003)(7736002)(446003)(11346002)(7696005)(305945005)(53936002)(6246003)(8990500004)(2900100001)(2351001)(6916009);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0792;H:CY4PR21MB0119.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Fi/r8sGcwnfr8tAGTW7z/SMdqNQyRDBWOaqjoE8RpgNjmPb8aB4uT4eKsU7ai+vP/nKFtfWg33fjjsxXkLBOVg6yT5IFSbaliOOphlBD+dMZ3P52kRYwssYqEXveuMQvu096jLAsJZubX5GqRk9rmRMoAd8dXmJUcQ5G4s4LRfS6r0Ij9pRq8nh6NeFcYrbdUimyr9FGwuXBRI//qJLrybRy6o2yzruEZ9oeMEa+Kv8tJqPrPu9O8xeIV9bTDFdKhbljEXikAHz6iyYOkqNy26QMGxHiYvy3IeIBYi5scdLCUyFu+JqGfMCFlbeLvAatMO2/UtkVSd3VK03u4FlyyQw4Xf9G5SymKDPuaS0WEH4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1aed17cb-cd87-4374-d327-08d640d912a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2018 15:37:18.2946 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0792 Xref: news.gmane.org gmane.linux.lib.musl.general:13388 Archived-At: >=20 > I think such an approach is plausible, but involves the kind of > complex and error-prone direct use of atomics I'm actively trying to > eliminate. The same could be done without low level hacks via clever > use of rwlocks or a mutex+condvar pair, but all of these involve > namespace-safety issues and a lot more code than should be introduced > into minimal static programs using stdio. >=20 > For what it's worth, the only consumers of the open file list that can > be executed more than once are fflush(NULL), fclose, and __ofl_add > (used by fopen, etc.). >=20 > Rich Yeah, I can see the desire to avoid additional complexity. It would be a sh= ame, though, for fopen or fclose of a local file to block behind flushing d= uring an fclose of a file on a network file system, for example.