mailing list of musl libc
 help / color / mirror / code / Atom feed
From: "alice" <alice@ayaya.dev>
To: "Rich Felker" <dalias@libc.org>
Cc: <musl@lists.openwall.com>
Subject: Re: [musl] [PATCH] fix MINSIGSTKSZ and SIGSTKSZ for powerpc64
Date: Thu, 29 Aug 2024 18:00:52 +0200	[thread overview]
Message-ID: <D3SIROC2U8ZX.S81EV0LHBQZL@ayaya.dev> (raw)
In-Reply-To: <20240829125727.GK10433@brightrain.aerifal.cx>

On Thu Aug 29, 2024 at 2:57 PM CEST, Rich Felker wrote:
> On Thu, Aug 29, 2024 at 05:38:42AM +0200, psykose wrote:
> > since kernel commit 2f82ec19757f58549467db568c56e7dfff8af283
> > (https://github.com/torvalds/linux/commit/2f82ec19757f58549467db568c56e7dfff8af283)
> > the kernel has updated these minimum values. having these small values breaks
> > sysconf(_SC_MINSIGSTKSZ) too; it returns 4224 in musl currently which ends up
> > returning ENOMEM from the syscall made in sigaltstack.
> > 
> > raising these to match the kernel fixes sigaltstack use on powerpc64(le).
> > caught by glib's 2.82 testsuite
>
> I don't follow how you're claiming sysconf(_SC_MINSIGSTKSZ) is broken.
> It will just return the kernel-provided value on new kernels that
> insist on having a larger stack. In particular I don't see where the
> value 4224 is supposed to be coming from. If there's something I'm
> missing, please explain.

sysconf(_SC_MINSIGSTKSZ) returns 4224 on ppc64le (this is as far as i know
expected).

setting stack.ss_size = 4224 (from that call) and passing it to sigaltstack
returns ENOMEM because it is smaller than 8192 which the kernel enforces.

..so the normal way of using sigaltstack with the smallest size (with sysconf or
the macros) is broken.
making the MINSIGSTKSZ match the actual value the kernel enforces fixes it.

  reply	other threads:[~2024-08-29 16:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-29  3:38 psykose
2024-08-29 12:57 ` Rich Felker
2024-08-29 16:00   ` alice [this message]
2024-08-29 19:03     ` Rich Felker
2024-08-29 19:11       ` alice
2024-08-29 20:23         ` Rich Felker
2024-08-31 16:33           ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D3SIROC2U8ZX.S81EV0LHBQZL@ayaya.dev \
    --to=alice@ayaya.dev \
    --cc=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).