From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id DED6724950 for ; Mon, 22 Jan 2024 00:54:41 +0100 (CET) Received: (qmail 28312 invoked by uid 550); 21 Jan 2024 23:52:38 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 28277 invoked from network); 21 Jan 2024 23:52:37 -0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JluHYpfaRuILCmbtWxSTJ/0izaZqO2aQq4VNIaKhkB6QSJJm3nObzLVUkbGvPHyBS9cWDeE8dKX9WSsjoCDieqF0Zk2oMmledrxpmVfIf4pUUs8xtnkG/cS4LcGdCB9u+S9iAFwTAx5q4PnD43Xcv1uMuqa6um3b+k2jKNC4J9asg7YIDSfK7sa+KhemUklm7YzTdNyqPJeNOzpnRyXxCJ3B8o9Q+d/R9qYmQMndpCNeIZZ+NP4B6vONXpKzRsqUUl7+25C8AhUJQLAM9PP4bLUFYqJFmEnqhDuG8pFj52LgSY1k4cTtbmnkjJc3QuHaWtQWcUUNeyb8P/+RBaFqEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2rRIxR+7NsD6mL3Z6bAhOrlWfCNFDmDZY1tQ2P8Psw0=; b=KM/1ITsHBll9tHoaX7i3WNkc74bdJSmb6htJT/kC95R3jNBV7t18q8qdgz6Kq8GLd2Dnw+v2O0Cr64Sb7RBdn8BRKEKMTaeH2oJvb3jZN2QX7+Gdp2nfqnpmb46HVAxQLnGvB/ScbN4NVwqO2KcKCeTNIwDurt3a+lOn77Yhc+jNoby9VKI4yPnWz5Zd9HV/gWDAiqNXcssc9+P7UfiH4D2dur1/tRduvbYqBHhwl0U9b1xANt5W3DhTguuPTRHkkpLFQ5RTI4NKNwErYBU71nW6DqxtbHr2+HPKcVd+CuceNB+meUf5VbB8IzNCQB8nPLL9PB7VNZ6tbMuvudDtKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none X-Gm-Message-State: AOJu0YzaFcY5BqLwu+7Am6LJdQosera9ugX8SMnbUqUwMrqm1H8J4V0/ EfwRC6U0DaSnjLX+domP/jkv45yjNokbSgs4OkSgaNr2nnbo1wFoOyRrLE0mql6JqAH5ksQ3sgE 4aJqNVQKUN70Crpd0LBsRdXAOSH0= X-Google-Smtp-Source: AGHT+IG6DJFY1afD6OEDof/vvZDgg0IWaTtKHmvvdz0ONIZvszCn0FmE1JHsV+L5NY1W+yd9mtGIt93ldQXvyL/qu7M= X-Received: by 2002:a0d:e251:0:b0:5ff:9772:3a82 with SMTP id l78-20020a0de251000000b005ff97723a82mr2537342ywe.80.1705880945864; Sun, 21 Jan 2024 15:49:05 -0800 (PST) References: <20230822173821.GW4163@brightrain.aerifal.cx> <20240121222831.GC4163@brightrain.aerifal.cx> In-Reply-To: <20240121222831.GC4163@brightrain.aerifal.cx> From: Fangrui Song Date: Sun, 21 Jan 2024 15:48:55 -0800 X-Gmail-Original-Message-ID: Message-ID: To: musl@lists.openwall.com, Tatsuyuki Ishi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-TMN: [FANnpcVLkGhUa0G4t0ngRypS/pKJP/J3] X-ClientProxiedBy: BLAPR03CA0140.namprd03.prod.outlook.com (2603:10b6:208:32e::25) To DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5765:EE_|IA0PR12MB8932:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a8a7945-ff63-42df-6cf9-08dc1adc4bcc X-MS-Exchange-SLBlob-MailProps: znQPCv1HvwXEkPgdKd+m+HAHVbj1gSwrkMIlsGWYFY7gYzD2YmKVuaeOSSF5d4fAsu1GROt7vkr5NsMGkFFk0PayqFOXj9cuRUOEh/asoGZqSAXDHQ6QwdPGrPALrATSNAtEo3PQu9a8v7v9gulTucvS9+3Gpbvdhun9rwV0LBcN6D/MEGXRCwqKj4x0VvUU+3y7BbfjM/ECuS5+OH5zTQS2FCFkyTfBHDjPoyGmirZ2dZnz/QMKnR656Oam3tRks+4MlWd/5YAUSCm28bGfdIR8YPBGHxQ1IO9b5Vrpj8coZpCFrK9Oj5UDY6zdzHj6SnjWiSlpC3Hvo4tgdItGpt21Jn5HhdKix+ea6x8QV+660hUVOGfwNP7iWjK8CX4jU6lPPSEvlnfnH1lbv9rixM3K4H8dLG4UKNt0SZSTQ/tc3ZIhfm5xfgcD3kCycggFFC3/HQ5pHvGGRy2L8bZrRUUr067G9yXxEj1qeAAZD5m62IJ3ZbJg4vGith4th5OBOZRoYh+CASwlcJejtwJS9rwZHKilQXYqRcuLLkjtZ2KHyrS2APBtf+yaHjFdXwKz4BBXUqdRlHAXcDYffOxFWy86JfQiztksue68BwgMZ3jNhe/ddHHQMdeg60UkKWlEyCRyTY+ynFhiWdrFwFKHU8954jW+/vbk0M2NKMDtTDAg6F9rWp/2yDxnWOyCOEsYDk2BDbQ6DbJ9gJqEjf3559KFiHMLy7IXuDTLJehSHcEYZzUAyKeno/LTnCEOI6eHzhoPuTWWHNc= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PlFIVWAsOgOlJrtbyrQA0cEcmRa849UN0hLXXIK6n/x7fc4hIn5rDgDYe43jzJu2SlKxYWvJkqvL/m3KfQUS4LNsa3elKMN0IyKdbBUYNhkKGWtHSaAGDNhFh+MUv2EswfJCogY3IWp966wwliVEZWxleC/U8qsSJCLbew4ekErl06MLm2bEzar4LvHBnpVjJSwtvoWuaM4xWJHWSx7/2vGo6EzoDv+jgkcQlHBPAtY7xj92yzfTANnamYvVphPHjf4qKoeKgKeEBEMx8TyPXVjw2SQN56dlOn4CYPv2D2N9zSnGlw7ays5BXDIZgHNcEJyuiG/Z+DWVPfoU+dN0MFdAsvpyh4nv6dMGwGCDPODU94lJaZUf9K2lSxhq/YP7yK3IEYQi0FADAIPq+JnejoeBUYYZfE6Qv8xAxSwYXaMAlcKyeo9SJrYO66ezxTna6WzSIGH107hcPue41DDZb+qcIy2qyndyyCka7+5uvaJ/ApnjfcdXs5mNocrIUC2aV/gBQLu5B73dGvL+ELnzzgjENnLVqNyr6Al2pNsHmNCu3TWSrKA+rjlGweD8Xg0AQmPWDVTdRYdQ4bF6Wbzi37xCGeJhWl2+8dQb+GJuxAPDuivSDqnG2GJF+RNofQiOielzPb6IqEO2deSY3lDmRw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDY4YVM2eEFYL2R6aGU5dkFheHlrYTFnaXlNancxaGhqYno0N2FMS0hFZzk2?= =?utf-8?B?TFNGYlo2OUp5T1R2N1hPZlVXWlZYTlUwNHV0a1EyanV0U3JWa2VIaURNM1hH?= =?utf-8?B?QmxFQ2pNbWM5Ti92L1VGL2pSdmdNU3NGYUVvSlNSV1QxR2JMWGVWMVVJa3RT?= =?utf-8?B?UU9YM2VLVzN4UGJtSS9SblByeGZHOHQ1dUwxdXFxZkN1WUFyOHRyY0RxN2Zs?= =?utf-8?B?eWVjakJhUFJlVXBGK3VWS2EzYUtGOEQzekROQy90TVhVU0g4ZVo5Syt2bUN6?= =?utf-8?B?YWFoUVlqYXBkbG0yS3gybHc3TnlGaDRhTURwVVJBWHhTSmFiQzVubzIvVWtx?= =?utf-8?B?cG1kV1ZnV2FROFRWcmcyNXI0N0lRaTlJM0psVEEzYjZIWEFNMUZVVCtmVUYr?= =?utf-8?B?U0ljV0Vvc1ZpS2hVRVhISXoxdUhiMGRQNEJhQXNwenlyNXZVdXJTVklYRWpT?= =?utf-8?B?azh3U05rb3Y2MGwrUlBZOUN2bkFIRkFpWStmRmZDMG5Lb29ZMlBDcklkWkZm?= =?utf-8?B?aStJS091dWtNcFc3bVlsT092TXdaNXYzUDd4MGJhVnpka3RDa1dEZTE1V01I?= =?utf-8?B?UE9tYjV6QXBUSDVOYXJKZFU1VDFGcU9oNW9GeWYvVUU2ZURCSThCTlVLT3Bx?= =?utf-8?B?K2dJNU5VNUIzbXRkRlNKdXlTUEVuTzNnc3FqY0RrTHZ6QWt2U0xIYmdpbWh4?= =?utf-8?B?b1RabWEwNjg4eEtiZ0lISGc1NGxZbWdLWU52RExYR2JHZEk5Q0QxU0hXWUFa?= =?utf-8?B?ZUptSW04L2R2WVpyMWdFL2hEc1ZwS0xaempnd2RiT1hMWjhyb1g0MGFQTSt3?= =?utf-8?B?bGwwN1d2VzB5V1B1S2hnUDdUcmVuWGZ0VVRYaEJjc3NBRFloRnF2aVNqUXBh?= =?utf-8?B?OHR6TXoyR2MzWE56MHZtdEh0NlVmdEVFcUJSOFJMdzFYOFRVb0dxSTRMSHFo?= =?utf-8?B?U093ZXp1TE96VlNKNGdPVEVIVEVIUGU1V3QwTHliN2g5RmtFR29lNjhNSFd0?= =?utf-8?B?ZGgrSlA1ZHFCR2pOVlhybGxpV29UeHE1MHhZVEFDZkE2VXhzd2FBYXZ5QnRU?= =?utf-8?B?UnZUQ05xQzViS3BXdjJjOWo2c0lsWHZnR0ZIOVU0eTBKTWFDbGFrWHBpTTVk?= =?utf-8?B?MmdVcjBnSUN6dlk0bDdoTVRoRk81T3RhdDBxOVpOWXJ5OWwvZk1HclFGU1Ju?= =?utf-8?B?c24wM1lqNVAzMVVLdmxRbkdFWkw1YnVoVUZvV3pvZDJwN21USVlBdUpuTlkr?= =?utf-8?B?SHZtSHRDQ0tHWWZSSVZXUTE5ZkxuTGt3ZFE2cStiYy9PMU5qZnJIOHlHUTFI?= =?utf-8?B?endVTGxrWHRSb1FIYXVCZFBKZkM4NjE4NDVYZCthL29NRlpWNm1XdmdGWjhK?= =?utf-8?B?bUJ0UzJpMDdEWWFwQWV1WFhiZGRNU3k0SXU2a0I2WkVUc0ttcW90OGJQZmdk?= =?utf-8?B?WkFSWEg2cEFzaXc4aDdpa0FDcVZTWlpyNnJJUzRia05GY1N5TzJ0RVMvaDNq?= =?utf-8?B?U3lEQi8rb2kybU44NUlHL216Y1BqaldUQjgrbFNrTG0rRno1c2hrUko5bVJR?= =?utf-8?Q?YepdtXNfJ2f8WvYI4Bqw+GBjXon5z54hVNiQldPpIlPtV+?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-71ea3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 3a8a7945-ff63-42df-6cf9-08dc1adc4bcc X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5765.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2024 23:54:25.1531 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8932 Subject: Re: [musl] Draft riscv64 TLSDESC implementation On Sun, Jan 21, 2024 at 2:28=E2=80=AFPM Rich Felker wrote= : > > On Tue, Aug 22, 2023 at 01:38:21PM -0400, Rich Felker wrote: > > The psABI work is not finalized, but based on the current status of > > https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/373, I think > > the attached is a valid (but untested) implementation of TLSDESC for > > riscv64. Actually activating it requires also adding the relocation > > type macro to riscv64/reloc.h. > > > > If any rv folks could look it over and make sure I haven't made any > > stupid asm errors or missed any obvious optimizations, that would help > > to quickly get this merged when the psABI is finalized. > > > > Rich > > > .text > > .global __tlsdesc_static > > .hidden __tlsdesc_static > > .type __tlsdesc_static,%function > > __tlsdesc_static: > > ld a0,8(a0) > > jr t0 > > > > .global __tlsdesc_dynamic > > .hidden __tlsdesc_dynamic > > .type __tlsdesc_dynamic,%function > > __tlsdesc_dynamic: > > add sp,sp,-8 > > sd t1,(sp) > > sd t2,8(sp) > > > > ld t2,-8(tp) # t2=3Ddtv > > > > ld a0,8(a0) # a0=3D&{modidx,off} > > ld t1,8(a0) # t1=3Doff > > ld a0,(a0) # a0=3Dmodidx > > sll a0,a0,3 # a0=3D8*modidx > > > > add a0,a0,t2 # a0=3Ddtv+8*modidx > > ld a0,(a0) # a0=3Ddtv[modidx] > > add a0,a0,t1 # a0=3Ddtv[modidx]+off > > sub a0,a0,tp # a0=3Ddtv[modidx]+off-tp > > > > ld t1,(sp) > > ld t2,8(sp) > > add sp,sp,8 > > jr t0 > > Any feedback on this? Offhand, it looks like adjusting sp by 8 is > wrong and that should be 16. Anything else? Does anyone have recent > enough tooling to test this? Tatsuyuki, do you have links to the latest version of gcc/binutils/glibc patches? Downloading patches from these mailing lists is probably a large hurdle for many users, so having the relevant repositories online may help. mold has implemented RISC-V TLSDESC. On the LLVM side, I have reviewed https://github.com/llvm/llvm-project/pull/66915 and am waiting for it to land, before I can check the lld status.