From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 29603 invoked from network); 21 Feb 2023 19:09:44 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 21 Feb 2023 19:09:44 -0000 Received: (qmail 28086 invoked by uid 550); 21 Feb 2023 19:09:41 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 28050 invoked from network); 21 Feb 2023 19:09:40 -0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cJCQeEa+s8sp/xXoqFXNEkLCcaxLh/v3wHvTnrQMKqHZjJGjtMVIQLJt56KYsn6Kae3KI+awmyMC3hA9pnXTBSn9h+KbgVrHp0JLATp7jSPB/T19zGCYMaXMBz2P9QAAD5WdFmJS1CpdttGTVtsjr/wgniNLwzkBLfRNWE15zCStZI8LOReWYOV6RHUtb1bwJzXk8p3paunz8ET21MYRaovQvVyj7Gs6b2b1ZMADuiNtd/1kt4+K6g23afsZJ1GPkE+j1EVPityufp1wwXPoO+v0+RahRm/JdFn7skY3n+KfLUdLX071h0i3JcLiZ2YXsRo8VdZ+wrf2BfoKmQtFIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8n2ZwY0aqP3wft38ljWKQ+IRlrcMtyTggb7iel6iiPY=; b=lGzcqLrhG+HUmbtW8Ue+wOxkcOQ5xgkRk+sOEZdbqUU5aScloOMNbeEpXy7a/g5NxIxl6Vy7fnA4VUmn9BmFdJfsPfCaW8KncB3A1rWJdzSFztwdwenGL0OMIQwv4/qmu9fFrhqnuYfQhuCzw10D4iDaibnNPVPAfW33NJtTy90yGpJALKciGyvsPzz6SZHddmgsmUPppPrd44ddvb8RLqx2djKJySk85znY6gfTxa/wIdNn4had/VkWajpB76t8ICroEd71szWo6TrB/xYuHpv2w0QyofNmgH4xlpsV5R6Ar2Hs/RLIOowq30tcZNnQQtcL5t4yNYhCRkIyKqddKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none X-Gm-Message-State: AO0yUKUh9CQc3I4x3nM22KgiimaYpDLv9EZ5VoWjEYo8sI3bSJm7F3vK w329b8EKNl0Z9rpiCX4hM7f1yCeZWZOyEEiQJw0= X-Google-Smtp-Source: AK7set+xW5W7DYVAWxSAqd9RgFw5FI5kKXmWy1y5l9/4fTONb4/uzu87ggxQ0wT3bkhKT96Cnhw2WsuUeHBlCCXcCUs= X-Received: by 2002:a17:90b:1b06:b0:22b:ef05:ea5b with SMTP id nu6-20020a17090b1b0600b0022bef05ea5bmr336534pjb.50.1677006565163; Tue, 21 Feb 2023 11:09:25 -0800 (PST) References: <20230218013333.844224-1-i@maskray.me> <20230218020320.GA4163@brightrain.aerifal.cx> In-Reply-To: From: Fangrui Song Date: Tue, 21 Feb 2023 11:09:14 -0800 X-Gmail-Original-Message-ID: Message-ID: To: musl@lists.openwall.com Content-Type: text/plain; charset="UTF-8" X-TMN: [OY2BCqwvpJIeFYYSHTA8jp+VzSAgN/XT] X-ClientProxiedBy: MW4PR03CA0293.namprd03.prod.outlook.com (2603:10b6:303:b5::28) To DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5765:EE_|IA1PR12MB8407:EE_ X-MS-Office365-Filtering-Correlation-Id: 45e7e401-63ac-4b89-7379-08db143f26e5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6Z+nBeBQHuDSBgkQy+u0sVQOSRHeb+Ngpw5gR8iAwJ7pAPF8slsAZeVw9A35GDVYNHijSFeXbLmYtsaTEWas76AsBurFWOfyCxhskEPFC9K2OwWve4kdVua5lr1sjb1HroNSH34l2Ldlr5vZW2WNbOUnS8wN/mkHxZw5trbMnumSJTr8bXDRWEna2OFJjAKX1+s0zGJGC+7+pFVD1fCwaAuw+3Tz7tcG7HQ74nSadF1DlF+F91RY8e0K/UKzX9ENageubXBJawhd3QgfCNmnnZrFEDYkLg7HmzfL0dgG5aAZ1qQDA4oR9DOMuom0/V4hZKBcRZibJPHSPnaL2FkiPV0NL1aMMdy0Up4pjJl+DGMxJTkraKkSsoDRdb33YLUidN1Tom1j/9Gt2V8BmhofyVXFjH4YmyWZmJeZLCxFJ0IwUWK8WpN1u9uPLTnljF1ZGdrjSBNBrtlfULYdp4fPa2GYl/tKLEgTWcTZQdAaDfRk6bHDXNPitsWi2q7ZXb9ZZDFkRXTpWvt7Guu9OFm7DEgmBGKQh/N7FZQF2v7xnnnvUdrr3+E+RVYYxpo+9dT+PDwyNpCybdjunsASaie7HZqPWQTKCGfiUDanomnapfs= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFZhTE0ySFlSc3lZSWNoQWVCa0NKblNZbFBhc3J1cEMxSjBlcTMrQndKeklp?= =?utf-8?B?YXpJZ1hLd0F4K2Y2VjRmcGNSVmZ3Z3NETmpOSTRBUVFGNjBOcnpUZWRCUHhF?= =?utf-8?B?RlZnQVR2eTU1NWFHUzNURlAvZEJUK3c5NDhoY0QzUXZpblFDb1A5RkZoRzBU?= =?utf-8?B?VVc5YmhpUjZ6blBrYWRyd2htazFCNFMxVU56UzY1T2JlWldabzVMVEZvVWJx?= =?utf-8?B?amg0MldGbVMwd3dQMEt1Nk0wbHMvY0FUS1FlZzR4M0ZLcE5hOXBRMGQxU1oy?= =?utf-8?B?TDV3bldVTzNmYTRKTVQ0ekZ2b2xwNngvTTRWL0hma29CRDd6anlvRUhTZndt?= =?utf-8?B?Y1lUS3ZhOXQ1NC9PVFZrRzl5MDRuclpzWEFselRuRlJ3Ly9COE5RbUVQWnha?= =?utf-8?B?a09YSXI0ejQvRmJxVXRZeGczTFh5WDVwZHRBcDE5cWxDVjk2QVFmUlB4V1dh?= =?utf-8?B?Tjk4Zy9mb2p0NTFMUUp2NUhJN2xnbHdGRy9JOXZrbEVjRmYwOFlKeWdMb0Fa?= =?utf-8?B?OHErYkFRdEVRclVwaDM0ZU9DQ3ZpRjJUemdjVlpjVTQ2RkVsbFlTUm5qVlBm?= =?utf-8?B?d3I4TWJwQ0JoQ1lRUmd6YzlVUTBzZTlzbXplREFOOTh4NkpIWlhpcmxPUUlh?= =?utf-8?B?eHFYSG9nanVPYjhaQU1Lc1Z6ODVKQ3p0R1Y1YXlpenZEYmdmdFRUSUsrVW9o?= =?utf-8?B?L3hxeVUrSlpnVit4OVpEZkNRcG43U1RrYkxuZ0YxTDdUck9qSHNrY1pDWGVr?= =?utf-8?B?WmlJTzdTVFEwNDJRRHY3ZjkyazAzd2JnV3d2UGljRksza0tKM1dySDNrSk92?= =?utf-8?B?Q2wwRlhzSzVOekdzb0MxU2NFOG42YXR0WWRxdTJwZDF0WlhXK01tQTRRTVhu?= =?utf-8?B?S2ZscHg5Nmk5WmdJODdLMGd4bDBHdzdDQWVhazBGRjBuNHBRTm9KcG9heHFM?= =?utf-8?B?VG1ZQzUxei8zdXF1UTNjaW9ZOE1KWlprMnRtQUQxcEFuMEJIUWZndk5wTW90?= =?utf-8?B?UkNsbGpvVC95a01IamFuaXFWK01DZTVyd1MwUDluVTFyWFVNU1JMZEsvb2VK?= =?utf-8?B?UmcrM2xGay9hQnArSzM2VnNKVm5uQ2JQOVdyVXZCanFLRGU2d29qcG5ZeDVa?= =?utf-8?B?b3BadmpvV0xPcHNXWW9pcmhqWFkzVDczeThCcVpZV3dsZnpNSmxLelVONDFv?= =?utf-8?B?RzhSNEM4NnFiR3ppblRkQyszUkZVd1lGRVhTZ1hnNlh2dFd4R3llSUNhM1Bp?= =?utf-8?B?NU5GNGRrM0RIWnVGNWtXOUx0V0d3Mlc1WWltTVlXWW91RnAzR0NRQjd5ZTA3?= =?utf-8?B?ZFA5VFVKR2RZblc0NWJ1d0czb2lHUE40aXBmK3RyMWJKbm15cENoenlpVmR2?= =?utf-8?B?N2Z2eDhrWWZ5K0FmTWlTNmJkUW91ZEt2ZFQ1V3llT2tBbnBsanB4eTNqSE0z?= =?utf-8?B?RXpJUXhGN2xEQ0RKM2dTR2Y4Sm82eHhSRmcyMFVSOEVodE4xUk8rS2M2STVj?= =?utf-8?B?N1RQSHlGU0F1c3RlN25FdVZZSHl0WEhCZDRHdWE1K0FnTldQTHNxUTVCbzdj?= =?utf-8?B?NEx6bWZsQjV4WHZmTlJXUElteUFqb3ZsSmlXTDBVcGxNZUFIN2JSSlNCTTFR?= =?utf-8?B?ZzdaSXNYUkRtUnlUN1RjZ1BTL0xBOHgrdjZCc2J5SmhrbGo4OCs1NFBZOUpp?= =?utf-8?Q?GoTHQSk3TZfDsRv2Fb8i?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-71ea3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 45e7e401-63ac-4b89-7379-08db143f26e5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5765.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 19:09:27.5029 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8407 Subject: Re: [musl] [PATCH] Use __builtin_FILE/__builtin_LINE if available On Sat, Feb 18, 2023 at 4:17 AM Jon Chesterfield wrote: > > On Sat, 18 Feb 2023, 02:54 Fangrui Song, wrote: > > On Fri, Feb 17, 2023 at 6:03 PM Rich Felker wrote: > > > > On Fri, Feb 17, 2023 at 05:33:33PM -0800, Fangrui Song wrote: > > > C++ inline functions are requred to have exact same sequence of tokens > > > in every translation unit, but __FILE__ and __LINE__ may expand to > > > different tokens. The ODR violatioin is usually benign, but it can lead > > > to errors when C++20 modules are used. > > > > It is sad that C++ modules broke 'assert' but not surprising. Modules were largely created out of aversion to macros. This isn't something libc can fix though, I suggest a defect report against C++ instead. > > Changing the semantics of assert in C seems like a bad thing to do. > > Thanks I disagree. This is a footgun where the right fix (or workaround, if you prefer) is on the libc side. It is fairly reasonable for a header to use assert and not expect two includes using different paths to not cause C++ module problems. The current module behavior regarding macros is a reasonable compromise. It can be evolved (e.g. https://gracicot.github.io/modules/2018/05/14/modules-macro.html).