From: Julien Ramseier <j.ramseier@gmail.com>
To: musl@lists.openwall.com
Subject: [musl] [PATCH] vfscanf: fix use of uninitialized variable
Date: Wed, 1 Jul 2020 15:12:14 +0200 [thread overview]
Message-ID: <E8B0FA07-16BD-490D-B48A-AC062A8F4A52@gmail.com> (raw)
vfscanf() may use the variable 'alloc' uninitialized when taking the branch
introduced by recent commit b287cd745c2243f8e5114331763a5a9813b5f6ee.
Spotted by clang:
../lib/libc/src/stdio/vfscanf.c:80:6: warning: variable 'alloc' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (!f->rpos) goto input_fail;
^~~~~~~~
../lib/libc/src/stdio/vfscanf.c:330:7: note: uninitialized use occurs here
if (alloc) {
^~~~~
---
src/stdio/vfscanf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/stdio/vfscanf.c b/src/stdio/vfscanf.c
index b5ebc16e..b78a374d 100644
--- a/src/stdio/vfscanf.c
+++ b/src/stdio/vfscanf.c
@@ -57,7 +57,7 @@ int vfscanf(FILE *restrict f, const char *restrict fmt, va_list ap)
{
int width;
int size;
- int alloc;
+ int alloc = 0;
int base;
const unsigned char *p;
int c, t;
--
2.23.0
next reply other threads:[~2020-07-01 13:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 13:12 Julien Ramseier [this message]
2020-07-06 22:00 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E8B0FA07-16BD-490D-B48A-AC062A8F4A52@gmail.com \
--to=j.ramseier@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).