From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/33 Path: news.gmane.org!not-for-mail From: Igmar Palsenberg Newsgroups: gmane.linux.lib.musl.general Subject: Musl git 0d......455eee8 and recent compilers Date: Mon, 6 Jun 2011 10:48:08 +0200 Message-ID: Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1307350116 23268 80.91.229.12 (6 Jun 2011 08:48:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 6 Jun 2011 08:48:36 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-116-gllmg-musl=m.gmane.org@lists.openwall.com Mon Jun 06 10:48:32 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1QTVU7-00073z-T3 for gllmg-musl@lo.gmane.org; Mon, 06 Jun 2011 10:48:32 +0200 Original-Received: (qmail 5721 invoked by uid 550); 6 Jun 2011 08:48:31 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 5711 invoked from network); 6 Jun 2011 08:48:30 -0000 X-Mailer: Apple Mail (2.1084) Xref: news.gmane.org gmane.linux.lib.musl.general:33 Archived-At: Hi, I was using Musle as a test for investigating a (completely unrelated) = clang-analyser problem, and I've stumbled upon a couple of issues 1) The struct dirent in include/dirent.h uses a 1 byte array for d_name. = In reality, it's larger : We allocate more space than the struct. Since = muscle requires a C99 compiler anyway, what's keeping use from using = d_name[0] or d_name[] ? If a C89 compiler includes dirent.h, we're = screwed anyway :). That will probably silence GCC 4.5 and clang, and = severely reduce the warnings it gives in similar cases. 2) The NULL pointer dereference in src/time/__asctime.c won't work with = clang : It removes it. I suggest using either __builtin_trap() or an = abort(). If you get to that point, you're in trouble anyway. 3) Clang does't seem to grasp the weak_alias thingy. It need to check if = those parts actually are correct 4) Is there a muscl testsuite somewhere ? regards, Igmar