From: Fangrui Song <i@maskray.me>
To: musl@lists.openwall.com
Subject: Re: [musl] out-of-bounds reads in strstr
Date: Thu, 24 Dec 2020 14:26:30 -0800 [thread overview]
Message-ID: <MWHPR1201MB011024197028282E6FB6E804CBDD0@MWHPR1201MB0110.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201209163728.GL534@brightrain.aerifal.cx>
On Wed, Dec 9, 2020 at 8:37 AM Rich Felker <dalias@libc.org> wrote:
>
> On Wed, Dec 09, 2020 at 09:54:51AM +0300, Alexander Monakov wrote:
> > On Tue, 8 Dec 2020, Rich Felker wrote:
> >
> > > > That being said. I'm still confused by the comment in strstr. `l | 63`
> > > > is closer to `MAX(l,63)` than `MIN(l,63)`.
> > >
> > > Yes, the comment is wrong. The point is just to scan at least l bytes
> > > forward for the end of the haystack (since we'll need that many
> > > immediately) and at least some decent minimum to avoid doing it over
> > > and over if the needle is short. But there's no need for it to be
> > > precise.
> >
> > It's not the first time this comes up. I suspect you'd save more time
> > correcting the misleading comment instead of responding to each inquiry
> > individually.
>
> Thanks for poking me again about this. Will do.
>
> Rich
wcsstr.c has a similar typo.
prev parent reply other threads:[~2020-12-24 22:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 19:39 Brooks Davis
2020-12-08 19:53 ` Rich Felker
2020-12-08 22:44 ` Brooks Davis
2020-12-08 22:57 ` Rich Felker
2020-12-09 6:54 ` Alexander Monakov
2020-12-09 16:37 ` Rich Felker
2020-12-24 22:26 ` Fangrui Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR1201MB011024197028282E6FB6E804CBDD0@MWHPR1201MB0110.namprd12.prod.outlook.com \
--to=i@maskray.me \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).