From: Fangrui Song <i@maskray.me>
To: musl@lists.openwall.com, Rich Felker <dalias@libc.org>,
"joao@overdrivepizza.com" <joao@overdrivepizza.com>
Subject: Re: [musl] -frounding-math breaking src/math/acosf.c
Date: Fri, 18 Dec 2020 09:13:10 -0800 [thread overview]
Message-ID: <MWHPR1201MB0110FBBA1B89F0C2320E2B0CCBC30@MWHPR1201MB0110.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201012093947.GP2947641@port70.net>
On Mon, Oct 12, 2020 at 2:40 AM Szabolcs Nagy <nsz@port70.net> wrote:
>
> * Rich Felker <dalias@libc.org> [2020-10-09 19:10:00 -0400]:
>
> > On Sat, Oct 10, 2020 at 12:16:13AM +0200, joao@overdrivepizza.com wrote:
> > > Hi,
> > >
> > > I just noticed that the upstream LLVM is no longer capable of
> > > compiling musl 1.2.0 (and possibly more recent versions too) when
> > > -frounding-math is in use. I bisected the LLVM commit to
> > > https://reviews.llvm.org/D87822, and pointed the problem there.
> > >
> > > Just reporting in case someone else also has issues with this.
> > >
> > > Best,
> > > Joao.
> >
> > Thanks. This probably needs to be reported as aa bug against LLVM (or
> > clang?) rather than just a comment on the review so that it's tracked
> > as such. It seems they've erroneously made it treat static
> > initializers as non-constant-expressions rather than evaluating them
> > statically in the default rounding mode per the spec.
>
> const expressions should work as described in
>
> http://port70.net/~nsz/c/c11/n1570.html#F.8.4
clang main has fixed (https://reviews.llvm.org/D89360) the regression
of https://reviews.llvm.org/D87822
> but it seems clang handles literals that don't
> need conversion:
>
> float x = 0.1f; // works
> float y = 0.1; // fails
>
> we may want to fix this anyway in musl to always
> use the right type of literal (then it's clear
> that there is no double rounding).
prev parent reply other threads:[~2020-12-18 17:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 22:16 joao
2020-10-09 23:10 ` Rich Felker
2020-10-09 23:15 ` joao
2020-10-12 9:39 ` Szabolcs Nagy
2020-12-18 17:13 ` Fangrui Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR1201MB0110FBBA1B89F0C2320E2B0CCBC30@MWHPR1201MB0110.namprd12.prod.outlook.com \
--to=i@maskray.me \
--cc=dalias@libc.org \
--cc=joao@overdrivepizza.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).