mailing list of musl libc
 help / color / mirror / code / Atom feed
* [PATCH] delete a redundant if
@ 2019-03-13 10:12 Ray
  2019-04-02 14:38 ` Rich Felker
  0 siblings, 1 reply; 2+ messages in thread
From: Ray @ 2019-03-13 10:12 UTC (permalink / raw)
  To: musl

[-- Attachment #1: Type: text/plain, Size: 2 bytes --]



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: musl.patch --]
[-- Type: text/x-patch; name="musl.patch", Size: 466 bytes --]

---
 ldso/dynlink.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ldso/dynlink.c b/ldso/dynlink.c
index 46c5b5ff..206427fe 100644
--- a/ldso/dynlink.c
+++ b/ldso/dynlink.c
@@ -1461,7 +1461,6 @@ static void do_init_fini(struct dso **queue)
 			pthread_cond_wait(&ctor_cond, &init_fini_lock);
 		if (p->ctor_visitor || p->constructed)
 			continue;
-		if (p->constructed) continue;
 		p->ctor_visitor = self;
 		
 		decode_vec(p->dynv, dyn, DYN_CNT);
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] delete a redundant if
  2019-03-13 10:12 [PATCH] delete a redundant if Ray
@ 2019-04-02 14:38 ` Rich Felker
  0 siblings, 0 replies; 2+ messages in thread
From: Rich Felker @ 2019-04-02 14:38 UTC (permalink / raw)
  To: musl

On Wed, Mar 13, 2019 at 10:12:17AM +0000, Ray wrote:
> 

> ---
>  ldso/dynlink.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/ldso/dynlink.c b/ldso/dynlink.c
> index 46c5b5ff..206427fe 100644
> --- a/ldso/dynlink.c
> +++ b/ldso/dynlink.c
> @@ -1461,7 +1461,6 @@ static void do_init_fini(struct dso **queue)
>  			pthread_cond_wait(&ctor_cond, &init_fini_lock);
>  		if (p->ctor_visitor || p->constructed)
>  			continue;
> -		if (p->constructed) continue;
>  		p->ctor_visitor = self;
>  		
>  		decode_vec(p->dynv, dyn, DYN_CNT);
> -- 
> 2.20.1
> 

Sorry I overlooked this when you posted it. Applying. Thanks!

Rich


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-04-02 14:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-13 10:12 [PATCH] delete a redundant if Ray
2019-04-02 14:38 ` Rich Felker

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).