Re: [musl] possible bug in syslog

[Thorsten Glaser <tg@mirbsd.de>]

Rich Felker dixit:

>That seems okay. However I also kinda wonder if LOG_MAKEPRI shouldn't
>just be removed.

Best not to: I’ve seen code defining it as (((fac) << 3) | (pri))
if not defined while grepping, and:

gnu/usr.bin/perl/ext/Sys/Syslog/Syslog.xs:      croak("Your vendor has not defined the Sys::Syslog macro LOG_MAKEPRI");

>This would highlight anything that was previously
>broken, and there seems to be utterly no reason to use it when the
>standard already specifies that you just or (I missed that before).

It seems that LOG_MAKEPRI and the shift may be needed on OS/2…

>(which TBF is kinda buried; the text in XBD for syslog.h says the
>facilities are for openlog not for openlog and syslog).

Maybe ask on the Open Group mantis for an editorial correction there?

bye,
//mirabilos
-- 
<igli> exceptions: a truly awful implementation of quite a nice idea.
<igli> just about the worst way you could do something like that, afaic.
<igli> it's like anti-design.  <mirabilos> that too… may I quote you on that?
<igli> sure, tho i doubt anyone will listen ;)