From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 342142B7F7 for ; Thu, 13 Jun 2024 17:52:02 +0200 (CEST) Received: (qmail 5622 invoked by uid 550); 13 Jun 2024 15:51:58 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 5585 invoked from network); 13 Jun 2024 15:51:57 -0000 Date: Thu, 13 Jun 2024 15:44:19 +0000 (UTC) From: Thorsten Glaser X-X-Sender: tg@herc.mirbsd.org To: musl@lists.openwall.com cc: erny hombre In-Reply-To: <20240613153729.GY10433@brightrain.aerifal.cx> Message-ID: References: <20240613134607.GW10433@brightrain.aerifal.cx> <20240613153729.GY10433@brightrain.aerifal.cx> Content-Language: de-Zsym-DE-1901-u-em-text-rg-denw-tz-utc, en-Zsym-GB-u-cu-eur-em-text-fw-mon-hc-h23-ms-metric-mu-celsius-rg-denw-tz-utc-va-posix MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Subject: Re: [musl] possible bug in syslog Rich Felker dixit: >That seems okay. However I also kinda wonder if LOG_MAKEPRI shouldn't >just be removed. Best not to: I=E2=80=99ve seen code defining it as (((fac) << 3) | (pri)) if not defined while grepping, and: gnu/usr.bin/perl/ext/Sys/Syslog/Syslog.xs: croak("Your vendor has not = defined the Sys::Syslog macro LOG_MAKEPRI"); >This would highlight anything that was previously >broken, and there seems to be utterly no reason to use it when the >standard already specifies that you just or (I missed that before). It seems that LOG_MAKEPRI and the shift may be needed on OS/2=E2=80=A6 >(which TBF is kinda buried; the text in XBD for syslog.h says the >facilities are for openlog not for openlog and syslog). Maybe ask on the Open Group mantis for an editorial correction there? bye, //mirabilos --=20 exceptions: a truly awful implementation of quite a nice idea. just about the worst way you could do something like that, afaic. it's like anti-design. that too=E2=80=A6 may I quote yo= u on that? sure, tho i doubt anyone will listen ;)