From: Nicholas Wilson <nicholas.wilson@realvnc.com>
To: "musl@lists.openwall.com" <musl@lists.openwall.com>
Subject: [PATCH] Use LDFLAGS when testing linker flags
Date: Thu, 7 Dec 2017 16:03:03 +0000 [thread overview]
Message-ID: <VI1PR0502MB3885C5129C26CEF375ECF862E7330@VI1PR0502MB3885.eurprd05.prod.outlook.com> (raw)
Hi,
This is another patch for the WebAssembly build.
In Wasm, we currently need to pass some extra flags to the linker, and LDFLAGS would seem to be a good way to do this.
The patch below tests the linker by passing LDFLAGS on the link line. This ought to be a safe change to make?
Thanks,
Nick
=======
commit a951daab68b4b6ee6f46278f02df279188559b89
Author: Nicholas Wilson <nicholas.wilson@realvnc.com>
Date: Thu Dec 7 15:42:58 2017 +0000
[Wasm] Use LDFLAGS when testing linker
diff --git a/configure b/configure
index f320660d..519d31fa 100755
--- a/configure
+++ b/configure
@@ -98,7 +98,7 @@ fi
tryldflag () {
printf "checking whether linker accepts %s... " "$2"
echo "typedef int x;" > "$tmpc"
-if $CC $LDFLAGS_TRY -nostdlib -shared "$2" -o /dev/null "$tmpc" >/dev/null 2>&1 ; then
+if $CC $LDFLAGS $LDFLAGS_TRY -nostdlib -shared "$2" -o /dev/null "$tmpc" >/dev/null 2>&1 ; then
printf "yes\n"
eval "$1=\"\${$1} \$2\""
eval "$1=\${$1# }"
next reply other threads:[~2017-12-07 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 16:03 Nicholas Wilson [this message]
2017-12-15 4:34 ` Rich Felker
2017-12-15 12:42 ` Nicholas Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0502MB3885C5129C26CEF375ECF862E7330@VI1PR0502MB3885.eurprd05.prod.outlook.com \
--to=nicholas.wilson@realvnc.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).