From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12222 Path: news.gmane.org!.POSTED!not-for-mail From: Nicholas Wilson Newsgroups: gmane.linux.lib.musl.general Subject: [PATCH] Use LDFLAGS when testing linker flags Date: Thu, 7 Dec 2017 16:03:03 +0000 Message-ID: Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1512662617 18875 195.159.176.226 (7 Dec 2017 16:03:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 7 Dec 2017 16:03:37 +0000 (UTC) To: "musl@lists.openwall.com" Original-X-From: musl-return-12238-gllmg-musl=m.gmane.org@lists.openwall.com Thu Dec 07 17:03:30 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1eMye1-0004in-SZ for gllmg-musl@m.gmane.org; Thu, 07 Dec 2017 17:03:29 +0100 Original-Received: (qmail 18220 invoked by uid 550); 7 Dec 2017 16:03:35 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 18147 invoked from network); 7 Dec 2017 16:03:19 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=realvnc.onmicrosoft.com; s=selector1-realvnc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YMewa+ZdXSrx5wH0D80gVZA4bdkc8g3fsMBNpqz03nY=; b=jWgONdTkejY8AfcOxN4oGAtn9gB6cLWqUeUCD12AMQ6DRvcIwlswgXo33HwGPSgxF070aQgzH/GZwCyNuoxRcGm+F2x31vq7qu++AnaTzgHtIiqIACJiqx54v8Yk3WNqZwbvM5SAzjeWWcPQzfrAO59yjdQumwsTEMwMPAiHtCY= Thread-Topic: [PATCH] Use LDFLAGS when testing linker flags Thread-Index: AQHTb3S6mlSRGLsDz0GKusw8plB39Q== Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=nicholas.wilson@realvnc.com; x-originating-ip: [2a02:390:a001:192:d6be:d9ff:fe9c:1892] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR0502MB3887;6:VN5llZtweNP9MmUOTi1xvGZ1j6x71SZTSGYq2HGIprSaodDH/4XQCjPdcVy/0XcjODsiu/mHBJN17JQkHQRdsUswsOgHRjdDlqJnojd69uhd/XBvIAMSN7rVvtXZ3AFKi6KfATi89rMRevv/oz9G8cCnKwBVzEtTJqz8kAnaNYj+KKQYPo/SJyPVNscWVf19EcbcgaMyMb3gbjCtdWwgzVvjljVOmCx/waVfyAfo9fjatc/8ovsibB2OgkIwkHVW7cuZ54CfHT26xEaz1pyELmzNdNeU7acn18JiO7fDcGn8jDL4HKy0fJCtk4jse/Kl6Z8zZEQIS/BvEIqzJvb4jIZp66grB8QFGJnitaN/Yyc=;5:ABLCOBZDQBYEmT2uEO4qCZ9ZTofSM67NdXFCVlVQAeAl/DQQ219P2pJLkr7GZaGjJuwi+PKClSjXCH18sLfyifSlBFJgCRlEPjhWhpC9dxk8rQJVpfnLZNmTt0NLrur50KgXnWR+oAtEUI0rFNWD3gwdZJaN13A4Wpx3p9Hn7MY=;24:5i4ESOccIFbVowqcxIjhjsbpuDrhjZhPpfhS4otGp0XK6F1MSrhnQ8VzpIO2GAohoktZBjRdJWhaZkccjwOF5KzwQXoKvZNamYQ5q+kMcrs=;7:ov1C4690cb9GM72ohoRdTWoIPRdhx5WeDANoSp4GCTEddMLgXA9AT5skWlzydzl2Xfw9lEno0nL8dD9oGNhkE6tLchGR wQVrQIwQWWhDq9CJF9z9gYMNAwoHHwADVM2/bqx1VpDlUMOQjq+se40A0y9L1pq9hMRkl1RjajbaWafdEug6qIurul4enS4Ca6 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: fbd131b0-c727-40cb-3611-08d53d8bff47 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4603075)(4627115)(201702281549075)(2017052603286);SRVR:VI1PR0502MB3887; x-ms-traffictypediagnostic: VI1PR0502MB3887: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231022)(10201501046)(6041248)(2016111802025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123560025)(20161123562025)(6043046)(6072148)(201708071742011);SRVR:VI1PR0502MB3887;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:VI1PR0502MB3887; x-forefront-prvs: 05143A8241 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(346002)(376002)(366004)(189003)(199004)(74316002)(5660300001)(99286004)(305945005)(7736002)(3660700001)(3280700002)(33656002)(97736004)(2900100001)(8936002)(55016002)(101416001)(6436002)(9686003)(53936002)(25786009)(14454004)(68736007)(105586002)(2501003)(5640700003)(2351001)(81166006)(102836003)(8676002)(106356001)(316002)(7696005)(6916009)(478600001)(86362001)(6506006)(6116002)(2906002)(5250100002)(81156014)(1730700003);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0502MB3887;H:VI1PR0502MB3885.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: realvnc.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM X-MS-Exchange-CrossTenant-Network-Message-Id: fbd131b0-c727-40cb-3611-08d53d8bff47 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2017 16:03:03.4617 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 9ad766d3-c6a5-4458-8c58-244e7c118728 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB3887 X-OriginatorOrg: realvnc.com Xref: news.gmane.org gmane.linux.lib.musl.general:12222 Archived-At: Hi, This is another patch for the WebAssembly build. In Wasm, we currently need to pass some extra flags to the linker, and LDFL= AGS would seem to be a good way to do this. The patch below tests the linker by passing LDFLAGS on the link line. This = ought to be a safe change to make? Thanks, Nick =3D=3D=3D=3D=3D=3D=3D commit a951daab68b4b6ee6f46278f02df279188559b89 Author: Nicholas Wilson Date: Thu Dec 7 15:42:58 2017 +0000 [Wasm] Use LDFLAGS when testing linker diff --git a/configure b/configure index f320660d..519d31fa 100755 --- a/configure +++ b/configure @@ -98,7 +98,7 @@ fi tryldflag () { printf "checking whether linker accepts %s... " "$2" echo "typedef int x;" > "$tmpc" -if $CC $LDFLAGS_TRY -nostdlib -shared "$2" -o /dev/null "$tmpc" >/dev/null= 2>&1 ; then +if $CC $LDFLAGS $LDFLAGS_TRY -nostdlib -shared "$2" -o /dev/null "$tmpc" >= /dev/null 2>&1 ; then printf "yes\n" eval "$1=3D\"\${$1} \$2\"" eval "$1=3D\${$1# }"