mailing list of musl libc
 help / color / mirror / Atom feed
* [musl] [PATCH] [stable v4.4] arm64: Remove unimplemented syscall log message
@ 2021-06-02 11:46 Arnd Bergmann
  2021-06-08 17:06 ` [musl] " Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-06-02 11:46 UTC (permalink / raw)
  To: stable
  Cc: Michael Weiser, Martin Vajnar, musl, Will Deacon,
	Greg Kroah-Hartman, Arnd Bergmann

From: Michael Weiser <michael.weiser@gmx.de>

commit 1962682d2b2fbe6cfa995a85c53c069fadda473e upstream.

Stop printing a (ratelimited) kernel message for each instance of an
unimplemented syscall being called. Userland making an unimplemented
syscall is not necessarily misbehaviour and to be expected with a
current userland running on an older kernel. Also, the current message
looks scary to users but does not actually indicate a real problem nor
help them narrow down the cause. Just rely on sys_ni_syscall() to return
-ENOSYS.

Cc: <stable@vger.kernel.org>
Cc: Martin Vajnar <martin.vajnar@gmail.com>
Cc: musl@lists.openwall.com
Acked-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Michael Weiser <michael.weiser@gmx.de>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
This was backported to v4.14 and later, but is missing in v4.4 and
before, apparently because of a trivial merge conflict. This is
a manual backport I did after I saw a report about the issue
by Martin Vajnar on the musl mailing list.
---
 arch/arm64/kernel/traps.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c
index 02710f99c137..a8c0fd0574fa 100644
--- a/arch/arm64/kernel/traps.c
+++ b/arch/arm64/kernel/traps.c
@@ -381,14 +381,6 @@ asmlinkage long do_ni_syscall(struct pt_regs *regs)
 	}
 #endif
 
-	if (show_unhandled_signals_ratelimited()) {
-		pr_info("%s[%d]: syscall %d\n", current->comm,
-			task_pid_nr(current), (int)regs->syscallno);
-		dump_instr("", regs);
-		if (user_mode(regs))
-			__show_regs(regs);
-	}
-
 	return sys_ni_syscall();
 }
 
-- 
2.29.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [musl] Re: [PATCH] [stable v4.4] arm64: Remove unimplemented syscall log message
  2021-06-02 11:46 [musl] [PATCH] [stable v4.4] arm64: Remove unimplemented syscall log message Arnd Bergmann
@ 2021-06-08 17:06 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-06-08 17:06 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: stable, Michael Weiser, Martin Vajnar, musl, Will Deacon, Arnd Bergmann

On Wed, Jun 02, 2021 at 01:46:51PM +0200, Arnd Bergmann wrote:
> From: Michael Weiser <michael.weiser@gmx.de>
> 
> commit 1962682d2b2fbe6cfa995a85c53c069fadda473e upstream.
> 
> Stop printing a (ratelimited) kernel message for each instance of an
> unimplemented syscall being called. Userland making an unimplemented
> syscall is not necessarily misbehaviour and to be expected with a
> current userland running on an older kernel. Also, the current message
> looks scary to users but does not actually indicate a real problem nor
> help them narrow down the cause. Just rely on sys_ni_syscall() to return
> -ENOSYS.
> 
> Cc: <stable@vger.kernel.org>
> Cc: Martin Vajnar <martin.vajnar@gmail.com>
> Cc: musl@lists.openwall.com
> Acked-by: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Michael Weiser <michael.weiser@gmx.de>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> This was backported to v4.14 and later, but is missing in v4.4 and
> before, apparently because of a trivial merge conflict. This is
> a manual backport I did after I saw a report about the issue
> by Martin Vajnar on the musl mailing list.
> ---
>  arch/arm64/kernel/traps.c | 8 --------
>  1 file changed, 8 deletions(-)

Now queued up, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-08 17:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-02 11:46 [musl] [PATCH] [stable v4.4] arm64: Remove unimplemented syscall log message Arnd Bergmann
2021-06-08 17:06 ` [musl] " Greg Kroah-Hartman

mailing list of musl libc

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/musl

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 musl musl/ http://inbox.vuxu.org/musl \
		musl@inbox.vuxu.org
	public-inbox-index musl

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.musl


code repositories for the project(s) associated with this inbox:

	https://git.vuxu.org/mirror/musl/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git