From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 26278 invoked from network); 28 Apr 2022 02:02:43 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 28 Apr 2022 02:02:43 -0000 Received: (qmail 9679 invoked by uid 550); 28 Apr 2022 02:02:39 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 9641 invoked from network); 28 Apr 2022 02:02:39 -0000 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ardBMx15FWdkySXOFbiQEZERUTSDXNj5nwGTAdpakTY=; b=3mZIx4DB1XwsaMU+Ou7dAI0O+FV8mRl0lQn9x6S9GMAs3tAEwUVVA2FtKLFuIVhVXa 9toozx7AVRX72p+jo7xqyHqCGnB5cLHV3RdLfo7PSFX5KgnLi15ra1XkQxtYxAQ1CGHk Ipj5sNz06UEoF6fmbOmd7oGZBR2fGfgJ4gWZeP772/9Sceb2/b+rr/8TvtRqIKa+4gbf FA3GBsUmuJ2oXpUKytIPu3cV0pHxPC6Ugq6mAB8bj/yc2RIiAVRXJAkBIXNbd2M+pD4p tmT/ZDZL/SwG9XEEzCQX0EKeZ6zY7OUZf3kWqIxAk1ie1n8+pY/XSnEpnQ679L74+Ypo q73Q== X-Gm-Message-State: AOAM532EV5l7jq+iWmBlPv7LNuN4yCwQPCGLzBJQBY2KC+9ymbo5QQXv soFiwgRdTtK6GaRU4Y9cIbL4lwHKaf79kZin3t54Gc3F1IsUxOrKmJKq7AjmrHZE56OpXKPjjuw AfIF9hycC2hVG9nzxnYY= X-Received: by 2002:a17:90b:1d90:b0:1d9:acbb:ab18 with SMTP id pf16-20020a17090b1d9000b001d9acbbab18mr13323222pjb.170.1651111345757; Wed, 27 Apr 2022 19:02:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLo7pljbt03yKS9ljQdXi8iH94nk9u5U6rubwT8N0809qg6+oW3QH9n65VUFPJbLA1tIUE4A== X-Received: by 2002:a17:90b:1d90:b0:1d9:acbb:ab18 with SMTP id pf16-20020a17090b1d9000b001d9acbbab18mr13323192pjb.170.1651111345411; Wed, 27 Apr 2022 19:02:25 -0700 (PDT) Date: Thu, 28 Apr 2022 11:02:13 +0900 From: Dominique MARTINET To: Rich Felker Cc: Ismael Luceno , musl@lists.openwall.com Message-ID: References: <20220123155955.16484-1-ismael@iodev.co.uk> <20220123155955.16484-3-ismael@iodev.co.uk> <20220309114115.GT7074@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220309114115.GT7074@brightrain.aerifal.cx> Subject: Re: [musl] [PATCH v3 2/2] nftw: implement FTW_ACTIONRETVAL (GNU extension) Hi Rich, Ismael, Rich Felker wrote on Wed, Mar 09, 2022 at 06:41:15AM -0500: > On Wed, Mar 09, 2022 at 01:37:53PM +0900, Dominique MARTINET wrote: > > Rich (or others), is there anything we can do to convince you the > > feature would be interesting? > > I had sent you recap from debian codesearch back in April last year: > > https://www.openwall.com/lists/musl/2021/04/12/10 > > but didn't hear any reply. > > > > It'd be great to just hear a final "no unless it gets more widely used" > > so I could give up and work on converting bpftools to not depend on > > it -- it's just frustrating due to the lack of reply, and while adding > > FTW_ACTIONRETVAL to musl is easy converting a user to something else is > > not so straightforward so I was putting it off... > > > > (Conversely, if there is interest please say so as well -- my patch had > > a couple of feedbacks I would be happy to address, but I just never sent > > a v2 because it looked like it wouldn't be accepted anyway from your > > (lack of) reaction. I don't care if my version of this one gets in > > ultimately, and can help either way.) > > I don't recall whether my question original about meeting criteria for > inclusion/exclusion was really addressed. I'll look back through the > mails and if so then yes this is probably waiting on feedback from me. For followup on my usecase, I've instead adapted bpftool to no longer require FTW_ACTIONRETVAL (this specific call to nftw was replaced with two nested readdir() loop), so bpftool now builds with stock musl without this. If there is ever interest again I'll be happy to finish polishing up any implementation for this as I think it's quite handy, but otherwise I'll just forget about it. Thanks, -- Dominique