From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 2589 invoked from network); 15 May 2022 03:26:05 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 15 May 2022 03:26:05 -0000 Received: (qmail 5880 invoked by uid 550); 15 May 2022 03:26:03 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 5845 invoked from network); 15 May 2022 03:26:02 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9xmJEw+WksKcONziOYqCpbCMU3BoS+PDns03YoFLFYU=; b=jbrJyZKE6MXoIVFyBx2aDdDEvUXcyyTUw2TYYEwDOVQgakaQiHcmqWXn5b1lCvHqFx qAjfv3TlZ+7XiKJoPogmAJfVA0JPQHXTWF3dxnu0ufQ7U+IP5ItZsL0d0AsFeyorzMaM BhB1PJkFPu9okoafpLw+7/UVV+GhbXoGCE/b4ropCFE5UbbPVgIjVENmcl8yw6ehYfZV OeC6Yi7c8cM+M/8TVc9ZS8p8wrdx5WborQyTfztISpqCjgH0BTJ4i5Ue8Q7g44TNzRNu ZkXOubRHbB2Vqg79ZNhdZ7bdxiQMe+lyCqpbw0d3yT/DbqXnPgP4LtQNedGNjjhd4rRy qTaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9xmJEw+WksKcONziOYqCpbCMU3BoS+PDns03YoFLFYU=; b=K4WO5LuFjOjQIdvu+t1j5cjP6AUCOginnJhmKvY0YTOv+y/+5ULgnVFY8FUGZFYGka E30z2H1/QOzumGxwCGNVCk1nrrQBqxMtpwnDmguXiVgDNlK7sFAOQ2dPa8lkDqowOw/+ dkleX0cWeLmYW6FshEmBMp7PXJPdXv8ks15dpWBgY8gRodqv0WcQywpE3vU50UDMWcyg casyWZjYPNH5l1vR9NH0yH4I3PlPzRRRUy0wYW0mj4EJDFByAHkFw+uPsUr/onuslniH hWVLQQQF5MrDbTJk296Yw9CRHOcqGp2iXKid8d7jFybJIUtp8P/FN1wyqWMbd7mLd9iO O0AA== X-Gm-Message-State: AOAM530NUIYCbeYlokEBRQYwyCYlH2Wxjt5z+3Lf3g77DdBlUyiayyD6 js6ULl+8MS3fKjkvmOvCPtc= X-Google-Smtp-Source: ABdhPJx1yRCldc+yUQ5hf/GChPM4qXolZVJwU64FJVGN30ZsNsMXKHn9e5wsCl4HbbVQTnPmPahOOQ== X-Received: by 2002:a17:902:ea0f:b0:15e:ad75:80d8 with SMTP id s15-20020a170902ea0f00b0015ead7580d8mr12050861plg.150.1652585149965; Sat, 14 May 2022 20:25:49 -0700 (PDT) Date: Sun, 15 May 2022 12:25:47 +0900 From: Stafford Horne To: Florian Fainelli Cc: buildroot@buildroot.org, Thomas Petazzoni , mmayer@broadcom.com, yann.morin.1998@free.fr, musl@lists.openwall.com Message-ID: References: <20220511001947.2112747-1-f.fainelli@gmail.com> <14506c30-bf1c-71b3-bda5-b9105adf85b4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <14506c30-bf1c-71b3-bda5-b9105adf85b4@gmail.com> Subject: [musl] Re: [Buildroot] [PATCH] package/cpulimit: Disable build on OpenRISC with musl-libc On Sat, May 14, 2022 at 07:14:21PM -0700, Florian Fainelli wrote: > > > On 5/14/2022 7:09 PM, Stafford Horne wrote: > > On Tue, May 10, 2022 at 05:19:47PM -0700, Florian Fainelli wrote: > > > As reported in the following autobuild report: > > > > > > http://autobuild.buildroot.net/results/2a9cf20949beac46d1c689df2c5b7ab0d59c08b5/ > > > > > > cpulimit does not build due to a lack of definition for elf_gregset_t > > > which is not currently provided in the or1k musl-libc port. While this > > > is being worked on, disable the build for or1k and musl-libc. > > > > Hello, > > > > You mention this is being worked on. I am curious who is working on this? > > > > I try to look over OpenRISC stuff, do you need me to do anything on musl for > > this? > > I posted this: > > https://www.openwall.com/lists/musl/2022/05/10/1 > > if you don't mind reviewing, thanks! No problem, I don't have the mail in my inbox, I've subscribed to musl now. Put some comments below based on what I had configured in glibc. diff --git a/arch/or1k/bits/user.h b/arch/or1k/bits/user.h index e69de29bb2d1..3405bf771c0f 100644 --- a/arch/or1k/bits/user.h +++ b/arch/or1k/bits/user.h @@ -0,0 +1,11 @@ +struct user_regs { + unsigned long gpr[32]; + unsigned long pc; + unsigned long sr; +}; OK, matches glibc. +#define ELF_NGREG 34 In glibc we define this as 32. Howerver, we define elf_gregset_t as elf_gregset_t[34]. I don't see where ELF_NGREG is really used so I am not sure of the impact to this. I also can't remember why I set these different in glibc. +typedef unsigned long elf_greg_t, elf_gregset_t[ELF_NGREG]; + +/* or32 does not have floating point support, placeholder */ +typedef unsigned long elf_fpregset_t; OpenRISC uses the same registers and floating point and integer. This is defined in glibc as: /* Register set for the floating-point registers. */ typedef elf_greg_t elf_fpregset_t[32]; -Stafford