mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Stafford Horne <>
To: Florian Fainelli <>
Subject: [musl] Re: [PATCH v2] Define user_regs, elf_greg_t and elf_fpregset_t for or1k
Date: Thu, 19 May 2022 13:18:35 +0900	[thread overview]
Message-ID: <YoXFGwbFzvBsaaJl@antec> (raw)
In-Reply-To: <>

On Tue, May 17, 2022 at 02:58:26PM -0700, Florian Fainelli wrote:
> The OpenRISC architecture is currently missing a definition of its
> user_regs structure, elf_greg_t and elf_fpregset_t as well as ELF_NGREG,
> add those.
> ---
> Changes in v2:
> - Follow Stafford's recommendations based upon glibc
>  arch/or1k/bits/user.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> diff --git a/arch/or1k/bits/user.h b/arch/or1k/bits/user.h
> index e69de29bb2d1..227f022e2fec 100644
> --- a/arch/or1k/bits/user.h
> +++ b/arch/or1k/bits/user.h
> @@ -0,0 +1,10 @@
> +struct user_regs {
> +	unsigned long gpr[32];
> +	unsigned long pc;
> +	unsigned long sr;
> +};
> +
> +#define ELF_NGREG 32
> +typedef unsigned long elf_greg_t, elf_gregset_t[ELF_NGREG];
> +

I think ELF_NGREG should be 34 here.

On glibc we defined this like this, but I am beginning to doubt it is correct:

    #define __NGREG	32

    #define ELF_NGREG __NGREG
    typedef elf_greg_t elf_gregset_t[34];

In linux and some other architectures they define ELF_NGREG as below (so that
would mean 34 is right):

    #define ELF_NGREG (sizeof (struct user_regs_struct) / sizeof (elf_greg_t))

In linux we define this, so yours matches.

    truct user_regs_struct {
	    /* GPR R0-R31... */
	    unsigned long gpr[32];
	    unsigned long pc;
	    unsigned long sr;

> +typedef elf_greg_t elf_fpregset_t[ELF_NGREG];

This should be:

    typedef elf_greg_t elf_fpregset_t[32];

However, I have tested all of glibc with the definition as above with ELF_NGREG
32 and elf_gregset_t[34].  But, I think I will like to change that and test

So in the end I think we should use this.

   #define ELF_NGREG (sizeof (struct user_regs) / sizeof (elf_greg_t))
   typedef elf_greg_t elf_gregset_t[ELF_NGREG];
   typedef elf_greg_t elf_fpregset_t[32];

Side Point

I am not sure why cpulimit needs elf_gregset_t anyway.  I see it includes
procfs.h, I removed that include and it seems to compile ok.


  reply	other threads:[~2022-05-19  4:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17 21:58 [musl] " Florian Fainelli
2022-05-19  4:18 ` Stafford Horne [this message]
2022-05-19 21:29   ` [musl] " Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoXFGwbFzvBsaaJl@antec \ \ \ \ \ \ \
    --subject='[musl] Re: [PATCH v2] Define user_regs, elf_greg_t and elf_fpregset_t for or1k' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).