mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Markus Wichmann <nullplan@gmx.net>
To: musl@lists.openwall.com
Cc: lihua.zhao.cn@windriver.com
Subject: Re: [musl] [PATCH v2] signal: check sigpause() input parameter
Date: Wed, 18 Dec 2024 09:12:36 +0100	[thread overview]
Message-ID: <Z2KD9MPG7DiS7bsM@voyager> (raw)
In-Reply-To: <20241218024952.3377660-1-lihua.zhao.cn@windriver.com>

Am Wed, Dec 18, 2024 at 10:49:52AM +0800 schrieb lihua.zhao.cn@windriver.com:
> From: Lihua Zhao <lihua.zhao.cn@windriver.com>
>
> ---
>  src/signal/sigpause.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/src/signal/sigpause.c b/src/signal/sigpause.c
> index 363d2fec..8bd05f58 100644
> --- a/src/signal/sigpause.c
> +++ b/src/signal/sigpause.c
> @@ -1,8 +1,13 @@
>  #include <signal.h>
> +#include <errno.h>
>
>  int sigpause(int sig)
>  {
>  	sigset_t mask;
> +	if (sig < 1 || sig >= _NSIG) {
> +		errno = EINVAL;
> +		return -1;
> +	}
>  	sigprocmask(0, 0, &mask);
>  	sigdelset(&mask, sig);
>  	return sigsuspend(&mask);
> --
> 2.34.1

I looked around at the competition to figure out what the concensus
seems to be on input checking. POSIX no longer specifies the function,
so that is basically all that can be done at this point.

dietlibc doesn't have this function. Neither ctags nor a fulltext search
could find it in there.

glibc and bionic both have input checking but move it into sigdelset()
(they fail the function if sigprocmask() or sigdelset() fail). musl
already has input checking in sigdelset() if that fails, so maybe a
better change would be to just use those functions instead.

int sigpause(int sig)
{
    sigset_t mask;
    if (sigprocmask(0, 0, &mask) || sigdelset(&mask, sig)) return -1;
    return sigsuspend(&mask);
}

Ciao,
Markus

  reply	other threads:[~2024-12-18  8:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-17 13:15 [musl] [PATCH] " lihua.zhao.cn
2024-12-18  2:49 ` [musl] [PATCH v2] " lihua.zhao.cn
2024-12-18  8:12   ` Markus Wichmann [this message]
2024-12-18  9:12     ` [musl] [PATCH v3] " lihua.zhao.cn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z2KD9MPG7DiS7bsM@voyager \
    --to=nullplan@gmx.net \
    --cc=lihua.zhao.cn@windriver.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).