mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Markus Wichmann <nullplan@gmx.net>
To: musl@lists.openwall.com
Subject: Re: [musl] Re:Re: Re: [musl] Question:Why musl call a_barrier in __pthread_once?
Date: Sun, 21 May 2023 21:16:09 +0200	[thread overview]
Message-ID: <ZGpt+VF3e5pmnXKH@voyager> (raw)
In-Reply-To: <tencent_BA6EF0C4ED071F0A173FBBC169C4F3E4B10A@qq.com>

Am Thu, May 18, 2023 at 10:37:06PM +0800 schrieb 847567161:
> How about the  implement of aosp? Didn't they follow the posix?
> http://aospxref.com/android-13.0.0_r3/xref/bionic/libc/bionic/pthread_once.cpp#41
>

Apparently not. If the initialization routine is cancelled, the control
variable is not reset to 0, so all future calls to pthread_once() on the
same variable will just hang. But that can be remedied with adding the
requisite pthread_cleanup_push()/pop() calls around the call to the
init routine.

Besides it doesn't help your case. You wanted to remove the "dmb"
instruction right? Well, that code adds it if the compiler thinks it is
necessary, and GCC trunk for ARM does so: https://godbolt.org/z/WcrfTdTx5

Ciao,
Markus

  parent reply	other threads:[~2023-05-21 19:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-18 14:37 [musl] =?gb18030?B?UmU6UmU6IFJlOiBbbXVzbF0gUXVlc3Rpb26juldoeSBtdXNsIGNhbGwgYV9iYXJyaWVyIGluIF9fcHRocmVhZF9vbmNlPw==?= =?gb18030?B?ODQ3NTY3MTYx?=
2023-05-18 14:55 ` [musl] Re:Re: Re: [musl] Question:Why musl call a_barrier in __pthread_once? Szabolcs Nagy
2023-05-21 19:16 ` Markus Wichmann [this message]
2023-05-22  1:53 [musl] =?gb18030?B?UmU6UmU6IFJlOiBbbXVzbF0gUXVlc3Rpb26juldoeSBtdXNsIGNhbGwgYV9iYXJyaWVyIGluIF9fcHRocmVhZF9vbmNlPw==?= =?gb18030?B?ODQ3NTY3MTYx?=
2023-05-23 19:41 ` [musl] Re:Re: Re: [musl] Question:Why musl call a_barrier in __pthread_once? Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZGpt+VF3e5pmnXKH@voyager \
    --to=nullplan@gmx.net \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).