From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 14995 invoked from network); 1 Nov 2023 13:53:48 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 1 Nov 2023 13:53:48 -0000 Received: (qmail 19813 invoked by uid 550); 1 Nov 2023 13:53:46 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 19770 invoked from network); 1 Nov 2023 13:53:45 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1698846813; x=1699451613; i=nullplan@gmx.net; bh=pSlajyRJu99e4xV+omQjj96p4mcMuz6rARs+PjkN48Y=; h=X-UI-Sender-Class:Date:From:To:Subject:References:In-Reply-To; b=O2rinR1HZtoWRNCNWVDxUOvjCfJ28IGhig3IvlE454X3X68HMHczXWgBGKMgObvx ODkpY8InHYkXYOdcEUjNNgDd2912t8MvKicmt56Dr0Oz8+5zQS4V6n/cPdIjMakZQ gGsmm6Zhusva+KeOfBPag7i8aqZmtyBeQardyxMTY2AocwR/6r7lUL52O0+0X1Mwo 33Vvl+1SdLgIzY3q29oBw/VRLXHSaEqiOFJD9H/Onn+zZbcmYlWiQccVh/gJQLA6q SRN+tAFU/e5NSjmdHZjjrRSzbM4NDf7G0iYveCHP2VsfMFy7nNLW4rkczoFoXdnK4 n3GqIwh6DqCUYT2ssQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Date: Wed, 1 Nov 2023 14:53:32 +0100 From: Markus Wichmann To: musl@lists.openwall.com Message-ID: References: <20231101130033.GR4163@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231101130033.GR4163@brightrain.aerifal.cx> X-Provags-ID: V03:K1:X3ObFw9C9tJ5ULlUNQUb6CgJ4tWzl041luMk4+nh5z6C9SSOdGc 3q8u9wmhUMDHoCsWjRBgHLh3iAsAiOBO0mFUDizfPrKFCQS9X5Btb9SDqf3odjtDCXxlsNy GdihkWAMUqzZ6F6ZWdR+5COV73QduBF3PIBZ5aish1kJvzbnSDpEMpesl2bg78FuFuu2FqY Jl05uN68zIBKYhCjFzA8g== UI-OutboundReport: notjunk:1;M01:P0:VnllzY4DLvM=;wAe8lJDaVuTjnmNd4AftsvEiDPM A6/6uP/MphwVdX5jZE9PwJJcbNjkyBHeFGlRNVcfLDjA7D75zW39HMuANMUR0zCa3hNjU3h96 BtHkBC62NnBk81i0QwQg6EpJ0HT4HmMvYIpGvzinuya9q8B8fqo1ncA4pnZvYW2vp8BAS7EDx ES2K2NH3lgSMV0KghFQjNvBVkq4dGxieZQjylGCjbpU6Vq0cdDbpA+D5wAZryre0Tdkq4ft5i Px8wk8MbA0A+yvOvaB0J0G/XuutZ4LkUibuAU2HhPDTlJevRxOcD8DiGfUJdIwjOxWXUgd+8/ kvaOVox9s8kcws9saE/loViNB8h0ksl82UCYnAckdbJDcvh7AQFTUPa9efdosr/FEowMTPxxO V/GPk/C6g+7UDCSB1AtxS7AsIdC9IQHo68QTxk4/zdYSdRnbRVKMzPNaAZGA1jePFtIhqJzYy 3J/hHqnP6GDWe5XEdV0MFyhnWTUHGnj5BeVfqMwM3l558Gdfeh4kmTrrL2ivaQA15G+02W8NN YU1YGj2U728zVJZZTzjQx0UEjRyOTFv+8Qb1ydh30mdCDXGUXe6jA+KBJqtQjhDZdxFYx67t4 uGDMi8ah4DZlnXElok01uoNEWtN7d5TpoWHLNzPFYSpH2/1q9FuJsW9CkdXENQL3k/qfIdOrg nhh3HL5NvrP8zAKKzIqpG4v5Wr4hpwLqn/+ay+DUOJ17KitXTNDQy85y3WAqwTcFYlONGHAya D1v3S54GCPqJuokyi74fa7yop18ytKV1D54ROosy++TYNiFVjBG1yuvjqao3cWszC2RrzZ80U q7Ry7K+1Da2k70hQgoX2MRzyts8lD1U/xbTA9CmrLAGoQZOZDs7T3dONovG+gxBVUtFqlfr1u urm6Zzq4xwXQ/Q/puhwfqrySIabE7T7msik87nYMGGoLxPDI7gED3V70GuwyPtYRIVrKeS+2Y obTrvw== Content-Transfer-Encoding: quoted-printable Subject: Re: [musl] synccall patches Am Wed, Nov 01, 2023 at 09:00:33AM -0400 schrieb Rich Felker: > On the other hand, the thing you're worried about, the original value > of c.ret being passed to __syscall_ret, can't happen. If it was > initially positive on entry to do_setxid, a syscall is made and the > return value is stored into c.ret. > But if the tkill fails in __synccall, do_setxid() will never be called at all (that's what line 87 in synccall.c does). So the original value will remain. Perhaps __synccall should return failure in that case, after doing everything else. Then the logic could otherwise remain untouched, and __setxid could respond appropriately to the failure itself. Ciao, Markus