mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Markus Wichmann <nullplan@gmx.net>
To: musl@lists.openwall.com
Cc: Anuraag Agrawal <anuraaga@gmail.com>
Subject: Re: [musl] Large overflow in __intscan ignored
Date: Fri, 1 Dec 2023 17:21:44 +0100	[thread overview]
Message-ID: <ZWoIGGT49V-21l0d@voyager> (raw)
In-Reply-To: <CAOWvS+0oOjLue4S=E1ua7oMMe-EZn_zaU3RvYDMuSGNxDP2isw@mail.gmail.com>

Am Fri, Dec 01, 2023 at 02:08:54PM +0900 schrieb Anuraag Agrawal:
> Currently, __intscan, used by functions like strtol, does not seem to check
> for overflow during multiplication.
>
> https://git.musl-libc.org/cgit/musl/tree/src/internal/intscan.c#n69
>

There is no multiplication in the referenced line. Assuming you mean the
one above it, the loop condition checks that neither the multiplication
nor the addition can overflow. The same holds for the loop on lines 79f.

As far as I can tell, this has been the case since the first version of
this code was checked in in 2012.

Ciao,
Markus

  parent reply	other threads:[~2023-12-01 16:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-01  5:08 Anuraag Agrawal
2023-12-01  5:14 ` [musl] " Anuraag Agrawal
2023-12-01 15:52   ` Rich Felker
2023-12-01 16:21 ` Markus Wichmann [this message]
2023-12-02  1:42   ` [musl] " Anuraag Agrawal
2023-12-02  8:48     ` Markus Wichmann
2023-12-02 16:29       ` Rich Felker
2024-02-26  1:30         ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZWoIGGT49V-21l0d@voyager \
    --to=nullplan@gmx.net \
    --cc=anuraaga@gmail.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).