From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 07FB021D41 for ; Sun, 18 Feb 2024 13:54:05 +0100 (CET) Received: (qmail 9581 invoked by uid 550); 18 Feb 2024 12:50:51 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 3692 invoked from network); 18 Feb 2024 12:44:53 -0000 Date: Sun, 18 Feb 2024 15:47:53 +0300 From: Valery Ushakov To: musl@lists.openwall.com Message-ID: References: <349f4e17-8027-c521-eeb3-aa69e8f2b5a4@landley.net> <20240218013428.GJ4163@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240218013428.GJ4163@brightrain.aerifal.cx> Subject: Re: [musl] Re: Not sure how to debug this one. On Sat, Feb 17, 2024 at 20:34:28 -0500, Rich Felker wrote: > As you've noted, comments would be nice, but I'm not sure where they > belong since it's the same logic on every arch. In all of them? You are looking at it from the PoV of someone who maintains all of them and for you they are all in the picture at once. But consider someone who tries to read one specific file in isolation. Also in asm code the gory details of the specific CPU/ABI are mixed in with the actual logic of what the code does, so at least in that regard the comments will differ. After 20+ years of working on and off on netbsd code base, hopping all over the tree component-wise and across half a dozen cpus for asm code, sometimes with gaps measured in years - I've grown to appreciate well commented code that lets me quickly swap the context into my brain when get back to that code a decade later. Like, what is jmp_buf::__fl? :) It's probably referred to in asm files by a magic number, so there's just one instance of this name in the source tree and it's not commented and is not cross-referencable with the asm code without doing the math (after checking MD definitions). -uwe