From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 7432323C09 for ; Thu, 25 Apr 2024 05:21:56 +0200 (CEST) Received: (qmail 16076 invoked by uid 550); 25 Apr 2024 03:21:49 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 16038 invoked from network); 25 Apr 2024 03:21:49 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1714015289; x=1714620089; i=nullplan@gmx.net; bh=9t+Ud9d8K9Bo1q//zRoXyhN6qsAdxEztKVOOvLWsEyQ=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=sZ9rmFAHTi6Tt5sikJFoq5Y0/L2tYZDxqu4ZVMyDkNVo+Arm3++OUXU7JKODgrbu Soqy/5ZevwAOEY/PStbDZOrML90wdT1ZPEkjoyQtkDZd55WLGWgTkZODyp/0c5rh5 1/UJlj8hN09yt+Rb3XoivMwEGOmVVovwquG5wkzQas8dT85pXoQ/Y9RHvWALIZvf8 A+t5Og4rrE/sG3Kn25jhjlWLgd6jo3qtLtvje+3eTVIr4Xu/mzROAUsFTmeugoWT0 kPLXMYm6KZlk3KyS423/aJxQpIOSNnbRRb4HY+QT/GkRD9w8aOq7N6gJAP0l45T/g B/uQOqsqaOnQj/RvNg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Date: Thu, 25 Apr 2024 05:21:27 +0200 From: Markus Wichmann To: musl@lists.openwall.com Cc: Duncan Bellamy , info@bnoordhuis.nl Message-ID: References: <20200119121247.37310-1-info@bnoordhuis.nl> <20220831190735.52016-1-dunk@denkimushi.com> <20220831190735.52016-2-dunk@denkimushi.com> <20240224165632.GA4163@brightrain.aerifal.cx> <20240424193038.GP4163@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Provags-ID: V03:K1:crcq5cpE/9CDNltU4e/nmL/CU9C+L2yXUyEdtVvW3942OgaVb7+ kcoNbCsW+i8mTY3f+vOvbRckVA/CihQu0kyZpR7uHBSeoqY58JbKkzILlI1CZILpuBszDXV hPVg4IvZ+YCK2AYrScsseqCx2l2WgPsvzgJqTeuW7bbvYkct1URA7WdvEYmjMoSc9zJX937 kPz8y9GN/+tu8HtXoDO/w== UI-OutboundReport: notjunk:1;M01:P0:B9gOqDKtNNs=;XILzxpj/CQC5Kxn+Jw4KcsGPNqS loQJtzJFb6w9XJdj6VxBk2cFSPJ0e84vNJsTsC/ZRryLfZeCvoiLQlTVj/JY075hWZNFYqtkK 9/bcUrbbAi+XVe/YhquHn088nxC/+f69GCKdlarMPNiZXMdrwbyD0cg4KC1wPCkNfTY+zjUh1 0aK12FVmncP2EPJgyCl0AShTQAAD59z/S3S7jwovcgwDlMo5xABe1pKsqcHAOh9OKtm4snHaO W9nkHo/lOOz9F5XrCmTSebCqq/ccrQBmJiW1mZ3MulIMxnebmac2GN9zkp4IPDjLmqOMS5WET IVy6ecdky41u+Ie0Ue7Bgu/6IzjCYJYq8vsMRvIA5qzs5IL1KI8yiz4we0Pk6w9WOSdGbXpMJ cY9PTgKVZ0VSrEq/hGryznL+FqMqmc9V+JDB7743AOX2BcLIMgDnacs/tkjHWi5+sMJvC/8KQ CS+2naErldGMXvvbL2Olw0Uc1zh9dqDfGQdq0paaMzqLWlzgvmNTj7kSAqgnO0OV2ElGZ51C1 VKySiDNeve7DeQYmKgO5m+vQuSpcAxnad417iFz3lCA35LlNxPhB0IUD6XPiarhMdxQOhTmGu ocVq8jHl/LYhj9Z17TFBpH09++08TTRlwOii5dnLEv4sKazPoRBKTopzyH3E0yo7OAeF87wDY Hhm7qDVwx8AgrbpDBzW4ARVaEt0+rGqxbJcUwShSOeQx5dWR4QZ2sEPzCOiTBOCzYrsgwT1aD W4TFRhSN7xIvkNZNNNL9s+9MZkLaBu4J/3eaUt4S3YPg0Dh8ncfzttjIULlsKmFHWeEC9PCLh K+rWhsqIfy0MAPHyIT6z8DFmwmZ3RcKRmDCjcmc7HuQJ7VJSpGxOYhLmJVQshW1d2J Content-Transfer-Encoding: quoted-printable Subject: Re: [musl] [PATCH 1/2] V3 resubmitting old statx patch with changes Am Wed, Apr 24, 2024 at 07:55:32PM -0400 schrieb lolzery wowzery: > Hi all! I'm new to git over email, new to musl, and I want to really > get into contributing to musl. So, I'd really appreciate any > tips/comments/info for a newbie like me! > Here's one: Please don't top-post. Another one: Are you the same as the OP in this thread? Because I don't seem to have that message, but Rich was quoting someone named "Duncan Bellamy", and that is not the name you put on this message. > Please do not merge these changes yet. There's numerous problems with > this code above and beyond the issues you pointed out, and each of > those issues led me down successive rabbit holes all over the musl > source code and I've ended up opening a sizable can of worms, > including io race condition bugs in fallback conditions, symbol > weakness problems, header/struct misorganization, and bugs in syscall > support detection making musl silently/unexpectedly fail under certain > seccomp configurations. > This is called scope creep, and you should not do it. Fix one issue at a time. If there are problems, report them or send patches one at a time. Especially when you don't know what to do, you might find that the issue you are worried about is not a problem at all when you just speak to people about it. > Also, let me cite the earlier patch from tony.ambardar@gmail.com about > renameat2. My patch will include a full proper renameat2 > implementation with validation and fallback and will compile on > systems where SYS_renameat2 is undefined (using exclusively the > fallback.) > SYS_renameat2 is defined in every architecture musl supports. You have created code that will not be used. I don't think this is a good thing. Generally, new system calls are added to all architectures, though it may take time. Therefore fallbacks for them not being defined are typically useless. And renameat2 is older than seccomp, so not even particularly new. Ciao, Markus