From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id E5C4226673 for ; Tue, 7 May 2024 01:59:17 +0200 (CEST) Received: (qmail 18084 invoked by uid 550); 6 May 2024 23:59:12 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 19764 invoked from network); 6 May 2024 23:42:21 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715038933; x=1715643733; darn=lists.openwall.com; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=+fU/4nBfd6kJfusPZ8CcgXV0UthhtsNo1h/mrjhJMV8=; b=hViHUFB/gB1ayiL2GUMDMt7RhECTl0WFccBLy7HGUL6jCozU0rf9bqCzuJ2p8CYohJ ShMHrDPQyEnjHQG+/tncJAJl4NmQshDhtZeYmF03OOYY3r0eV07GQo8r+YtOkEQc2Ngt O3MHx2EyAPYU7xLjqO4ripyQkfy7LjQTPT3GgNwUAkXnnp6ltktMB2IJgZ2WkgdEjcrO Pc/y6JwoUemf0RX1i2ApQs0WWJhY0z63bhRs+pQuyFpLoRF9wOPxqmKtUniL7ltKN/dN /nTmyQ6olvtu2/DZgqYU3VnICvMi4yORBc2Y9QMuJKvChdAUXdBqe39auf3NmrB/VPqL 8BBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715038933; x=1715643733; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+fU/4nBfd6kJfusPZ8CcgXV0UthhtsNo1h/mrjhJMV8=; b=C/307WLF6rSflyIJy1IStl6/3eGTQLxlkcOY8g8fqq4fA3xKOSBgERwSZFckP/8u8Z oruJtnymXQzMFISyDWOqPCBLfXcKIwAdjoLb9+0hXTrpSAqWZOVWBbigNlDG//sEWJ2Q R33ljbx2eEL5bsvR1CaMpNax44TZ4pT1gg8yjaijkeAQxz1GxP0mSigU9S/K4zGFNOMf pX0pI92dWbheSJ6g7DXNChJW2NTZ3HadYdscsGa5M9u2Fco0CiK5U3y+9JKr/2p7e3zT xip8SOMocwYjMdHxYn9NwWF9s+yEPZQj7aRfqq1uPyCm+7MoYbTzggg/mgeS1cNCZiTq +T0A== X-Gm-Message-State: AOJu0YxPKGKqzSCTrfvzn3NmgYOTleQGnErB9Syk4x2LsJHkX7ktoP8G OfZF9khHbxDKpNuUO/MfN/bPhxvtR6rUO1/7ynOVGn0rbakdjrZ5 X-Google-Smtp-Source: AGHT+IG/p+kfUBOQsU+5vvJxJ16ExvBDsjzP1r/BineXRHUe8F36S5VEu+RIR+S/ZoVK1z2E7o8Haw== X-Received: by 2002:a17:90b:4b02:b0:2a5:5a2c:6066 with SMTP id lx2-20020a17090b4b0200b002a55a2c6066mr9299822pjb.37.1715038932561; Mon, 06 May 2024 16:42:12 -0700 (PDT) From: Tony Ambardar X-Google-Original-From: Tony Ambardar Date: Mon, 6 May 2024 16:42:10 -0700 To: Rich Felker Cc: musl@lists.openwall.com Message-ID: References: <20240421153640.379015-1-Tony.Ambardar@gmail.com> <20240423234355.2414567-1-Tony.Ambardar@gmail.com> <20240506145056.GG10433@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240506145056.GG10433@brightrain.aerifal.cx> Subject: Re: [musl] [PATCH v2] add renameat2 linux syscall wrapper On Mon, May 06, 2024 at 10:50:57AM -0400, Rich Felker wrote: > On Tue, Apr 23, 2024 at 04:43:55PM -0700, Tony Ambardar wrote: > > This syscall is available since Linux 3.15 and also implemented in glibc > > from version 2.28. It is commonly used in filesystem or security contexts. > > [SNIP] > > If flags is 0, the SYS_renameat syscall is semantically equivalent to > the SYS_renameat2 one, so it would be better to just unconditionally > do that first rather than failing and falling back. > Do you mean rearranging and dropping the ENOSYS conditional, e.g. something like below? > int r; > #ifdef SYS_renameat > if (!flags) r = __syscall(SYS_renameat, oldfd, old, newfd, new); > else > #endif > r = __syscall(SYS_renameat2, oldfd, old, newfd, new, flags); > return __syscall_ret(r); Please clarify and I'll update. Thanks, Tony > Rich