From: Stefan Jumarea <stefanjumarea02@gmail.com>
To: Rich Felker <dalias@libc.org>
Cc: musl@lists.openwall.com
Subject: Re: [musl] [PATCH] mallocng: Add MTE support for Aarch64
Date: Tue, 11 Jun 2024 20:13:28 +0300 [thread overview]
Message-ID: <ZmiFuLEEUEmaxYaG@stefan-starfish> (raw)
In-Reply-To: <20240611164222.GQ10433@brightrain.aerifal.cx>
On Tue, Jun 11, 2024 at 12:42:22PM -0400, Rich Felker wrote:
> On Tue, Jun 11, 2024 at 06:37:11PM +0300, Stefan Jumarea wrote:
> > On Tue, Jun 11, 2024 at 10:46:25AM -0400, Rich Felker wrote:
> > > On Tue, Jun 11, 2024 at 04:09:22PM +0200, Szabolcs Nagy wrote:
> > > > * Stefan Jumarea <stefanjumarea02@gmail.com> [2024-06-10 15:36:25 +0300]:
> >
> > This was done since MTE has a 16 byte granule for tagging.
> > Makes more sense to do this where the class is selected, yes. I'm not
> > sure about making it work for smaller allocations, I'll try to think of
> > a way to cover that.
>
> Is there any way to perform a "load, ignoring tag mismatch" operation?
>
Yes, there is the `ldg` instruction that can load the tag of a given
address, so we can use that.
> > > > iirc i changed IB when i tried out mte with mallocng.
> > > >
> > > > i would avoid excessive ifdefs in the code, e.g. by using
> > > > 'p = untag(p);' and define untag appropriately in a header.
> > > > (this might as well do the tag checks when mte is enabled,
> >
> > Agree, will do.
> >
> > >
> > > Yes.
> > >
> > > > but might need special-casing 0 sized allocations.)
> > >
> > > Zero-sized allocations could maybe be implemented as a wrong tag? But
> > > then we'd need a way for free to let them pass untrapped.
> > >
> >
> > Hm, a wrong tag seems like a nice idea, but I don't see an easy way to
> > let the free pass untrapped.
>
> You'd need to be able to peek at the metadata and see that it's
> zero-sized.
>
> > Can we do a special case and return NULL on
> > zero-size allocations?
>
> Nope, that's not an option. While the standard allows it, it's awful
> behavior and fundamentally inconsistent with how realloc works (null
> return is ambiguous between failure to realloc, in which case old
> object would still exit, and successful realloc to size zero, in which
> case old object does not exist).
I see, makes sense.
Stefan
next prev parent reply other threads:[~2024-06-11 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 12:36 Stefan Jumarea
2024-06-10 15:59 ` Rich Felker
2024-06-11 14:09 ` Szabolcs Nagy
2024-06-11 14:46 ` Rich Felker
2024-06-11 15:37 ` Stefan Jumarea
2024-06-11 16:42 ` Rich Felker
2024-06-11 17:13 ` Stefan Jumarea [this message]
2024-06-11 19:39 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmiFuLEEUEmaxYaG@stefan-starfish \
--to=stefanjumarea02@gmail.com \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).