From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 9B0C429027 for ; Wed, 12 Jun 2024 19:10:38 +0200 (CEST) Received: (qmail 3620 invoked by uid 550); 12 Jun 2024 17:10:34 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 3569 invoked from network); 12 Jun 2024 17:10:33 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1718212225; x=1718817025; darn=lists.openwall.com; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QZsvYo/X5JiI3Owh2UBA6SRsHO0XsaYTQgrhGzdVbtg=; b=ZGrY9PUXPbhDPlo7VCDN3hGMpSB7E5IzmIUbbqxSjKgNgYPY7H8wBW29OaQ3ajKVkV uatm6Eij+BdGEeHQL0c/cpX+hPyYlHqsGqHTovUj2Q/c3FzprU7p2mpmLgGwSBD70SS8 jUOYVIra9NcQNjgN6uvQxQfw0/TAv8bnUB/J0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718212225; x=1718817025; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QZsvYo/X5JiI3Owh2UBA6SRsHO0XsaYTQgrhGzdVbtg=; b=EACHThURbzGE+Zpgbhmc8kJsRw3ywLgHcFPZL1sizcEn+TCByoleFmCpGiza7Dx4sP KJZBPHhqWRGMgefRst7U65ZhgK76H1LPjMkGhhigKi61q3Y7gXK8cZ43hPDZgoP+bqrv LjbQRqlymiGBNbZW+AbC7LO4a9VjN5aTb2xiUIkJuCLIE5sWMu6ZhoXrK46zmsgKoWIn MD73LQ2VlAkGcDJbr26ev27K+0whrSZJwUkjPr6ChLaRZnsAgG/JOkzn3KV60OMXNiSS 4PBSmZWbqOyyxAECNf9LYeX/o2kPU3DMVF3WZgg5TQpkzpjizK69tXP3ARZDjOB4cvVp 8kEA== X-Gm-Message-State: AOJu0YxeSSuR8LiRWyMPCx3CxZaM/ikhIb78EatA4uiYW6KtE1YFmAYR FBO5k0GKlLkw9hslLuWjmhRFL1ZRJnW1ZtPG2nl0veLbvFol1+oj7M5F1/cqt0M= X-Google-Smtp-Source: AGHT+IE8bsgAl5cxpAeEOruHAUjx2qPcPQ6rWl2BxebqQBQQLm4kgH7UjwsGtUnL23im3jhXMTOJfA== X-Received: by 2002:a17:902:e752:b0:1f6:6a94:76be with SMTP id d9443c01a7336-1f83b6fce4dmr30021805ad.46.1718212224559; Wed, 12 Jun 2024 10:10:24 -0700 (PDT) Date: Wed, 12 Jun 2024 10:10:21 -0700 From: Joe Damato To: Rich Felker Cc: musl@lists.openwall.com Message-ID: References: <20240529064959.1733708-1-jdamato@fastly.com> <20240529131707.GI10433@brightrain.aerifal.cx> <20240610160551.GO10433@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [musl] [PATCH] sys/epoll.h: add epoll ioctls On Mon, Jun 10, 2024 at 10:15:25AM -0700, Joe Damato wrote: > On Mon, Jun 10, 2024 at 12:05:52PM -0400, Rich Felker wrote: > > On Sun, Jun 02, 2024 at 04:05:25PM -0700, Joe Damato wrote: > > > On Wed, May 29, 2024 at 08:11:13AM -0700, Joe Damato wrote: > > > > On Wed, May 29, 2024 at 09:17:07AM -0400, Rich Felker wrote: > > > > > On Wed, May 29, 2024 at 06:49:59AM +0000, Joe Damato wrote: > > > > > > add two ioctls to get and set struct epoll_params to allow users to > > > > > > control epoll based busy polling of network sockets. > > > > > > > > > > > > added to uapi in commit 18e2bf0edf4dd88d9656ec92395aa47392e85b61 (Linux > > > > > > kernel 6.9 and newer). > > > > > > --- > > > > > > include/sys/epoll.h | 12 ++++++++++++ > > > > > > 1 file changed, 12 insertions(+) > > > > > > > > > > > > diff --git a/include/sys/epoll.h b/include/sys/epoll.h > > > > > > index ac81a841..5f975c4a 100644 > > > > > > --- a/include/sys/epoll.h > > > > > > +++ b/include/sys/epoll.h > > > > > > @@ -7,6 +7,7 @@ extern "C" { > > > > > > > > > > > > #include > > > > > > #include > > > > > > +#include > > > > > > #include > > > > > > > > > > > > #define __NEED_sigset_t > > > > > > @@ -54,6 +55,17 @@ __attribute__ ((__packed__)) > > > > > > #endif > > > > > > ; > > > > > > > > > > > > +struct epoll_params { > > > > > > + uint32_t busy_poll_usecs; > > > > > > + uint16_t busy_poll_budget; > > > > > > + uint8_t prefer_busy_poll; > > > > > > + > > > > > > + uint8_t __pad; > > > > > > +}; > > > > > > + > > > > > > +#define EPOLL_IOC_TYPE 0x8A > > > > > > +#define EPIOCSPARAMS _IOW(EPOLL_IOC_TYPE, 0x01, struct epoll_params) > > > > > > +#define EPIOCGPARAMS _IOR(EPOLL_IOC_TYPE, 0x02, struct epoll_params) > > > > > > > > > > > > int epoll_create(int); > > > > > > int epoll_create1(int); > > > > > > -- > > > > > > 2.34.1 > > > > > > > > > > This is probably okay, but we should at least ask if sys/ioctl.h is > > > > > going to be a namespace mess. Is the intent to bring all of it in, or > > > > > just to get the EPIOC* macros which depend on _IOW and _IOR? > > > > > > > > Yes, sys/ioctl.h is pulled in for the _IOW and _IOR macros. > > > > Similar to, for example, sys/mtio.h in musl, which also pulls in > > > > sys/ioctl.h. > > > > > > > > > On glibc, does it pull in sys/ioctl.h? > > > > > > > > Yes, the code I've submit for glibc does pull in sys/ioctl.h. > > > > > > > > That code has been approved by a glibc committer, but not yet merged > > > > to the tree (I assume that will happen in a few days): > > > > > > > > https://sourceware.org/pipermail/libc-alpha/2024-May/157166.html > > > > > > Just wanted to follow up on the above. > > > > > > Were you expecting me to make any changes or did you want to wait > > > until libc takes the code before accepting it? > > > > > > FWIW: > > > > > > uclibc has taken the patch here: > > > https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/commit/?id=8bb33a2e1f2baec2078581d77e181f1ead5f51aa > > > > > > And musl has similar code in include/sys/mount.h: > > > https://git.musl-libc.org/cgit/musl/tree/include/sys/mount.h#n8 > > > > I think it's okay as-is if this is what everyone else is doing too. > > This is not a standard header so there aren't strong constraints on > > what it can do; I just didn't want to be gratuitously more > > namespace-invasive than on other systems with the same header. > > OK, sure that makes sense. > > BTW, since my email glibc has merged this: > https://sourceware.org/git/?p=glibc.git;a=commit;h=92c270d32caf3f8d5a02b8e46c7ec5d9d0315158 > > Let me know if you'd like me to do anything else to help get this > merged to musl. Apologies on bumping the thread again, just wanted to also mention the man-pages project has also taken the new man page documenting the interface for glibc: https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/?h=ioctl&id=e450bcf6e35a5c227c5e80cdb4e44bb89516a5ee Is there an equivalent documentation I should submit a similar change to that is musl specific? If so, please let me know and I'd be happy to do so. Thanks, Joe