Re: [musl] [PATCH] sys/epoll.h: add epoll ioctls

[Joe Damato <jdamato@fastly.com>]

On Wed, Jun 12, 2024 at 10:10:21AM -0700, Joe Damato wrote:
> On Mon, Jun 10, 2024 at 10:15:25AM -0700, Joe Damato wrote:
> > On Mon, Jun 10, 2024 at 12:05:52PM -0400, Rich Felker wrote:
> > > On Sun, Jun 02, 2024 at 04:05:25PM -0700, Joe Damato wrote:
> > > > On Wed, May 29, 2024 at 08:11:13AM -0700, Joe Damato wrote:
> > > > > On Wed, May 29, 2024 at 09:17:07AM -0400, Rich Felker wrote:
> > > > > > On Wed, May 29, 2024 at 06:49:59AM +0000, Joe Damato wrote:

[...]

> > > > > > This is probably okay, but we should at least ask if sys/ioctl.h is
> > > > > > going to be a namespace mess. Is the intent to bring all of it in, or
> > > > > > just to get the EPIOC* macros which depend on _IOW and _IOR?
> > > > > 
> > > > > Yes, sys/ioctl.h is pulled in for the _IOW and _IOR macros.
> > > > > Similar to, for example, sys/mtio.h in musl, which also pulls in
> > > > > sys/ioctl.h.
> > > > > 
> > > > > > On glibc, does it pull in sys/ioctl.h?
> > > > > 
> > > > > Yes, the code I've submit for glibc does pull in sys/ioctl.h.
> > > > > 
> > > > > That code has been approved by a glibc committer, but not yet merged
> > > > > to the tree (I assume that will happen in a few days):
> > > > > 
> > > > > https://sourceware.org/pipermail/libc-alpha/2024-May/157166.html
> > > > 
> > > > Just wanted to follow up on the above.
> > > > 
> > > > Were you expecting me to make any changes or did you want to wait
> > > > until libc takes the code before accepting it?
> > > > 
> > > > FWIW:
> > > > 
> > > > uclibc has taken the patch here: 
> > > >   https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/commit/?id=8bb33a2e1f2baec2078581d77e181f1ead5f51aa
> > > > 
> > > > And musl has similar code in include/sys/mount.h:
> > > >   https://git.musl-libc.org/cgit/musl/tree/include/sys/mount.h#n8
> > > 
> > > I think it's okay as-is if this is what everyone else is doing too.
> > > This is not a standard header so there aren't strong constraints on
> > > what it can do; I just didn't want to be gratuitously more
> > > namespace-invasive than on other systems with the same header.
> > 
> > OK, sure that makes sense.
> > 
> > BTW, since my email glibc has merged this:
> > https://sourceware.org/git/?p=glibc.git;a=commit;h=92c270d32caf3f8d5a02b8e46c7ec5d9d0315158
> > 
> > Let me know if you'd like me to do anything else to help get this
> > merged to musl.
> 
> Apologies on bumping the thread again, just wanted to also mention
> the man-pages project has also taken the new man page documenting
> the interface for glibc:
> 
> https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/?h=ioctl&id=e450bcf6e35a5c227c5e80cdb4e44bb89516a5ee
> 
> Is there an equivalent documentation I should submit a similar
> change to that is musl specific? If so, please let me know and I'd
> be happy to do so.

Looks like the above link was wrong / stale or something, not sure
what happened there -- sorry about that!

Here's a link showing the new interface is documented now in the
man-pages project:

https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/?id=e450bcf6e35a5c227c5e80cdb4e44bb89516a5ee

and the man-pages announcement of the new version released, which
mentions ioctl_eventpoll being included in this release:

https://lore.kernel.org/linux-man/cpolays26kcjvekvowwik3di3ut66puls47w3gvdfwep66uaul@ka4omfzltwcs/

Likewise, uclibc-ng has made a new release with the new interface:

https://mailman.openadk.org/mailman3/hyperkitty/list/devel@uclibc-ng.org/thread/AGCAPZZ5OFFN4P2F6WG6LKD6OUUT5NPE/

I would assume glibc will cut a new revision in ~August according to
their wiki, which will include this ioctl.

Let me know if there's anything at all I can do to help you / the
musl project get my patch merged.

Thanks,
Joe