From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id A7ABE23E05 for ; Tue, 18 Jun 2024 19:15:42 +0200 (CEST) Received: (qmail 30692 invoked by uid 550); 18 Jun 2024 17:15:37 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 30654 invoked from network); 18 Jun 2024 17:15:37 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1718730928; x=1719335728; darn=lists.openwall.com; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+xu5gcVl27ytwNnqgIplRqgByrwgdnvE7E0yvCPvLjc=; b=vdACh8qLDDTvaus0+7NcwjBbeEB6CLdcGHRiw0XNArNUo7m9FnWGmh8dRxKJTQrMIW 9btjgUU0N7ajsfPBCvgrGBlx8AoSTJgqRxd5I7PTqET+vBq+mEw4hTZwzRbBvlXcUxNf km4yUCA2sYpb+0uWk6vz7Bhf+OuJ4kWMEYozg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718730928; x=1719335728; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+xu5gcVl27ytwNnqgIplRqgByrwgdnvE7E0yvCPvLjc=; b=CIue1ukMb/4rXzR6snk8NE4V3XNciyhG2d9MTVd/t6MEOov1sEXc5oLWyxQ9byoJsc pxKXGPoJQQ5ExFrdg8fgmYYaSLbE5uNa2x7hyluVHc+y9iow/LpvknsOeth38cdl489Q pcVFr3Cgdq43fMxloLFASIvEUgVXUrEHpoV9JfsnTgWy+BmTSx9LkCvu8xu+5SVZOVhN zVwyy46rZjCfze6j41OieN8tJ6OKXvqj8vaoP12g2oezbfai/leTlss5oIgCn5R1TAp0 Km+mLcdK6Mzn6o2h6LN1BLLKKt+bDNWsQ3aRPpD2SfoRKfv4JBU2JROwmeDTBCjLWu5c gDdw== X-Gm-Message-State: AOJu0YwSKz96PGxD7KeOZC9hxdO/jSNqzuNq7XkhzgaDxR57cecVuOUl va5/kgzxkqCecrA37zAA9HifC54eDlBaMk/5+auDQlP/Iyp/SnaizIOdXVURdEU= X-Google-Smtp-Source: AGHT+IGXAXLpTfL4LE7Ic7bV9NRfFzHTsoxvFbucu/MUr8weeHHV2hoBq6p5/pw3+qP7AZ5e7BOqyA== X-Received: by 2002:a05:6a00:1acb:b0:705:befb:fcd2 with SMTP id d2e1a72fcca58-70629cf01c4mr289489b3a.33.1718730928202; Tue, 18 Jun 2024 10:15:28 -0700 (PDT) Date: Tue, 18 Jun 2024 10:15:25 -0700 From: Joe Damato To: Rich Felker Cc: musl@lists.openwall.com Message-ID: References: <20240529064959.1733708-1-jdamato@fastly.com> <20240529131707.GI10433@brightrain.aerifal.cx> <20240610160551.GO10433@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [musl] [PATCH] sys/epoll.h: add epoll ioctls On Wed, Jun 12, 2024 at 10:10:21AM -0700, Joe Damato wrote: > On Mon, Jun 10, 2024 at 10:15:25AM -0700, Joe Damato wrote: > > On Mon, Jun 10, 2024 at 12:05:52PM -0400, Rich Felker wrote: > > > On Sun, Jun 02, 2024 at 04:05:25PM -0700, Joe Damato wrote: > > > > On Wed, May 29, 2024 at 08:11:13AM -0700, Joe Damato wrote: > > > > > On Wed, May 29, 2024 at 09:17:07AM -0400, Rich Felker wrote: > > > > > > On Wed, May 29, 2024 at 06:49:59AM +0000, Joe Damato wrote: [...] > > > > > > This is probably okay, but we should at least ask if sys/ioctl.h is > > > > > > going to be a namespace mess. Is the intent to bring all of it in, or > > > > > > just to get the EPIOC* macros which depend on _IOW and _IOR? > > > > > > > > > > Yes, sys/ioctl.h is pulled in for the _IOW and _IOR macros. > > > > > Similar to, for example, sys/mtio.h in musl, which also pulls in > > > > > sys/ioctl.h. > > > > > > > > > > > On glibc, does it pull in sys/ioctl.h? > > > > > > > > > > Yes, the code I've submit for glibc does pull in sys/ioctl.h. > > > > > > > > > > That code has been approved by a glibc committer, but not yet merged > > > > > to the tree (I assume that will happen in a few days): > > > > > > > > > > https://sourceware.org/pipermail/libc-alpha/2024-May/157166.html > > > > > > > > Just wanted to follow up on the above. > > > > > > > > Were you expecting me to make any changes or did you want to wait > > > > until libc takes the code before accepting it? > > > > > > > > FWIW: > > > > > > > > uclibc has taken the patch here: > > > > https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/commit/?id=8bb33a2e1f2baec2078581d77e181f1ead5f51aa > > > > > > > > And musl has similar code in include/sys/mount.h: > > > > https://git.musl-libc.org/cgit/musl/tree/include/sys/mount.h#n8 > > > > > > I think it's okay as-is if this is what everyone else is doing too. > > > This is not a standard header so there aren't strong constraints on > > > what it can do; I just didn't want to be gratuitously more > > > namespace-invasive than on other systems with the same header. > > > > OK, sure that makes sense. > > > > BTW, since my email glibc has merged this: > > https://sourceware.org/git/?p=glibc.git;a=commit;h=92c270d32caf3f8d5a02b8e46c7ec5d9d0315158 > > > > Let me know if you'd like me to do anything else to help get this > > merged to musl. > > Apologies on bumping the thread again, just wanted to also mention > the man-pages project has also taken the new man page documenting > the interface for glibc: > > https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/?h=ioctl&id=e450bcf6e35a5c227c5e80cdb4e44bb89516a5ee > > Is there an equivalent documentation I should submit a similar > change to that is musl specific? If so, please let me know and I'd > be happy to do so. Looks like the above link was wrong / stale or something, not sure what happened there -- sorry about that! Here's a link showing the new interface is documented now in the man-pages project: https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/?id=e450bcf6e35a5c227c5e80cdb4e44bb89516a5ee and the man-pages announcement of the new version released, which mentions ioctl_eventpoll being included in this release: https://lore.kernel.org/linux-man/cpolays26kcjvekvowwik3di3ut66puls47w3gvdfwep66uaul@ka4omfzltwcs/ Likewise, uclibc-ng has made a new release with the new interface: https://mailman.openadk.org/mailman3/hyperkitty/list/devel@uclibc-ng.org/thread/AGCAPZZ5OFFN4P2F6WG6LKD6OUUT5NPE/ I would assume glibc will cut a new revision in ~August according to their wiki, which will include this ioctl. Let me know if there's anything at all I can do to help you / the musl project get my patch merged. Thanks, Joe