From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.2 Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by inbox.vuxu.org (OpenSMTPD) with SMTP id a3850b5e for ; Wed, 12 Feb 2020 19:59:36 +0000 (UTC) Received: (qmail 6099 invoked by uid 550); 12 Feb 2020 19:59:34 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 6081 invoked from network); 12 Feb 2020 19:59:34 -0000 To: musl@lists.openwall.com References: <20200122141557.GA8157@brightrain.aerifal.cx> <87ftg7k1at.fsf@oldenburg2.str.redhat.com> <20200122144243.GZ30412@brightrain.aerifal.cx> <87a76fjzpx.fsf@oldenburg2.str.redhat.com> <20200122220515.GH30412@brightrain.aerifal.cx> <38d0e03d-4718-8085-4474-981fdef9b4b8@cs.ucla.edu> <87zhdonhxg.fsf@mid.deneb.enyo.de> <20200212130555.GX1663@brightrain.aerifal.cx> <20200212190742.GZ1663@brightrain.aerifal.cx> From: "A. Wilcox" Autocrypt: addr=awilfox@adelielinux.org; prefer-encrypt=mutual; keydata= mQINBE+DjPIBEADTQ1H/e/avDUhgt8+T3TJpjGYoY9Y47EMfHqWMm9LjR9aiZSG6GWRbpjWS 4V0DqzIhNQw7HLkPws9CVqQkmpIeltQyGDV2qcR5AXxJ4lCRWHxwRzWE0cCzhLUR9BBWOO0U NINQY+2IqmzRAqXZ9zL+mGTles/qeheXmaWLKf/T0kqJFihoM+ItQvUWOkWUdVv0prhzXr9Q QUdt0NTIW8n4sPwtuSvQgqwSzCJQArh1myugVSGiIIN38pCU8g41Vh35mHHhbHjbn0o1mhrX B/gbsndGo7QQBKz4CPaSel+Fl92dCvVWTp1XYyjqeZx2xlx1zfDrXOTuzY1WmNHi7BgHYuem tG7Zyp7u9MR6FvLKgQhmvCQZXaa+9oNtwKckxoP/I5R8ede9YRb6pLyG5JC0pTTk7kpUZCX2 tm8pLKy899zomm8BBm71aEJHE44ABEl/PbM7tA7XhSPiWsdBmVCxH4bqpUgGMx0ztqhNsUul SDDhiAWgtYFHATynhmeKBDKthkO7lj4CzwI54dn1uiwDtvUFVyVsPMjJcCxFnONbOPcvm1R9 sDg5sn57dv0f+EtaU3ppZdotutjM9X7OEC93d1flO3k1LO20qn2ZcI24f3tEOLAjn5xZ1GdV 3BYBwrtuaaiO8tMdp0uAtILzkkrcr0vOi2/SngxtXFw+44X+WQARAQABtDNBLiBXaWxjb3gg KEFkw6lsaWUgTGludXgpIDxhd2lsZm94QGFkZWxpZWxpbnV4Lm9yZz6JAjoEEwEIACQCGwMF CwkIBwIGFQgJCgsCBBYCAwECHgECF4AFAlhEpGYCGQEACgkQyynLUZIrnRQu5RAAqxHJdNIQ ucYYUaYX4EHJte4OAZbxXeGgMi4fe4m2qkMrd8U6VDfRbjsqETK7fOJdrIjvp+xrMTMvj36C LZ5YuBVmvTd4+Qn54y+8doMUtZppjW9Njwols3zCeaZR/4Iid2GjS7+avgVEhMuxlo5apygb n84VhdLRPAs2BtyqUWUhlLs2nXg6kzI/yT8frGGCN36Xewe35jrhl7h4d54t7h+wYcYw52Yt GHs/R+yPlCGPrlzh8IGwjDWDaUrQAqWdU3B2UG4g/yn/JYZrkvfbm7AhpBP5trY2jbm7sfTM NoClDDwgf0K8Kfj0LeBUzOLqGgQNBdaJ2x7f1xq5tJjAPmVL6oMElqyDz9ycUXvelLMnxgXI sjndF+K1aKjg6Ok68BfTo+tnUqmEjqAhjLBCSphQJavww8pU9KSPmxOr0GfjoiYELeoCdTe2 U44bhFwCcf5tG1qdu8l4pes1YPRVAVyr4J/BlS2e3FyU3MsYlma9toYghJZ0k9dVOqx5YXj9 B2keDpX1D7uEJUHpoRSPylLYKJCcNuzrsaK0gvczkgUvhaiij8qnlLEmDsv7KMdsv+qxknNC vdCBgoiYn01ZJZJrlllOEXpVAXfQDKcqGnIJ4GX87TIu3hR94tw4LOCayfRpN2Y4zlACPLaZ KiSon4ySDo+ooYQ8WgwH1y1ESsa5Ag0ET4OM8gEQAOI/n9h9v2TBOiLUt/nL+HOdxqvkfrKp mDHXx6ctJSm0VBHhHCxKN6Tk2B0BsUXcgR+BD76Tw4kTQvuj3E87m13xHRtASdCmnkvGhU4c JJ9ZbJbJhPLNr9qPUxwCQxFyMrFri/9GnE0Kbv5FfxsLQy9Slubnyg3CfI/wIP5pOoVFA2qI UmsQS155DmhbV2m0FDf0san01ZRMFYVcUUktcmFo0Xmr6PAxZ0FTaxSF8+921lKrvShcsnMv Osrf5toJGEdQw/IMO5rKH1m+q3qWQAOw4uF4WQJrGvhEsVK8G4mC6EBDTbxFVDtyBTMAGUVS t+Yb5i0iIYiMAP2MEJ+twg58PV+5RglheTGP9iPW0xReI1sOD9jfIrQbwqWpOchDGBUpQx4q DFYzzcbjvAP1k2o0mwMby5DJlVwktUiXXtOWZXKZXfTnCA65x1bC6gbtMrXN1CWkyjKT9xj9 Z5WlpZaeqe2SZkLG3/N7r4bSbw/Z6NsYeJ8CpSe6SfoWSsjebD6kbXlF5dsQf8aMUjaZAHp0 UpinfgWNh+58128yddsRMsidjU/MmwhzcRFsvn3rkgtnK4IwpLEfssChNPa26qwfcsvQ+AQU CCRd/GIZ8AkOVySQ30J8Assa/T3nc6VNKRVgsAiSClkeqVevAZmUMUbvH8f3cTe1VFn6kR3q pvfTABEBAAGJAh8EGAECAAkFAk+DjPICGwwACgkQyynLUZIrnRQifQ//f++reIP4el9Un1w4 11boSy1iBALnv58YSQQHPIZ4dq5hr8P1Hp3GDz+o6JFKeIHq5RYw2ornumS9waDbz7dRD1nc N5sMoVfR2g2P7honq59r3velxX36PmifHMmxb8MTqbCSJJRisqjWTMg7CZxH0NQ28qMtpiAw kvoEb+l2Uc/gKnvcpPfVJ/X0b3go0xAe9GA7Os9thjtl1v+I7c2+xjPUtvv+pDGRb9To2+Sw zOGwogbTrVw7KgAFhktx6i8tenXZRf36O0GTACRY//qHNoNNy5H4LYmfyHj6VU2ehwNJTlkK H/8oYV7fkOdcs6DZAnxeiOXUKpHC6ck0D0sWQ42GTeEraospQevGTrp1FZdYnfXznUFXuC6W jHR9piQehutMJ1vCP+DIRLGOMzV1TFWflpo71lb4AFLU3UOS/N7Cd8F+w1nG3WPn7UjFCMrc Xf268AEe0xwakXgNtwo2MTbtQSAO5AKYyGm/hnoLZg4YQ2eBPU95jUV+GMoEM/8Q0BJgsyF0 66NfhBXtuo50AipcARmnoqi6NDOKpC6mqiEYGsVuyQ9cRtkk9Jl98tXmnjxQlSL2nb4ErwJJ SyJq3hwiKMUJcw88IRNtYBe+dXaW4kDBTRha1k+brWZbu4tUlRWLVcSGjtP1pVukXA/SQ6a1 N7qhRF0UHQZkMW1rGbU= Organization: =?UTF-8?Q?Ad=c3=a9lie_Linux?= Message-ID: Date: Wed, 12 Feb 2020 13:59:09 -0600 User-Agent: Mozilla/5.0 (X11; Linux ppc64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200212190742.GZ1663@brightrain.aerifal.cx> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="S1tSt8sIG4z6WrAjs8b5E7MmMXernDyTF" Subject: Re: bug#39236: [musl] coreutils cp mishandles error return from lchmod This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --S1tSt8sIG4z6WrAjs8b5E7MmMXernDyTF Content-Type: multipart/mixed; boundary="gEdtiG1WBR4ek1qEbq1WH73PHOP2olf2m" --gEdtiG1WBR4ek1qEbq1WH73PHOP2olf2m Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 12/02/2020 13:07, Rich Felker wrote: > On Wed, Feb 12, 2020 at 08:05:55AM -0500, Rich Felker wrote: >> On Wed, Feb 12, 2020 at 12:50:19PM +0100, Florian Weimer wrote: >>> * Paul Eggert: >>> >>>> On 1/22/20 2:05 PM, Rich Felker wrote: >>>>> I think we're approaching a consensus that glibc should fix this to= o, >>>>> so then it would just be gnulib matching the fix. >>>> >>>> I installed the attached patch to Gnulib in preparation for the upco= ming=20 >>>> glibc fix. The patch causes fchmodat with AT_SYMLINK_NOFOLLOW to wor= k on=20 >>>> non-symlinks, and similarly for lchmod on non-symlinks. The idea is = to=20 >>>> avoid this sort of problem in the future, and to let Coreutils etc. = work=20 >>>> on older platforms as if glibc 2.32 (or whatever) is already in plac= e. >>> >>> The lchmod implementation based on /proc tickles an XFS bug: >>> >>> >> >> Uhg, why does Linux even let the fs driver see whether the chmod is >> being performed via a filename, O_PATH fd, or magic symlink in /proc? >> It should just be an operation on the inode. >=20 > OK, I don't think it's actually clear from the test that the use of > the magic symlink is the cause. It's plausible that XFS just always > returns failure on success for this operation, and I don't have XFS to > test with. My root fs is XFS, but I only have musl to test with. Is there a test case I can run on musl to determine the behaviour of XFS for you? The only glibc distribution that supports my platform is Void, so I don't know if the Void glibc spin in a chroot would be sufficient if there is no way to do this from a musl system. Best, --arw --=20 A. Wilcox (awilfox) Project Lead, Ad=C3=A9lie Linux https://www.adelielinux.org --gEdtiG1WBR4ek1qEbq1WH73PHOP2olf2m-- --S1tSt8sIG4z6WrAjs8b5E7MmMXernDyTF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjNyWOYPU1SaTSMHHyynLUZIrnRQFAl5EWQ0ACgkQyynLUZIr nRThDRAAhRR2pSxQzft4de2+hw3BUIAoV89OTRuUKOQ9VLnDS4J2/KjTPc5R8ROI xsbx1S0bariz3OsSifArNx9KMRCIGjzmlYATkIPcURqqkJ6aCQdfiSwobgGoPT5F 3l8hQaOsOPBYyA3AZv8Yha/tmCW1GWasARzlyzQgbV5pkHlapErheHhc/85+xTfh ZypEtbUJYlY676a3QnDSUD2T8EoNS3v610fH3nCevSWds+JiWagAI3n5vYaGmBOn cDIAfbbu+JiX4YSrvxOXeaFKP5zRThexdIp4rnHDJOZyuAvslRz2yA5hq+W2kxcV XWPGjQUD+qm5nI8pK5lFL4GSPTGOLG/P8FlX5U+plRMnefCjxmPuAcJIzMrommmw djjxh+fkRQ9iDnzCfskVzmsI+cVBqtlrlsiMXEqsVWcV3pHFZPeAASR0EwN6jYGq /HST+XSr6SM/gRpNkKqAtPOVLuAB0x5nYc0vh33uKz9239Z+hBzVzFPc1H+gJUNm mt3nq91FIEbPP+MhKW+JUzuUZjAxIroEyPFjSQ+PXWklM+mglT+2l1GKqCPO53Hl lsawlruF/E1a2VCCaHQoOk74fhgqehx6uVGs/IwUqgC5Re6tioKirQ02ZXJCEHOD UTGYMUj0jH812WvVJN8/inDII+g+Yl73ncH09p1bqeMOPm341Ys= =3JxF -----END PGP SIGNATURE----- --S1tSt8sIG4z6WrAjs8b5E7MmMXernDyTF--