From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12894 Path: news.gmane.org!.POSTED!not-for-mail From: Philip Homburg Newsgroups: gmane.linux.lib.musl.general Subject: inet_ntop bug in 1.1.19 Date: Mon, 4 Jun 2018 15:57:09 +0200 Message-ID: Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------8F4196F3EC56CBABD42D26DC" X-Trace: blaine.gmane.org 1528121622 22183 195.159.176.226 (4 Jun 2018 14:13:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 4 Jun 2018 14:13:42 +0000 (UTC) User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 To: musl@lists.openwall.com Original-X-From: musl-return-12910-gllmg-musl=m.gmane.org@lists.openwall.com Mon Jun 04 16:13:38 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1fPqEp-0005Yo-TS for gllmg-musl@m.gmane.org; Mon, 04 Jun 2018 16:13:36 +0200 Original-Received: (qmail 28459 invoked by uid 550); 4 Jun 2018 14:15:43 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 9899 invoked from network); 4 Jun 2018 13:57:06 -0000 Openpgp: preference=signencrypt Autocrypt: addr=philip.homburg@ripe.net; prefer-encrypt=mutual; keydata= xsFNBFRA5z0BEACZcLhkuXaCvoy620szsH0PeAQpP5793rMCpuiVr4TqXIdL8tnrbZJ8yvdm dVRPGyietY07eDL327Pt4K45WGNUwfKrftNVvFX0GfdY7LaTGhXPK0zCAMi5PJmehSauFGkx KCXQPMDMF0jG4a/bVyrZi1Ds/SVnqVlweNyi0dlOyoa8zrSf+xBOkCzg/kBZoe2DjXzC5edP zwxT7MGMuU8TsV1Ro4AZmqzFoqkDtXEXV6Enl+tfeu0p9gV/epa/TtRA3TgoKpG1sKF9kUOg w3dbsoHJDLAALZhotd9RrFW9AaNZ/7FobWleD51pvr9lbZHT5gd6M1y6KUO6HFAT3lSHSfZn Hx9Q1U3doyDYHQusy2u41vOM2q3gdZo2GLc9UglqbgRyq2ovwuw0RQDNbJ+Km54mVYKUm6YY k3DXEBE+YEZ+wpdiDSKL3jO1mGNhqaCBnEpIIog6/PoQkvHYGN2vOWx0p+/3dxZ1NZukxJzv jDF8R34eVowoAanOXMa3gaNYLWnuuQZg/dquldPzoBYKqP/5lyOkn3vDxwPwpTwlhHF5j6HT rYR+4ciRea863lZuttsNjfbtTRbZavLK/481zKopSj0XXUgWtHNzxICHOEvsP/yusK1+cAaH 0P2P/79d6woeHUxmD8Vu8RrA1gxAsx9O+yoKbZoE9BqsWvlj+wARAQABzShQaGlsaXAgSG9t YnVyZyA8cGhpbGlwLmhvbWJ1cmdAcmlwZS5uZXQ+wsF4BBMBAgAiBQJUQOgMAhsDBgsJCAcD AgYVCAIJCgsE Content-Language: en-GB X-ACL-Warn: Delaying message X-RIPE-Signature: 0fee531e21a88c18cdf36def4e00b44105c2a3ad20e7ea81c3e7cc40bf229f62 Xref: news.gmane.org gmane.linux.lib.musl.general:12894 Archived-At: This is a multi-part message in MIME format. --------------8F4196F3EC56CBABD42D26DC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit (Please CC me on any replies, I'm not subscribed to the list) inet_ntop doesn't conform to RFC 5952 (A Recommendation for IPv6 Address Text Representation). I attached a test program to demonstrate the issue and a patch: $ cc inet_ntop_test.c musl-1.1.19/src/network/inet_ntop.c $ ./a.out Section 4.2.2 test failed: got 2001:db8::1:1:1:1:1, expected 2001:db8:0:1:1:1:1:1 Found 1 error. --------------8F4196F3EC56CBABD42D26DC Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="inet_ntop_test.c" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="inet_ntop_test.c" LyoKQ2hlY2sgaWYgaW5ldF9udG9wIGlzIGFjY29yZGluZyB0byBSRkMgNTk1MgoqLwoKI2lu Y2x1ZGUgPGVycm5vLmg+CiNpbmNsdWRlIDxzdGRpby5oPgojaW5jbHVkZSA8c3RkbGliLmg+ CiNpbmNsdWRlIDxzdHJpbmcuaD4KI2luY2x1ZGUgPGFycGEvaW5ldC5oPgojaW5jbHVkZSA8 bmV0aW5ldC9pbi5oPgojaW5jbHVkZSA8c3lzL3NvY2tldC5oPgoKLyogU2VjdGlvbiA0LjE6 IEhhbmRsaW5nIExlYWRpbmcgWmVyb3MgaW4gYSAxNi1CaXQgRmllbGQgKi8Kc3RydWN0IGlu Nl9hZGRyIHM0MV9pbnB1dCA9IHsgewoJCQkweDIwLCAweDAxLCAweDBkLCAweGI4LCAweDAw LCAweDAwLCAweDAwLCAweDAwLAoJCQkweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAw eDAwLCAweDAwLCAweDAxIH0gfTsKY2hhciAqczQxX3N0ciA9ICIyMDAxOmRiODo6MSI7Cgov KiBTZWN0aW9uIDQuMi4xOiBTaG9ydGVuIGFzIE11Y2ggYXMgUG9zc2libGUgKi8Kc3RydWN0 IGluNl9hZGRyIHM0MjFfaW5wdXQgPSB7IHsKCQkJMHgyMCwgMHgwMSwgMHgwZCwgMHhiOCwg MHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwKCQkJMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgw MCwgMHgwMiwgMHgwMCwgMHgwMSB9IH07CmNoYXIgKnM0MjFfc3RyID0gIjIwMDE6ZGI4Ojoy OjEiOwoKLyogU2VjdGlvbiA0LjIuMjogSGFuZGxpbmcgT25lIDE2LUJpdCAwIEZpZWxkICov CnN0cnVjdCBpbjZfYWRkciBzNDIyX2lucHV0ID0geyB7CgkJCTB4MjAsIDB4MDEsIDB4MGQs IDB4YjgsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDEsCgkJCTB4MDAsIDB4MDEsIDB4MDAsIDB4 MDEsIDB4MDAsIDB4MDEsIDB4MDAsIDB4MDEgfSB9OwpjaGFyICpzNDIyX3N0ciA9ICIyMDAx OmRiODowOjE6MToxOjE6MSI7CgovKiBTZWN0aW9uIDQuMi4zYTogQ2hvaWNlIGluIFBsYWNl bWVudCBvZiAiOjoiICovCnN0cnVjdCBpbjZfYWRkciBzNDIzYV9pbnB1dCA9IHsgewoJCQkw eDIwLCAweDAxLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAxLAoJCQkweDAw LCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAxIH0gfTsKY2hhciAq czQyM2Ffc3RyID0gIjIwMDE6MDowOjE6OjEiOwoKLyogU2VjdGlvbiA0LjIuM2I6IENob2lj ZSBpbiBQbGFjZW1lbnQgb2YgIjo6IiAqLwpzdHJ1Y3QgaW42X2FkZHIgczQyM2JfaW5wdXQg PSB7IHsKCQkJMHgyMCwgMHgwMSwgMHgwZCwgMHhiOCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgw MCwKCQkJMHgwMCwgMHgwMSwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMSB9 IH07CmNoYXIgKnM0MjNiX3N0ciA9ICIyMDAxOmRiODo6MTowOjA6MSI7CgpzdHJ1Y3QgdGVz dHMgewoJY2hhciAqbGFiZWw7CglzdHJ1Y3QgaW42X2FkZHIgKmFkZHJwOwoJY2hhciAqKnN0 cnA7Cn0gdGVzdHNbXSA9IHsKCXsgIlNlY3Rpb24gNC4xIiwgJnM0MV9pbnB1dCwgJnM0MV9z dHIgfSwKCXsgIlNlY3Rpb24gNC4yLjEiLCAmczQyMV9pbnB1dCwgJnM0MjFfc3RyIH0sCgl7 ICJTZWN0aW9uIDQuMi4yIiwgJnM0MjJfaW5wdXQsICZzNDIyX3N0ciB9LAoJeyAiU2VjdGlv biA0LjIuM2EiLCAmczQyM2FfaW5wdXQsICZzNDIzYV9zdHIgfSwKCXsgIlNlY3Rpb24gNC4y LjNiIiwgJnM0MjNiX2lucHV0LCAmczQyM2Jfc3RyIH0sCgl7IE5VTEwsIE5VTEwsIE5VTEwg fQp9OwoKaW50IG1haW4odm9pZCkKewoJaW50IGksIGVycm9yczsKCWNoYXIgYnVmW0lORVQ2 X0FERFJTVFJMRU5dOwoKCWVycm9ycz0gMDsKCWZvciAoaT0gMDsgdGVzdHNbaV0ubGFiZWwg IT0gTlVMTDsgaSsrKQoJewoJCWlmIChpbmV0X250b3AoQUZfSU5FVDYsIHRlc3RzW2ldLmFk ZHJwLCBidWYsIHNpemVvZihidWYpKSA9PQoJCQlOVUxMKQoJCXsKCQkJZnByaW50ZihzdGRl cnIsICJpbmV0X250b3AgZmFpbGVkIGZvciB0ZXN0ICVzOiAlc1xuIiwKCQkJCXRlc3RzW2ld LmxhYmVsLCBzdHJlcnJvcihlcnJubykpOwoJCQlleGl0KDEpOwoJCX0KCQlpZiAoc3RyY21w KGJ1ZiwgKnRlc3RzW2ldLnN0cnApICE9IDApCgkJewoJCQlmcHJpbnRmKHN0ZGVyciwgIiVz IHRlc3QgZmFpbGVkOiBnb3QgJXMsIGV4cGVjdGVkICVzXG4iLAoJCQkJdGVzdHNbaV0ubGFi ZWwsIGJ1ZiwgKnRlc3RzW2ldLnN0cnApOwoJCQllcnJvcnMrKzsKCQl9Cgl9CglpZiAoZXJy b3JzKQoJewoJCWZwcmludGYoc3RkZXJyLCAiRm91bmQgJWQgZXJyb3Ilcy5cbiIsCgkJCWVy cm9ycywgZXJyb3JzID09IDEgPyAiIiA6ICJzIik7CgkJZXhpdCgxKTsKCX0KCWV4aXQoMCk7 Cn0KCQo= --------------8F4196F3EC56CBABD42D26DC Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="inet_ntop.c.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="inet_ntop.c.patch" LS0tIG11c2wtMS4xLjE5L3NyYy9uZXR3b3JrL2luZXRfbnRvcC5jCTIwMTgtMDItMjIgMTk6 Mzk6MTkuMDAwMDAwMDAwICswMTAwCisrKyBpbmV0X250b3AuYwkyMDE4LTA2LTA0IDE1OjUx OjIzLjE5MjIwNzk3MyArMDIwMApAQCAtMzQsNiArMzQsNyBAQAogCQlmb3IgKGk9YmVzdD0w LCBtYXg9MjsgYnVmW2ldOyBpKyspIHsKIAkJCWlmIChpICYmIGJ1ZltpXSAhPSAnOicpIGNv bnRpbnVlOwogCQkJaiA9IHN0cnNwbihidWYraSwgIjowIik7CisJCQlpZiAoajw0KSBjb250 aW51ZTsKIAkJCWlmIChqPm1heCkgYmVzdD1pLCBtYXg9ajsKIAkJfQogCQlpZiAobWF4PjIp IHsK --------------8F4196F3EC56CBABD42D26DC--