From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 68CD32CB8A for ; Fri, 15 Mar 2024 01:59:15 +0100 (CET) Received: (qmail 13705 invoked by uid 550); 15 Mar 2024 00:54:55 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 13634 invoked from network); 15 Mar 2024 00:54:55 -0000 To: Leah Neukirchen Cc: musl@lists.openwall.com References: <20240312005150.GB4163@brightrain.aerifal.cx> <4f5abddd-09f9-f05f-6cc6-719fc365b449@loongson.cn> <20240313145215.GF4163@brightrain.aerifal.cx> <4ee5d461-a0c2-d70d-ca81-4325d0103516@loongson.cn> <87jzm5j5cs.fsf@vuxu.org> From: lixing Message-ID: Date: Fri, 15 Mar 2024 08:58:53 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <87jzm5j5cs.fsf@vuxu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8DxdMxOnfNl7JFaAA--.57806S3 X-CM-SenderInfo: pol0x03j6o00pqjv00gofq/ X-Coremail-Antispam: 1Uk129KBj93XoW7Ww1DZrWUJF45uFW5WFyUurX_yoW8CrWDpa y7Cw1qkF45J397u392q3Z8Cryqvw4kC3y7Wan3t34F9F4DJr9IqF18K3sIgrykJws5WrWj vFW0934UWFW5XagCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUv0b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ Gr0_Gr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1l5I 8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AK xVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzV AYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E 14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jrv_JF1lIx kGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAF wI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU1CPfJUU UUU== Subject: Re: [musl] loongarch64 atomics not working? 在 2024/3/14 下午9:44, Leah Neukirchen 写道: > lixing writes: > >> we checked the objdump binaries for -Os and -O2, the a_cas_p implement >> looks ok for both. >> >> Also, we cross build the musl and mksh with -Os, the binary hang with >> qemu user mode emulation , but not hang in the real hardware. >> >> so, maybe this is a qemu problem, we will let our qemu guys to check >> this problem. > Pretty surely it's a bug in QEMU. qemu 8.1.5 works with mksh.Os, > qemu 8.2.1 hangs. I have bisected the issue down to: > > commit c5af6628f4be5d30800233e59ba3842ca19a12e6 (HEAD) > Author: Jiajie Chen > Date: Tue Aug 22 09:13:52 2023 +0200 > > target/loongarch: Extract make_address_i() helper > > Reverting this hunk fixes it: > > diff --git a/target/loongarch/insn_trans/trans_atomic.c.inc b/target/loongarch/insn_trans/trans_atomic.c.inc > index fbc081448d..bff3e7a74c 100644 > --- a/target/loongarch/insn_trans/trans_atomic.c.inc > +++ b/target/loongarch/insn_trans/trans_atomic.c.inc > @@ -7,8 +7,9 @@ static bool gen_ll(DisasContext *ctx, arg_rr_i *a, MemOp mop) > { > TCGv dest = gpr_dst(ctx, a->rd, EXT_NONE); > TCGv src1 = gpr_src(ctx, a->rj, EXT_NONE); > - TCGv t0 = make_address_i(ctx, src1, a->imm); > + TCGv t0 = tcg_temp_new(); > > + tcg_gen_addi_tl(t0, src1, a->imm); > tcg_gen_qemu_ld_i64(dest, t0, ctx->mem_idx, mop); > tcg_gen_st_tl(t0, cpu_env, offsetof(CPULoongArchState, lladdr)); > tcg_gen_st_tl(dest, cpu_env, offsetof(CPULoongArchState, llval)); > > I think the issue is that make_address_i optimizes the addition away > if a->imm is zero, but that's just from looking at the code for 15min. > > hth,  Our qemu guys debuged the binary find that "ll.d $t0, $t0, 0" make the t0 reg turn to 0,that should be the qemu code problem. thanks. XingLi