From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 669312CBF7 for ; Mon, 19 Aug 2024 17:36:56 +0200 (CEST) Received: (qmail 18146 invoked by uid 550); 19 Aug 2024 15:36:51 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 18101 invoked from network); 19 Aug 2024 15:36:51 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brad-house.com; s=google; t=1724081802; x=1724686602; darn=lists.openwall.com; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=FvhRB8Awz7sU/QI4ySCjU+3d3R4gfGpGq5kGYST5Bc4=; b=LJAomErFEh2qkysvegN9o2Kbduw7qUtLokqSaEJWWQvX1sQzGCW0WhOlTlB3wGm7hE IIVnqF3L4yYvZO8sNUyM78LS/J4GEnhwYes8ZsklKn13Txfb9AeJ/xDiAGfiDGPU5i6s nKI4ownq1A/WUXyLeD5T1NAmKti7hI4OL7qSvYJJqEsLA2lH2bzrVo0AfMdoX0cbX5Fe oYV/D7C9/gnqqOwx8fqhLoKbLSWeQ8kX1UKlOruo6dEvmTmCYxaK1ciP92pDHUkxWtKK d6HfhdWNOhSG+0vWF68Vf/wLC8+Dy9jV/rRaNoWwDJMf3GaedED9ppisWkPisCM2TDpH vXWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724081802; x=1724686602; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FvhRB8Awz7sU/QI4ySCjU+3d3R4gfGpGq5kGYST5Bc4=; b=fbLKvmZtZM0DC4V5OvylE44sfXNfqWlU3sX0nZsrshIvdfimVGlSQODG17jdep0AnS 2nEmJyd04eRYAprlRxFygA/hi3DNfLW9RpG1jMnc7Kx4RvVBXXX/sPqAuvh8Kq7+eyyO UTM7y2jyMR9hWItWwMovPuYcBvA1ngRhJdegFcXdCW6jl5GaJ1TEm9Nqg5TPpwr3fWVP vsJracTWdsV/0HXlJFK8t60fzT2Ttv6dS6ow9YJ3d6EuS05MSSUx8Evp/xYtQMec4Xi7 AoTemYgoV8NvE5bLKjpcwBTqdJDLGoVmTpk3Tt4dn7UrCdxTS3t/l0aNyR8e04OoUHU2 CSSQ== X-Gm-Message-State: AOJu0YwogTanHEhSJk0dQai9REnYemrxzB3WhIFMaAP5SnDKPMbwW2o1 SwR21XxIs9R0Ol995zSy2DmTDKq+q+U3Lq867275nPOnGfs7FB6HHNCR+pkBnwarfIutOGKn63R y+3I= X-Google-Smtp-Source: AGHT+IHoEyXMXAma/0dzzGb2jC1NbzbOCEpY86FGEy5Dws23cI/giX7Exf/WFemYCBLDmT9seCC93w== X-Received: by 2002:a05:6902:919:b0:e0e:4171:aee6 with SMTP id 3f1490d57ef6-e1180fd8b02mr13235026276.42.1724081802158; Mon, 19 Aug 2024 08:36:42 -0700 (PDT) Message-ID: Date: Mon, 19 Aug 2024 11:36:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: musl@lists.openwall.com References: <20240802233801.GU10433@brightrain.aerifal.cx> <4c03697d-36fd-42e3-8a27-e121d3acc522@brad-house.com> <20240814211623.GL10433@brightrain.aerifal.cx> Content-Language: en-US From: Brad House In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [musl] [PATCH 1/1] IN6_IS_ADDR_LOOPBACK() and similar macros warn on -Wcast-qual On 8/14/24 5:24 PM, enh wrote: > not quite the question you asked, but the new implementation is what > bionic has shipped since 2016, and had the historical castful > implementation before that. (citation needed? > https://android-review.googlesource.com/c/platform/bionic/+/250098) > > On Wed, Aug 14, 2024 at 5:16 PM Rich Felker wrote: >> I think this looks fine. Anyone willing to point a second set of eyes >> at it (or maybe write a test to check whether codegen is same before >> and after) and make sure before I merge it? >> >> Rich @enh, great, I'm guessing Android hit the same types of warnings at some point :) -Brad