From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11122 Path: news.gmane.org!.POSTED!not-for-mail From: Carlos O'Donell Newsgroups: gmane.linux.lib.musl.general,gmane.linux.kernel,gmane.linux.kernel.api Subject: Re: Re: [PATCH resent] uapi libc compat: allow non-glibc to opt out of uapi definitions Date: Wed, 8 Mar 2017 12:29:53 -0500 Organization: Red Hat Message-ID: References: <20161111120820.GA435@nyan> <20170308162507.GY1520@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1488994243 31326 195.159.176.226 (8 Mar 2017 17:30:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Mar 2017 17:30:43 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 Cc: linux-kernel@vger.kernel.org, "David S. Miller" , linux-api@vger.kernel.org, musl@lists.openwall.com To: Rich Felker Original-X-From: musl-return-11137-gllmg-musl=m.gmane.org@lists.openwall.com Wed Mar 08 18:30:37 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1clfQ2-0007PI-DD for gllmg-musl@m.gmane.org; Wed, 08 Mar 2017 18:30:34 +0100 Original-Received: (qmail 17803 invoked by uid 550); 8 Mar 2017 17:30:38 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 17781 invoked from network); 8 Mar 2017 17:30:37 -0000 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=PxUialXBhMOZ03vb8VxxAHOElLB04ti4I9w9h0SFdOs=; b=EYffm/SmJKk0ftOA/aQip7HQyUynkCEqetpSLH526/ZBpWAuRc+vWY/Xuuktw0UFsd LOVSs/AUiSAAk244MIWJqzCgQdmDPUSVtLnyyfCJq3XkDl1EwqnBEEbpHRyi6nnH5IsX MCocFUNcAI2s0gCI5vgw9Xy1pXx40nd+XxrNPw+R8FkGrMCMzjeeiv2CYeSAb0fgMR/4 t4Hi73HWE5grMJqFy/VUQYao8TQrD1lKk+XcwYG635rtK2LOncHorNHmPkinYoxinlTm nMml2Co/viV35fgZAa1HSSid4Ui3TLQ/1NoG+Rcd/ZsIZEjnnEbQwddDGyB5EchTL6Rf NjZg== X-Gm-Message-State: AFeK/H2d3tmPa/IBv2FSNIsjwsW1OH5q5lI/X9xC/qLVNo+TDhVoa7X+UspRPWT7VRSymFad X-Received: by 10.55.38.149 with SMTP id m21mr2364665qkm.119.1488994195432; Wed, 08 Mar 2017 09:29:55 -0800 (PST) In-Reply-To: <20170308162507.GY1520@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:11122 gmane.linux.kernel:2426543 gmane.linux.kernel.api:22415 Archived-At: On 03/08/2017 11:25 AM, Rich Felker wrote: > On Wed, Mar 08, 2017 at 10:53:00AM -0500, Carlos O'Donell wrote: >> On 11/11/2016 07:08 AM, Felix Janda wrote: >>> Currently, libc-compat.h detects inclusion of specific glibc headers, >>> and defines corresponding _UAPI_DEF_* macros, which in turn are used in >>> uapi headers to prevent definition of conflicting structures/constants. >>> There is no such detection for other c libraries, for them the >>> _UAPI_DEF_* macros are always defined as 1, and so none of the possibly >>> conflicting definitions are suppressed. >>> >>> This patch enables non-glibc c libraries to request the suppression of >>> any specific interface by defining the corresponding _UAPI_DEF_* macro >>> as 0. >>> >>> This patch together with the recent musl libc commit >>> >>> http://git.musl-libc.org/cgit/musl/commit/?id=04983f2272382af92eb8f8838964ff944fbb8258 >> >> Would it be possible to amend the musl patch to define the macros to 1. > > I don't follow. They're defined to 0 explicitly to tell the kernel > headers not to define their own versions of these structs, etc. since > they would clash. Defining to 1 would have the opposite meaning. My apologies, I must have misread the original musl patch. Defining them to a known value is exactly what I was looking for. The other outstanding questions remain. -- Cheers, Carlos.