mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Alexander Monakov <amonakov@ispras.ru>
To: musl@lists.openwall.com
Subject: New static analysis results
Date: Thu, 4 Sep 2014 20:45:45 +0400 (MSK)	[thread overview]
Message-ID: <alpine.LNX.2.00.1409042031170.17841@monopod.intra.ispras.ru> (raw)

Hello,

I'm happy to report a few new results from running static code analysis on
musl (from a tool developed where I work).

ctime.c:5
    localtime(t) may return NULL, but that will cause UB in asctime

regexec.c:253
    "return REG_NOMATCH;" in GET_NEXT_WCHAR leaks memory allocated for 'buf'

lookup_serv.c:55
getnameinfo.c:99
    pointless "if (!p) continue;" when "if (!*p) continue;" was probably
    intended

fpathconf.c
    off-by-one error in range check (if (name >= sizeof ...))

Alexander


             reply	other threads:[~2014-09-04 16:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-04 16:45 Alexander Monakov [this message]
2014-09-04 17:13 ` Rich Felker
2014-09-05 18:02   ` Rich Felker
2014-09-05 18:39     ` Alexander Monakov
2014-09-05 18:53       ` Rich Felker
2014-09-05 20:50         ` Jens Gustedt
2014-09-05 21:23           ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1409042031170.17841@monopod.intra.ispras.ru \
    --to=amonakov@ispras.ru \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).