From: Alexander Monakov <amonakov@ispras.ru>
To: musl@lists.openwall.com
Subject: Re: [PATCH] fix a bug in the rand48 family of prng
Date: Sun, 21 Sep 2014 19:56:13 +0400 (MSK) [thread overview]
Message-ID: <alpine.LNX.2.00.1409211946260.13391@monopod.intra.ispras.ru> (raw)
In-Reply-To: <20140921153403.GW21835@port70.net>
On Sun, 21 Sep 2014, Szabolcs Nagy wrote:
> * Jens Gustedt <Jens.Gustedt@inria.fr> [2014-09-21 16:39:34 +0200]:
> >
> > This fixes a bug found by Nadav Har'El, who observed that musl was giving
> > different prn sequences than other systems, even if seeded with the same
> > value.
> >
> > The problem with something like
> >
> > a = lc[0] | lc[1]<<16 | lc[2]+0ULL<<32;
> >
> > where lc[1] is an unsigned short and int is 32bit is the following
> >
> > (1) lc[1] is promoted to int
> > (2) the left shift 16 is performed on int
> >
>
> the fix looks ok, but i'm not clear on why it breaks in practice
UB on shift shouldn't be a problem here; I think the issue is that
"lc[0] | lc[1]<<16" gets sign-extended rather than zero-extended from 32 bit
to 64 bit.
Alexander
next prev parent reply other threads:[~2014-09-21 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 14:39 Jens Gustedt
2014-09-21 15:34 ` Szabolcs Nagy
2014-09-21 15:56 ` Alexander Monakov [this message]
2014-09-21 16:01 ` Alexander Monakov
2014-09-21 16:12 ` Szabolcs Nagy
2014-09-21 16:05 ` Jens Gustedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1409211946260.13391@monopod.intra.ispras.ru \
--to=amonakov@ispras.ru \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).